Re: Review Request: use window role to detect the dashboard

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15436 --- This review has been submitted with commit ee14781eefc60a25846

Re: Review Request: use window role to detect the dashboard

> On July 4, 2012, 7:57 a.m., Andreas Demmer wrote: > > Ship It! I missed that windowRole would be a much better distinction than windowClass is when I initially implemented this effect. Your patch definitely makes sense, so ship it! - Andreas --

Re: Review Request: use window role to detect the dashboard

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15360 --- Ship it! from my side ok, maybe wait a day whether a plasma de

Re: Review Request: use window role to detect the dashboard

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15359 --- Ship it! Ship It! - Andreas Demmer On June 28, 2012, 7:42 p

Re: Review Request: use window role to detect the dashboard

> On July 3, 2012, 8:30 a.m., Martin Gräßlin wrote: > > plasma/desktop/shell/dashboardview.cpp, line 99 > > > > > > maybe plasma-dashboard? I thought to stress that this is the kind of dashboard that carries plasmoi

Re: Review Request: use window role to detect the dashboard

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15330 --- Ship it! I really would like to have a "proper" solution by us

Re: Review Request: use window role to detect the dashboard

> On June 28, 2012, 8:21 p.m., Kai Uwe Broulik wrote: > > Nice catch! > > I do not have a printer that supports reporting ink levels, so I cannot > > test whether it causes unexpected behavior, but I don’t think so. > > Daniel should look over this anyway. > > Thanks for the patch! :) Sorry, Wr

Re: Review Request: use window role to detect the dashboard

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15245 --- Nice catch! I do not have a printer that supports reporting ink

Review Request: use window role to detect the dashboard

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/ --- Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. Descr