Re: Review Request 108308: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/108308/ --- (Updated Sept. 22, 2016, 8:35 p.m.) Status -- This change has been discarded. Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. Repository: kdelibs Description --- When setting "Keep window thumbnails" to "Always (Breaks minimization)", kwin will keep WM_STATE to be NORMAL when a client is minimized while including _NET_WM_STATE_HIDDEN in its _NET_WM_STATE, as confirmed by ICCCM[1] and Extended Window Manager Hints[2]. However, apart from the expected result (breaks minimization: the client will continue to refresh its content) the minimized window is not shown as minimized in icontasks and pager. These two plasma addons (and probably other addons as well) uses KWindowInfo::isMinimized to determine whether the window is minimized. However, this function threat all window that are not Iconic (WM_STATE != ICONIC) as not minimized, in contradiction to the "Extended window manager hints" which says, "Pagers and similar applications should use _NET_WM_STATE_HIDDEN instead of WM_STATE to decide whether to display a window in miniature representations of the windows on a desktop." This patch correct this behavior and therefore correct the behavior of both pager and icontasks in this situation. [1] http://tronche.com/gui/x/icccm/sec-4.html#s-4.1.3.1 [2] http://standards.freedesktop.org/wm-spec/wm-spec-1.3.html#id2731936 Diffs - kdeui/windowmanagement/kwindowinfo_x11.cpp d983c9a Diff: https://git.reviewboard.kde.org/r/108308/diff/ Testing --- Compiled, pager and icontasks shows minimized windows correctly. Also tested on openbox (+plasma's pager) by "Xuetian Weng". Thanks, Yichao Yu
Re: Review Request 108308: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/108308/#review99455 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On Jan. 16, 2013, 2:37 p.m., Yichao Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/108308/ > --- > > (Updated Jan. 16, 2013, 2:37 p.m.) > > > Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. > > > Repository: kdelibs > > > Description > --- > > When setting "Keep window thumbnails" to "Always (Breaks minimization)", kwin > will keep WM_STATE to be NORMAL when a client is minimized while including > _NET_WM_STATE_HIDDEN in its _NET_WM_STATE, as confirmed by ICCCM[1] and > Extended Window Manager Hints[2]. However, apart from the expected result > (breaks minimization: the client will continue to refresh its content) the > minimized window is not shown as minimized in icontasks and pager. > > These two plasma addons (and probably other addons as well) uses > KWindowInfo::isMinimized to determine whether the window is minimized. > However, this function threat all window that are not Iconic (WM_STATE != > ICONIC) as not minimized, in contradiction to the "Extended window manager > hints" which says, "Pagers and similar applications should use > _NET_WM_STATE_HIDDEN instead of WM_STATE to decide whether to display a > window in miniature representations of the windows on a desktop." > > This patch correct this behavior and therefore correct the behavior of both > pager and icontasks in this situation. > > [1] http://tronche.com/gui/x/icccm/sec-4.html#s-4.1.3.1 > [2] http://standards.freedesktop.org/wm-spec/wm-spec-1.3.html#id2731936 > > > Diffs > - > > kdeui/windowmanagement/kwindowinfo_x11.cpp d983c9a > > Diff: https://git.reviewboard.kde.org/r/108308/diff/ > > > Testing > --- > > Compiled, pager and icontasks shows minimized windows correctly. > Also tested on openbox (+plasma's pager) by "Xuetian Weng". > > > Thanks, > > Yichao Yu > >
Re: Review Request 108308: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108308/#review25583 --- i'm fine with this going in for 4.11 where we can get reasonable testing in on it. - Aaron J. Seigo On Jan. 10, 2013, 6:50 a.m., Yichao Yu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108308/ --- (Updated Jan. 10, 2013, 6:50 a.m.) Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. Description --- When setting Keep window thumbnails to Always (Breaks minimization), kwin will keep WM_STATE to be NORMAL when a client is minimized while including _NET_WM_STATE_HIDDEN in its _NET_WM_STATE, as confirmed by ICCCM[1] and Extended Window Manager Hints[2]. However, apart from the expected result (breaks minimization: the client will continue to refresh its content) the minimized window is not shown as minimized in icontasks and pager. These two plasma addons (and probably other addons as well) uses KWindowInfo::isMinimized to determine whether the window is minimized. However, this function threat all window that are not Iconic (WM_STATE != ICONIC) as not minimized, in contradiction to the Extended window manager hints which says, Pagers and similar applications should use _NET_WM_STATE_HIDDEN instead of WM_STATE to decide whether to display a window in miniature representations of the windows on a desktop. This patch correct this behavior and therefore correct the behavior of both pager and icontasks in this situation. [1] http://tronche.com/gui/x/icccm/sec-4.html#s-4.1.3.1 [2] http://standards.freedesktop.org/wm-spec/wm-spec-1.3.html#id2731936 Diffs - kdeui/windowmanagement/kwindowinfo_x11.cpp d983c9a Diff: http://git.reviewboard.kde.org/r/108308/diff/ Testing --- Compiled, pager and icontasks shows minimized windows correctly. Also tested on openbox (+plasma's pager) by Xuetian Weng. Thanks, Yichao Yu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
