Re: Review Request 108355: various fix for battery plasmoid

2013-01-12 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108355/#review25275 --- Ship it! mostly looks good, other than a couple of coding

Re: Review Request 108355: various fix for battery plasmoid

2013-01-12 Thread Aaron J. Seigo
On Jan. 12, 2013, 12:18 a.m., Kai Uwe Broulik wrote: plasma/generic/applets/batterymonitor/contents/code/logic.js, line 97 http://git.reviewboard.kde.org/r/108355/diff/2/?file=106715#file106715line97 But isn't it the dataengine that prematurely triggers a brightnes change and

Re: Review Request 108355: various fix for battery plasmoid

2013-01-12 Thread Kai Uwe Broulik
On Jan. 12, 2013, 12:18 a.m., Kai Uwe Broulik wrote: plasma/generic/applets/batterymonitor/contents/code/logic.js, line 97 http://git.reviewboard.kde.org/r/108355/diff/2/?file=106715#file106715line97 But isn't it the dataengine that prematurely triggers a brightnes change and

Re: Review Request 108355: various fix for battery plasmoid

2013-01-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108355/#review25293 --- This review has been submitted with commit

Re: Review Request 108355: various fix for battery plasmoid

2013-01-12 Thread Aaron J. Seigo
On Jan. 12, 2013, 12:18 a.m., Kai Uwe Broulik wrote: plasma/generic/applets/batterymonitor/contents/code/logic.js, line 97 http://git.reviewboard.kde.org/r/108355/diff/2/?file=106715#file106715line97 But isn't it the dataengine that prematurely triggers a brightnes change and