Kai-Uwe,
Do you want to forward-port this patch to plasma-framework, or should I do it?
(I sense that this might be the reason for CCMAILing me. :-))
-- sebas
On Thursday, June 20, 2013 08:57:17 Kai Uwe Broulik wrote:
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/48/
---
(Updated June 22, 2013, 2:42 p.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/48/#review34881
---
Ship it!
For absolute completeness, the sortCaseSensitivity
On June 22, 2013, 3:24 p.m., Aaron J. Seigo wrote:
For absolute completeness, the sortCaseSensitivity property should also
have a NOTIFY signal .. but i don't see why anyone would ever bind to that
signal and it would require a reimplementation of the set method, so i'm
fine with it
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/48/#review34884
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/48/
---
(Updated June 22, 2013, 3:30 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/48/#review34813
---
the patch is almost ok, tough can you still find a way to make
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/48/
---
Review request for Plasma.
Description
---
This adds support for the
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/48/#review34738
---
plasma/declarativeimports/core/datamodel.h
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/48/
---
(Updated June 20, 2013, 9:41 a.m.)
Review request for Plasma.
Changes
On June 20, 2013, 9:20 a.m., Aaron J. Seigo wrote:
plasma/declarativeimports/core/datamodel.h, line 94
http://git.reviewboard.kde.org/r/48/diff/1/?file=164874#file164874line94
is this necessary, given that there is a setSortCaseSensitivity in the
parent class?
you can bind
On June 20, 2013, 9:20 a.m., Aaron J. Seigo wrote:
plasma/declarativeimports/core/datamodel.h, line 94
http://git.reviewboard.kde.org/r/48/diff/1/?file=164874#file164874line94
is this necessary, given that there is a setSortCaseSensitivity in the
parent class?
Marco Martin
12 matches
Mail list logo
