Re: Review Request 112502: Roughly port devicenotifier to plasma2

2013-09-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112502/#review39354 --- This review has been submitted with commit 5226f67d8f3f896d1a7

Re: Review Request 112502: Roughly port devicenotifier to plasma2

2013-09-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112502/ --- (Updated Sept. 4, 2013, 2:34 p.m.) Status -- This change has been mar

Re: Review Request 112502: Roughly port devicenotifier to plasma2

2013-09-04 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112502/#review39353 --- Ship it! Ship It! - Sebastian Kügler On Sept. 4, 2013, 10:3

Re: Review Request 112502: Roughly port devicenotifier to plasma2

2013-09-04 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112502/ --- (Updated Sept. 4, 2013, 10:33 a.m.) Review request for Plasma and Sebastia

Re: Review Request 112502: Roughly port devicenotifier to plasma2

2013-09-04 Thread Bhushan Shah
> On Sept. 4, 2013, 8:50 a.m., Kai Uwe Broulik wrote: > > plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml, > > line 90 > > > > > > QIcon(deviceItem.icon) ? deviceItem.icon > > (I think

Re: Review Request 112502: Roughly port devicenotifier to plasma2

2013-09-04 Thread Kai Uwe Broulik
> On Sept. 4, 2013, 8:50 a.m., Kai Uwe Broulik wrote: > > plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml, > > line 90 > > > > > > QIcon(deviceItem.icon) ? deviceItem.icon > > (I think

Re: Review Request 112502: Roughly port devicenotifier to plasma2

2013-09-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112502/#review39319 --- plasma/generic/applets/devicenotifier/package/contents/ui/Devi

Review Request 112502: Roughly port devicenotifier to plasma2

2013-09-04 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112502/ --- Review request for Plasma and Sebastian Kügler. Description --- Chang