Re: Review Request 113920: Remove KDE4Support dependency from plasma-frameworks (almost)

2013-11-20 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113920/#review44043 --- Ship it! Tested it here locally. Building plasma-shell against

Re: Review Request 113920: Remove KDE4Support dependency from plasma-frameworks (almost)

2013-11-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113920/ --- (Updated Nov. 19, 2013, 9:58 a.m.) Review request for Plasma. Changes --

Re: Review Request 113920: Remove KDE4Support dependency from plasma-frameworks (almost)

2013-11-19 Thread Aleix Pol Gonzalez
> On Nov. 18, 2013, 7:15 p.m., Sebastian Kügler wrote: > > src/shell/activity.cpp, line 148 > > > > > > QDir::separator() instead of QChar('/') here to avoid unixism. See http://qt-project.org/doc/qt-5.0/qtcore/q

Re: Review Request 113920: Remove KDE4Support dependency from plasma-frameworks (almost)

2013-11-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113920/#review43907 --- src/shell/activity.cpp

Review Request 113920: Remove KDE4Support dependency from plasma-frameworks (almost)

2013-11-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113920/ --- Review request for Plasma. Repository: plasma-framework Description