Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2016-09-22 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114428/#review99444
---



Closing as this review request is more than 2 years old.

If it still applies to current Plasma. Please reopen. Thanks

- David Edmundson


On Dec. 13, 2013, 3:05 p.m., Heena Mahour wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114428/
> ---
> 
> (Updated Dec. 13, 2013, 3:05 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith 
> Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Replaced Text {} by PlasmaComponents.Label {} 
> 
> 
> Diffs
> -
> 
>   mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 
>   mediaelements/mediawelcome/HomeScreenText.qml 35cd20a 
> 
> Diff: https://git.reviewboard.kde.org/r/114428/diff/
> 
> 
> Testing
> ---
> 
> works fine .
> 
> 
> Thanks,
> 
> Heena Mahour
> 
>

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2016-09-22 Thread Heena Mahour 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114428/
---

(Updated Sept. 22, 2016, 8:32 p.m.)


Status
--

This change has been discarded.


Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.


Repository: plasma-mediacenter


Description
---

Replaced Text {} by PlasmaComponents.Label {} 


Diffs
-

  mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 
  mediaelements/mediawelcome/HomeScreenText.qml 35cd20a 

Diff: https://git.reviewboard.kde.org/r/114428/diff/


Testing
---

works fine .


Thanks,

Heena Mahour

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2014-07-29 Thread Bhushan Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114428/#review63431
---


Ping, whats status on this? can this be submitted?

- Bhushan Shah


On Dec. 13, 2013, 8:35 p.m., Heena Mahour wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/114428/
 ---
 
 (Updated Dec. 13, 2013, 8:35 p.m.)
 
 
 Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith 
 Haridasan.
 
 
 Repository: plasma-mediacenter
 
 
 Description
 ---
 
 Replaced Text {} by PlasmaComponents.Label {} 
 
 
 Diffs
 -
 
   mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 
   mediaelements/mediawelcome/HomeScreenText.qml 35cd20a 
 
 Diff: https://git.reviewboard.kde.org/r/114428/diff/
 
 
 Testing
 ---
 
 works fine .
 
 
 Thanks,
 
 Heena Mahour
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Shantanu Tushar 


 On Dec. 13, 2013, 7:53 a.m., Sujith Haridasan wrote:
  mediaelements/mediawelcome/HomeScreenFooter.qml, line 42
  http://git.reviewboard.kde.org/r/114428/diff/2/?file=224654#file224654line42
 
  The PMC time doesn't get synced with desktop time. Can you tune this 
  further to get it synced?

Also, this is the matter of #114429 . This review should only be about Text - 
Label. Heena can you update the diff?


- Shantanu


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/#review45627
---


On Dec. 13, 2013, 7:24 a.m., Heena Mahour wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/114428/
 ---
 
 (Updated Dec. 13, 2013, 7:24 a.m.)
 
 
 Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith 
 Haridasan.
 
 
 Repository: plasma-mediacenter
 
 
 Description
 ---
 
 Replaced Text {} by PlasmaComponents.Label {} 
 
 
 Diffs
 -
 
   mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 
   mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 
   mediaelements/mediawelcome/HomeScreenText.qml 35cd20a 
 
 Diff: http://git.reviewboard.kde.org/r/114428/diff/
 
 
 Testing
 ---
 
 works fine .
 
 
 Thanks,
 
 Heena Mahour
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Heena Mahour 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/
---

(Updated Dec. 13, 2013, 2:20 p.m.)


Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.


Repository: plasma-mediacenter


Description
---

Replaced Text {} by PlasmaComponents.Label {} 


Diffs (updated)
-

  mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 
  mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 
  mediaelements/mediawelcome/HomeScreenText.qml 35cd20a 

Diff: http://git.reviewboard.kde.org/r/114428/diff/


Testing
---

works fine .


Thanks,

Heena Mahour

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Heena Mahour 


 On Dec. 13, 2013, 7:53 a.m., Sujith Haridasan wrote:
 

Synced with desktop time now :-)


- Heena


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/#review45627
---


On Dec. 13, 2013, 2:20 p.m., Heena Mahour wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/114428/
 ---
 
 (Updated Dec. 13, 2013, 2:20 p.m.)
 
 
 Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith 
 Haridasan.
 
 
 Repository: plasma-mediacenter
 
 
 Description
 ---
 
 Replaced Text {} by PlasmaComponents.Label {} 
 
 
 Diffs
 -
 
   mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 
   mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 
   mediaelements/mediawelcome/HomeScreenText.qml 35cd20a 
 
 Diff: http://git.reviewboard.kde.org/r/114428/diff/
 
 
 Testing
 ---
 
 works fine .
 
 
 Thanks,
 
 Heena Mahour
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Shantanu Tushar 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/#review45662
---

Ship it!


Ship It!

- Shantanu Tushar


On Dec. 13, 2013, 3:05 p.m., Heena Mahour wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/114428/
 ---
 
 (Updated Dec. 13, 2013, 3:05 p.m.)
 
 
 Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith 
 Haridasan.
 
 
 Repository: plasma-mediacenter
 
 
 Description
 ---
 
 Replaced Text {} by PlasmaComponents.Label {} 
 
 
 Diffs
 -
 
   mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 
   mediaelements/mediawelcome/HomeScreenText.qml 35cd20a 
 
 Diff: http://git.reviewboard.kde.org/r/114428/diff/
 
 
 Testing
 ---
 
 works fine .
 
 
 Thanks,
 
 Heena Mahour
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-12 Thread Heena Mahour 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/
---

Review request for Plasma.


Repository: plasma-mediacenter


Description
---

Replaced Text {} by PlasmaComponents.Label {} 


Diffs
-

  mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 
  mediaelements/mediawelcome/CategoriesListDelegate.qml f011bae 
  mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 
  mediaelements/mediawelcome/HomeScreenText.qml 35cd20a 

Diff: http://git.reviewboard.kde.org/r/114428/diff/


Testing
---

works fine .


Thanks,

Heena Mahour

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-12 Thread Heena Mahour 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/
---

(Updated Dec. 13, 2013, 7:09 a.m.)


Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.


Repository: plasma-mediacenter


Description
---

Replaced Text {} by PlasmaComponents.Label {} 


Diffs
-

  mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 
  mediaelements/mediawelcome/CategoriesListDelegate.qml f011bae 
  mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 
  mediaelements/mediawelcome/HomeScreenText.qml 35cd20a 

Diff: http://git.reviewboard.kde.org/r/114428/diff/


Testing
---

works fine .


Thanks,

Heena Mahour

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-12 Thread Heena Mahour 


 On Dec. 13, 2013, 7:10 a.m., Shantanu Tushar wrote:
  mediaelements/mediawelcome/HomeScreenText.qml, line 25
  http://git.reviewboard.kde.org/r/114428/diff/1/?file=224648#file224648line25
 
  Label should pick this up automatically, check if we can remove this.

yeah the color stays same if I remove it 


- Heena


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/#review45622
---


On Dec. 13, 2013, 7:09 a.m., Heena Mahour wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/114428/
 ---
 
 (Updated Dec. 13, 2013, 7:09 a.m.)
 
 
 Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith 
 Haridasan.
 
 
 Repository: plasma-mediacenter
 
 
 Description
 ---
 
 Replaced Text {} by PlasmaComponents.Label {} 
 
 
 Diffs
 -
 
   mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 
   mediaelements/mediawelcome/CategoriesListDelegate.qml f011bae 
   mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 
   mediaelements/mediawelcome/HomeScreenText.qml 35cd20a 
 
 Diff: http://git.reviewboard.kde.org/r/114428/diff/
 
 
 Testing
 ---
 
 works fine .
 
 
 Thanks,
 
 Heena Mahour
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-12 Thread Heena Mahour 


 On Dec. 13, 2013, 7:10 a.m., Shantanu Tushar wrote:
  mediaelements/mediawelcome/HomeScreenFooter.qml, line 54
  http://git.reviewboard.kde.org/r/114428/diff/1/?file=224647#file224647line54
 
  Please verify that. If it looks the same, then go ahead and remove.

Default size of Label is smaller than 20 So I did not changed it .


- Heena


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/#review45622
---


On Dec. 13, 2013, 7:24 a.m., Heena Mahour wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/114428/
 ---
 
 (Updated Dec. 13, 2013, 7:24 a.m.)
 
 
 Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith 
 Haridasan.
 
 
 Repository: plasma-mediacenter
 
 
 Description
 ---
 
 Replaced Text {} by PlasmaComponents.Label {} 
 
 
 Diffs
 -
 
   mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 
   mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 
   mediaelements/mediawelcome/HomeScreenText.qml 35cd20a 
 
 Diff: http://git.reviewboard.kde.org/r/114428/diff/
 
 
 Testing
 ---
 
 works fine .
 
 
 Thanks,
 
 Heena Mahour
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-12 Thread Sujith Haridasan 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/#review45627
---



mediaelements/mediawelcome/HomeScreenFooter.qml
http://git.reviewboard.kde.org/r/114428/#comment32577

The PMC time doesn't get synced with desktop time. Can you tune this 
further to get it synced?



mediaelements/mediawelcome/HomeScreenFooter.qml
http://git.reviewboard.kde.org/r/114428/#comment32576

Remove the white space


- Sujith Haridasan


On Dec. 13, 2013, 7:24 a.m., Heena Mahour wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/114428/
 ---
 
 (Updated Dec. 13, 2013, 7:24 a.m.)
 
 
 Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith 
 Haridasan.
 
 
 Repository: plasma-mediacenter
 
 
 Description
 ---
 
 Replaced Text {} by PlasmaComponents.Label {} 
 
 
 Diffs
 -
 
   mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 
   mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 
   mediaelements/mediawelcome/HomeScreenText.qml 35cd20a 
 
 Diff: http://git.reviewboard.kde.org/r/114428/diff/
 
 
 Testing
 ---
 
 works fine .
 
 
 Thanks,
 
 Heena Mahour
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel