Re: Review Request 114818: battery monitor renaming to org.kde.plasma.battery

Hi, Sorry about that, would moving everything in plasma/generic/applets/batterymonitor except CMakeLists.txt, and battery-oxygen(-inkscape).svgz to a new directory, and then calling plasma_install_package on the new directory work? Would that introduce any conflicts? Thanks, Danny On 1/3/14, Seb

Re: Review Request 114818: battery monitor renaming to org.kde.plasma.battery

Hello! On Fri, Jan 3, 2014 at 8:11 PM, Kai Uwe Broulik wrote: > Battery-oxygen isn't used anymore by the plasmoid anyway and can be removed Great, removing it! :) -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel

Re: Review Request 114818: battery monitor renaming to org.kde.plasma.battery

Hi, Battery-oxygen isn't used anymore by the plasmoid anyway and can be removed. Cheers, Kai Uwe ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114818: battery monitor renaming to org.kde.plasma.battery

[no need to CC: me, I'm on the plasma-list, not CC:ing me keeps my filtering and threading intact] On Friday, January 03, 2014 22:36:19 Unicode Snowman wrote: > Sorry about that, would moving everything in > plasma/generic/applets/batterymonitor except CMakeLists.txt, and > battery-oxygen(-inksca

Re: Review Request 114818: battery monitor renaming to org.kde.plasma.battery

Hello! On Fri, Jan 3, 2014 at 4:27 PM, Sebastian Kügler wrote: > The cmake logic here is not correct, two extraneous files are installed: > > > /home/sebas/kf5/install/share/plasma/plasmoids/org.kde.plasma.battery/battery- > oxygen.svgz > /home/sebas/kf5/install/share/plasma/plasmoids/org.kde.p

Re: Review Request 114818: battery monitor renaming to org.kde.plasma.battery

Hi Danny, On Friday, January 03, 2014 06:07:04 Danny Rim wrote: > https://git.reviewboard.kde.org/r/114818/ > This change has been marked as submitted. > > > Review request for Plasma and Bhushan Shah. > plasma/generic/applets/batterymonitor/metadata.desktop d84e25f > plasma/generic/applet

Re: Review Request 114818: battery monitor renaming to org.kde.plasma.battery

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114818/ --- (Updated Jan. 3, 2014, 6:07 a.m.) Status -- This change has been mar

Re: Review Request 114818: battery monitor renaming to org.kde.plasma.battery

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114818/#review46655 --- This review has been submitted with commit 476c5b9e2a931aad9b

Re: Review Request 114818: battery monitor renaming to org.kde.plasma.battery

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114818/#review46654 --- Ship it! Ship It! - Bhushan Shah On Jan. 3, 2014, 11:27 a.

Re: Review Request 114818: battery monitor renaming to org.kde.plasma.battery

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114818/ --- (Updated Jan. 3, 2014, 5:57 a.m.) Review request for Plasma and Bhushan S

Re: Review Request 114818: battery monitor renaming to org.kde.plasma.battery

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114818/ --- (Updated Jan. 3, 2014, 5:48 a.m.) Review request for Plasma and Bhushan S

Re: Review Request 114818: battery monitor renaming to org.kde.plasma.battery

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114818/#review46652 --- plasma/generic/applets/CMakeLists.txt

Re: Review Request 114818: battery monitor renaming to org.kde.plasma.battery

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114818/ --- (Updated Jan. 3, 2014, 5:39 a.m.) Review request for Plasma and Bhushan S