Re: Review Request 116460: Footer clock fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116460/ --- (Updated July 29, 2014, 12:10 p.m.) Status -- This change has been discarded. Review request for Plasma, R.Harish Navnit, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- The footer clock in PMC is set to 12Hr format and it was showing 0:00 AM instead of 12:00 AM Diffs - mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 Diff: https://git.reviewboard.kde.org/r/116460/diff/ Testing --- I've tested the diff and its working correctly Thanks, Maulik Kotadia ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116460: Footer clock fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116460/#review60664 --- This review request should be marked as discarded now. Thanks :) - R.Harish Navnit On Feb. 27, 2014, 9:12 p.m., Maulik Kotadia wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116460/ --- (Updated Feb. 27, 2014, 9:12 p.m.) Review request for Plasma, R.Harish Navnit, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- The footer clock in PMC is set to 12Hr format and it was showing 0:00 AM instead of 12:00 AM Diffs - mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 Diff: https://git.reviewboard.kde.org/r/116460/diff/ Testing --- I've tested the diff and its working correctly Thanks, Maulik Kotadia ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116460: Footer clock fix
Hey, On Fri, Feb 28, 2014 at 7:04 PM, Maulik Kotadia maulikkota...@gmail.comwrote: Hi, First of all apologies for the mistakes . I've started contributing to KDE very recently and it was my first patch. I'll keep this thing in mind in future. - Thanks Regards However its easy fix.. just remove timer code and set text property of the headerTimeText to relevant Qt.formatDateTime call. Regards! -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116460: Footer clock fix
Hi Maulik, Let me try to elaborate what's being mentioned here, just in case things weren't clear( I had to discuss the issue with sebas later on in the IRC to really get a grip of what was going here). On Fri, Feb 28, 2014 at 6:41 PM, Sebastian Kügler se...@kde.org wrote: This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116460/ This fix is wrong, it's merely trying to handle a symptom. The root cause of this erratic behavior is that we're making up our own time formatting code. The time format in the place where you and I live(assuming India) is in AM/PM, but is not necessarily the same elsewhere. I too had sent(as sebas mentioned) the a patch not considering the differing time formats in different locations. That has to be taken care of :) The right approach would entail: - Getting the right timezone (The time dataengine knows it) - Using a correct timeformatting function, such as Qt.formatDateTime or one in the org.kde.klocale import (as Bhushan notes) There is already a review request for this, you've probably seen it as you've CC:ed the author of that patch. You should, however, also have read the comments, as this solution is the exact same as in that patch. I'm not sure what's going on here, but you should try not to step on each others toes. Thanks for mentioning that :) I'm also working on the fix for the same issue :P Cheers Thanking You, R.Harish Navnit The Enigma http://harishnavnit.wordpress.com/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116460: Footer clock fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116460/ --- Review request for Plasma, R.Harish Navnit, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- The footer clock in PMC is set to 12Hr format and it was showing 0:00 AM instead of 12:00 AM Diffs - mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 Diff: https://git.reviewboard.kde.org/r/116460/diff/ Testing --- I've tested the diff and its working correctly Thanks, Maulik Kotadia ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116460: Footer clock fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116460/#review51289 --- However I am not sure why we have formatting logic in the application? Can't we use Qt.formatDateTime or others? @Shaan7 ? mediaelements/mediawelcome/HomeScreenFooter.qml https://git.reviewboard.kde.org/r/116460/#comment36121 Remove White space here and at other parts. For future if you are using Kate, Set Settings Configure Kate Open/Save Remove trailing spaces to on modified lines. - Bhushan Shah On Feb. 28, 2014, 2:42 a.m., Maulik Kotadia wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116460/ --- (Updated Feb. 28, 2014, 2:42 a.m.) Review request for Plasma, R.Harish Navnit, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- The footer clock in PMC is set to 12Hr format and it was showing 0:00 AM instead of 12:00 AM Diffs - mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 Diff: https://git.reviewboard.kde.org/r/116460/diff/ Testing --- I've tested the diff and its working correctly Thanks, Maulik Kotadia ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
