---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117813/
---
(Updated May 6, 2014, 11:03 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117813/#review57400
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117813/#review57296
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117813/#review57097
---
what's the status of this?
- Marco Martin
On April 27,
On May 2, 2014, 8:39 a.m., Marco Martin wrote:
what's the status of this?
I have a crash when combined with Martin's new notifications.
Fixing first.
- David
---
This is an automatically generated e-mail. To reply, visit:
On May 2, 2014, 10:39 a.m., Marco Martin wrote:
what's the status of this?
David Edmundson wrote:
I have a crash when combined with Martin's new notifications.
Fixing first.
Speaking of which https://git.reviewboard.kde.org/r/117903/ ;)
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117813/
---
(Updated May 2, 2014, 4:10 p.m.)
Review request for Plasma.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117813/#review56718
---
All in all, looks like a good improvement to me.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117813/#review56714
---
Overall +1 from me
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117813/#review56721
---
very good direction, just a couple of minor issues
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117813/#review56719
---
I like muchos. Haven't tested it yet, as I'm still
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117813/#review56724
---
applets/systemtray/plugin/host.cpp
On April 28, 2014, 11:06 a.m., Mark Gaiser wrote:
applets/systemtray/plugin/tasklistmodel.cpp, line 103
https://git.reviewboard.kde.org/r/117813/diff/1/?file=268854#file268854line103
Remove, the model will notify QML. No need to do this yourself.
I have it as a property, so I need
On April 28, 2014, 11:06 a.m., Mark Gaiser wrote:
applets/systemtray/plugin/host.cpp, line 120
https://git.reviewboard.kde.org/r/117813/diff/1/?file=268851#file268851line120
just init(); ?
I don't see a reason why you need a single shot timer here.
this causes the tasks to be
On April 28, 2014, 11:06 a.m., Mark Gaiser wrote:
applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp, lines 61-63
https://git.reviewboard.kde.org/r/117813/diff/1/?file=268852#file268852line61
Ahh, this is tricky to follow. You are invoking the init function here
_and_
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117813/
---
Review request for Plasma.
Repository: plasma-workspace
Description
16 matches
Mail list logo
