Re: Review Request 117903: Make notifications plasmoid reuse only 3 Dialogs instead of creating new one for each notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117903/#review57118 --- Ship it! to me looks fine. have to trust you you tested it

Re: Review Request 117903: Make notifications plasmoid reuse only 3 Dialogs instead of creating new one for each notification

On May 2, 2014, 2:12 p.m., David Edmundson wrote: applets/notifications/package/contents/ui/Notifications.qml, line 41 https://git.reviewboard.kde.org/r/117903/diff/1/?file=270229#file270229line41 personally I would have parsed the QQmlComponent object to cpp then done the create

Re: Review Request 117903: Make notifications plasmoid reuse only 3 Dialogs instead of creating new one for each notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117903/ --- (Updated May 2, 2014, 2:40 p.m.) Review request for Plasma. Changes

Re: Review Request 117903: Make notifications plasmoid reuse only 3 Dialogs instead of creating new one for each notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117903/#review57145 --- This review has been submitted with commit

Re: Review Request 117903: Make notifications plasmoid reuse only 3 Dialogs instead of creating new one for each notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117903/ --- (Updated May 2, 2014, 3:44 p.m.) Status -- This change has been

Review Request 117903: Make notifications plasmoid reuse only 3 Dialogs instead of creating new one for each notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117903/ --- Review request for Plasma. Repository: plasma-workspace Description