Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-28 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117954/ --- (Updated May 28, 2014, 8:55 a.m.) Status -- This change has been

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-27 Thread David Faure
On May 20, 2014, 3:08 p.m., Alexander Potashev wrote: You probably need to check in CMakeLists.txt that version of shared-mime-info is at least 0.40. Aurélien Gâteau wrote: shared-mime-info is only required at run time so I am not sure it makes sense to check at build time.

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117954/#review58611 --- Ship it! keditfiletype/mimetypedata.h

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-23 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117954/ --- (Updated May 23, 2014, 10:45 a.m.) Review request for Plasma and David

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-23 Thread Aurélien Gâteau
On May 20, 2014, 5:08 p.m., Alexander Potashev wrote: You probably need to check in CMakeLists.txt that version of shared-mime-info is at least 0.40. Aurélien Gâteau wrote: shared-mime-info is only required at run time so I am not sure it makes sense to check at build time.

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-22 Thread Aurélien Gâteau
On May 20, 2014, 5:08 p.m., Alexander Potashev wrote: You probably need to check in CMakeLists.txt that version of shared-mime-info is at least 0.40. shared-mime-info is only required at run time so I am not sure it makes sense to check at build time. Furthermore, 0.40 was released in

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-22 Thread Alexander Potashev
On May 20, 2014, 3:08 p.m., Alexander Potashev wrote: You probably need to check in CMakeLists.txt that version of shared-mime-info is at least 0.40. Aurélien Gâteau wrote: shared-mime-info is only required at run time so I am not sure it makes sense to check at build time.

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-20 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117954/ --- (Updated May 20, 2014, 4:56 p.m.) Review request for Plasma. Changes

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-20 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117954/#review58199 --- You probably need to check in CMakeLists.txt that version of

Review Request 117954: Port keditfiletype away from kde4support

2014-05-02 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117954/ --- Review request for Plasma. Repository: kde-cli-tools Description