Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/ --- Review request for Plasma, John Layt and Sebastian Kügler. Repository:

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/ --- (Updated June 6, 2014, 6:45 a.m.) Review request for Plasma, John Layt

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/#review59397 --- Ship it! Ship It! - Lukáš Tinkl On June 6, 2014, 8:45

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/#review59407 --- I'd like to hear John's take on this. IIRC, bcp47Name() is

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Luca Beltrame
On June 6, 2014, 10:53 a.m., Sebastian Kügler wrote: I'd like to hear John's take on this. IIRC, bcp47Name() is the correct one to use here. (Which leaves questions indeed.) Indeed. But for some reason, at least on my system, bcp47Name() returns it only, and that breaks everything. Hence

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread John Layt
On June 6, 2014, 11:53 a.m., Sebastian Kügler wrote: I'd like to hear John's take on this. IIRC, bcp47Name() is the correct one to use here. (Which leaves questions indeed.) Luca Beltrame wrote: Indeed. But for some reason, at least on my system, bcp47Name() returns it only, and

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Luca Beltrame
In data venerdì 6 giugno 2014 13:14:56, John Layt ha scritto: and script values for Italian and so are unneeded. This compares to name() which will always return the form language_COUNTRY regardless of the locale So do you think it's best to wait, or is this patch an unacceptable /

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread John Layt
On June 6, 2014, 11:53 a.m., Sebastian Kügler wrote: I'd like to hear John's take on this. IIRC, bcp47Name() is the correct one to use here. (Which leaves questions indeed.) Luca Beltrame wrote: Indeed. But for some reason, at least on my system, bcp47Name() returns it only, and

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/#review59477 --- Ship it! Ship It! - Sebastian Kügler On June 6, 2014,

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/#review59478 --- This review has been submitted with commit

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/ --- (Updated June 6, 2014, 9:43 p.m.) Status -- This change has been