Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

2014-06-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118630/#review59659 --- Ship it! Wait for the Qt patch if relevant - David

Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

2014-06-10 Thread Sebastian Kügler
On June 10, 2014, 10:34 a.m., David Edmundson wrote: Wait for the Qt patch if relevant It doesn't break any more without the Qt patch, so I'd rather ship this, and have it automatically fixed once Qt is updated. - Sebastian ---

Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

2014-06-10 Thread David Edmundson
On June 10, 2014, 10:34 a.m., David Edmundson wrote: Wait for the Qt patch if relevant Sebastian Kügler wrote: It doesn't break any more without the Qt patch, so I'd rather ship this, and have it automatically fixed once Qt is updated. My concern is that the Qt patch doesn't look

Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

2014-06-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118630/#review59697 --- This review has been submitted with commit

Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

2014-06-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118630/ --- (Updated June 10, 2014, 2:32 p.m.) Status -- This change has been

Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

2014-06-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118630/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative