Re: Review Request 118668: Split the startDate property into today and displayedDate in calendar component

2014-06-17 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118668/ --- (Updated June 17, 2014, 8:44 a.m.) Status -- This change has been

Re: Review Request 118668: Split the startDate property into today and displayedDate in calendar component

2014-06-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118668/#review60224 --- This review has been submitted with commit

Re: Review Request 118668: Split the startDate property into today and displayedDate in calendar component

2014-06-17 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118668/#review60307 --- No comments on most of the code change since that looks OK to

Re: Review Request 118668: Split the startDate property into today and displayedDate in calendar component

2014-06-17 Thread Martin Klapetek
On June 17, 2014, 8:16 p.m., Mark Gaiser wrote: No comments on most of the code change since that looks OK to me :) Besides setToday. Just a friendly explanation why i did it this way and why i (back then) thought it would be sufficient. I knew there was going to be a usecase

Re: Review Request 118668: Split the startDate property into today and displayedDate in calendar component

2014-06-17 Thread Mark Gaiser
On June 17, 2014, 6:16 p.m., Mark Gaiser wrote: No comments on most of the code change since that looks OK to me :) Besides setToday. Just a friendly explanation why i did it this way and why i (back then) thought it would be sufficient. I knew there was going to be a usecase

Re: Review Request 118668: Split the startDate property into today and displayedDate in calendar component

2014-06-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118668/#review60155 --- Ship it! Nice improvement.

Review Request 118668: Split the startDate property into today and displayedDate in calendar component

2014-06-11 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118668/ --- Review request for Plasma. Repository: plasma-framework Description