Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-18 Thread David Edmundson
On Aug. 14, 2014, 4:58 p.m., David Edmundson wrote: applets/fuzzy-clock/package/contents/ui/FuzzyClock.qml, line 118 https://git.reviewboard.kde.org/r/119738/diff/1/?file=304020#file304020line118 we don't need the i18n here, we'd be trying to translate an already translated

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119738/ --- (Updated Aug. 18, 2014, 5:18 nachm.) Review request for Plasma.

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-18 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119738/#review64785 --- Ship it! Good to me. - David Edmundson On Aug. 18, 2014,

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119738/ --- (Updated Aug. 18, 2014, 5:34 p.m.) Status -- This change has been

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-14 Thread Kai Uwe Broulik
On Aug. 14, 2014, 4:58 nachm., David Edmundson wrote: File Attachment: Configuration UI - fuzzyconfig.png https://git.reviewboard.kde.org/r/119738/#fcomment248 should this have steps on it? Yes. It has fuzzyness from 1 to 4. On Aug. 14, 2014, 4:58 nachm., David Edmundson wrote:

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-14 Thread Kai Uwe Broulik
On Aug. 14, 2014, 4:58 nachm., David Edmundson wrote: applets/fuzzy-clock/package/contents/ui/FuzzyClock.qml, line 118 https://git.reviewboard.kde.org/r/119738/diff/1/?file=304020#file304020line118 we don't need the i18n here, we'd be trying to translate an already translated

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-14 Thread Marco Martin
On Aug. 14, 2014, 4:58 p.m., David Edmundson wrote: applets/fuzzy-clock/package/contents/ui/FuzzyClock.qml, line 118 https://git.reviewboard.kde.org/r/119738/diff/1/?file=304020#file304020line118 we don't need the i18n here, we'd be trying to translate an already translated

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-14 Thread Kai Uwe Broulik
On Aug. 14, 2014, 4:58 nachm., David Edmundson wrote: applets/fuzzy-clock/package/contents/ui/FuzzyClock.qml, line 118 https://git.reviewboard.kde.org/r/119738/diff/1/?file=304020#file304020line118 we don't need the i18n here, we'd be trying to translate an already translated

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-14 Thread Lasse Liehu
On elo 14, 2014, 4:58 ip, David Edmundson wrote: applets/fuzzy-clock/package/contents/ui/FuzzyClock.qml, line 118 https://git.reviewboard.kde.org/r/119738/diff/1/?file=304020#file304020line118 we don't need the i18n here, we'd be trying to translate an already translated string.

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-14 Thread Kai Uwe Broulik
On Aug. 14, 2014, 4:58 nachm., David Edmundson wrote: applets/fuzzy-clock/package/contents/ui/FuzzyClock.qml, line 118 https://git.reviewboard.kde.org/r/119738/diff/1/?file=304020#file304020line118 we don't need the i18n here, we'd be trying to translate an already translated

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-14 Thread David Edmundson
On Aug. 14, 2014, 4:58 p.m., David Edmundson wrote: applets/fuzzy-clock/package/contents/ui/FuzzyClock.qml, line 118 https://git.reviewboard.kde.org/r/119738/diff/1/?file=304020#file304020line118 we don't need the i18n here, we'd be trying to translate an already translated

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-14 Thread Lasse Liehu
On elo 14, 2014, 4:58 ip, David Edmundson wrote: applets/fuzzy-clock/package/contents/ui/FuzzyClock.qml, line 118 https://git.reviewboard.kde.org/r/119738/diff/1/?file=304020#file304020line118 we don't need the i18n here, we'd be trying to translate an already translated string.

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-14 Thread David Edmundson
On Aug. 14, 2014, 4:58 p.m., David Edmundson wrote: applets/fuzzy-clock/package/contents/ui/FuzzyClock.qml, line 118 https://git.reviewboard.kde.org/r/119738/diff/1/?file=304020#file304020line118 we don't need the i18n here, we'd be trying to translate an already translated

Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-12 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119738/ --- Review request for Plasma. Repository: kdeplasma-addons Description