Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-03 Thread Martin Klapetek
On Oct. 2, 2014, 4:04 p.m., Kai Uwe Broulik wrote: applets/digital-clock/package/contents/ui/DigitalClock.qml, line 231 https://git.reviewboard.kde.org/r/120461/diff/1/?file=316057#file316057line231 Is this needed? Martin Klapetek wrote: For tooltip? Otherwise I don't think

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/ --- (Updated Oct. 3, 2014, 9:41 a.m.) Status -- This change has been

Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/ --- (Updated Oct. 2, 2014, 3:27 p.m.) Review request for Plasma. Changes

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/#review67810 --- Ship it! I tried it a bit, it seems to work fine - Marco

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/#review67811 --- Ship it! Nice work!

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/#review67812 --- File Attachment: Variants in vertical panel -

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/#review67813 --- Ship it! Ship It! - Kai Uwe Broulik On Okt. 2, 2014, 1:27

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Martin Klapetek
On Oct. 2, 2014, 3:57 p.m., Sebastian Kügler wrote: applets/digital-clock/package/contents/ui/DigitalClock.qml, line 216 https://git.reviewboard.kde.org/r/120461/diff/1/?file=316057#file316057line216 There may be a corner case here, when the formfactor changes to Planar or

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Martin Klapetek
On Oct. 2, 2014, 4:04 p.m., Kai Uwe Broulik wrote: File Attachment: Variants in vertical panel - digital-clock2.png https://git.reviewboard.kde.org/r/120461/#fcomment271 Is it the panel which makes it not look horizontally centered? I think so, the vertical variant has

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/ --- (Updated Oct. 2, 2014, 5:05 p.m.) Review request for Plasma. Changes