Re: Review Request 122209: [plasma-workspace] Make tests optional
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122209/#review102449 --- If this diff is still appropriate please reopen on http://phabricator.kde.org - David Edmundson On March 16, 2015, 11:18 p.m., Andreas Sturmlechner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122209/ > --- > > (Updated March 16, 2015, 11:18 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > Qt5Test should not be mandatory. > > > Diffs > - > > CMakeLists.txt 907c00836531db511a91860993a54acd89720055 > ksmserver/CMakeLists.txt c0543e29904b663b3600832e5e8855b3927ee3ce > ksmserver/screenlocker/greeter/CMakeLists.txt > d502cb82516e85a76685d7e3d7106a41dcf0cfff > > Diff: https://git.reviewboard.kde.org/r/122209/diff/ > > > Testing > --- > > Built with (all successful) and without tests. > > > Thanks, > > Andreas Sturmlechner > >
Re: Review Request 122209: [plasma-workspace] Make tests optional
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122209/ --- (Updated Feb. 8, 2017, noon) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-workspace Description --- Qt5Test should not be mandatory. Diffs - CMakeLists.txt 907c00836531db511a91860993a54acd89720055 ksmserver/CMakeLists.txt c0543e29904b663b3600832e5e8855b3927ee3ce ksmserver/screenlocker/greeter/CMakeLists.txt d502cb82516e85a76685d7e3d7106a41dcf0cfff Diff: https://git.reviewboard.kde.org/r/122209/diff/ Testing --- Built with (all successful) and without tests. Thanks, Andreas Sturmlechner
Re: Review Request 122209: [plasma-workspace] Make tests optional
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122209/#review77607 --- ksmserver/CMakeLists.txt https://git.reviewboard.kde.org/r/122209/#comment53298 AFAIU the if is not needed. The tests should be marked with ecm_mark_as_test which will not build them if BUILD_TESTING is disabled. - Martin Gräßlin On March 17, 2015, 12:18 a.m., Andreas Sturmlechner wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122209/ --- (Updated March 17, 2015, 12:18 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- Qt5Test should not be mandatory. Diffs - CMakeLists.txt 907c00836531db511a91860993a54acd89720055 ksmserver/CMakeLists.txt c0543e29904b663b3600832e5e8855b3927ee3ce ksmserver/screenlocker/greeter/CMakeLists.txt d502cb82516e85a76685d7e3d7106a41dcf0cfff Diff: https://git.reviewboard.kde.org/r/122209/diff/ Testing --- Built with (all successful) and without tests. Thanks, Andreas Sturmlechner ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122209: [plasma-workspace] Make tests optional
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122209/ --- (Updated March 16, 2015, 11:18 p.m.) Review request for Plasma. Changes --- So, this needed an update, and I wanted it to do like in kwin after the discussion in https://git.reviewboard.kde.org/r/122206/ Repository: plasma-workspace Description (updated) --- Qt5Test should not be mandatory. Diffs (updated) - CMakeLists.txt 907c00836531db511a91860993a54acd89720055 ksmserver/CMakeLists.txt c0543e29904b663b3600832e5e8855b3927ee3ce ksmserver/screenlocker/greeter/CMakeLists.txt d502cb82516e85a76685d7e3d7106a41dcf0cfff Diff: https://git.reviewboard.kde.org/r/122209/diff/ Testing (updated) --- Built with (all successful) and without tests. Thanks, Andreas Sturmlechner ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122209: [plasma-workspace] Make tests optional
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122209/#review74914 --- Ship it! Ship It! - David Edmundson On Jan. 22, 2015, 9:43 p.m., Andreas Sturmlechner wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122209/ --- (Updated Jan. 22, 2015, 9:43 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Qt5Test should not be mandatory. The patch moves find_package(Qt5Test...) out of CMakeLists.txt and adds drkonqi/internalkxmlrpcclient/autotests only if(BUILD_TESTING). I do not have write access. Diffs - CMakeLists.txt e4d2b2dcf25ce7892f63c0279cea99329ec4b5f4 drkonqi/internalkxmlrpcclient/CMakeLists.txt 276aeaaa0b058fa38d44dd52bd5b93f2b839d6f8 Diff: https://git.reviewboard.kde.org/r/122209/diff/ Testing --- Thanks, Andreas Sturmlechner ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122209: [plasma-workspace] Make tests optional
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122209/ --- (Updated Jan. 22, 2015, 9:43 p.m.) Review request for Plasma. Repository: plasma-workspace Description (updated) --- Qt5Test should not be mandatory. The patch moves find_package(Qt5Test...) out of CMakeLists.txt and adds drkonqi/internalkxmlrpcclient/autotests only if(BUILD_TESTING). I do not have write access. Diffs - CMakeLists.txt e4d2b2dcf25ce7892f63c0279cea99329ec4b5f4 drkonqi/internalkxmlrpcclient/CMakeLists.txt 276aeaaa0b058fa38d44dd52bd5b93f2b839d6f8 Diff: https://git.reviewboard.kde.org/r/122209/diff/ Testing --- Thanks, Andreas Sturmlechner ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
