On März 30, 2015, 6:02 vorm., Martin Gräßlin wrote:
effects/CMakeLists.txt, line 133
https://git.reviewboard.kde.org/r/122679/diff/2/?file=357029#file357029line133
the name looks a little bit mhhh ;-)
Thomas Lübking wrote:
When thinking about a name that does not sound like
On März 30, 2015, 6:02 vorm., Martin Gräßlin wrote:
effects/CMakeLists.txt, line 133
https://git.reviewboard.kde.org/r/122679/diff/2/?file=357029#file357029line133
the name looks a little bit mhhh ;-)
Thomas Lübking wrote:
When thinking about a name that does not sound like
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/
---
(Updated April 7, 2015, 10:30 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/
---
(Updated April 4, 2015, 3:28 nachm.)
Review request for kwin, Plasma,
On March 22, 2015, 8:28 p.m., Kai Uwe Broulik wrote:
Sorry for being late to the party:
UX issues I have with that implementation:
- No transition, the windows just disappear (would be cool to have them
slide out of the screen or have them stay at the edges of the screen like
OSX
On März 22, 2015, 8:28 nachm., Kai Uwe Broulik wrote:
Sorry for being late to the party:
UX issues I have with that implementation:
- No transition, the windows just disappear (would be cool to have them
slide out of the screen or have them stay at the edges of the screen like
On März 30, 2015, 9:13 nachm., Kai Uwe Broulik wrote:
Really nice, I love the badbadwindows effect!
Is it intended that the windows stay subtly visible a centimeter at the
corner of the screen? Imho they should be either completely hidden or stick
out further, and less transparent,
On März 22, 2015, 8:28 nachm., Kai Uwe Broulik wrote:
Sorry for being late to the party:
UX issues I have with that implementation:
- No transition, the windows just disappear (would be cool to have them
slide out of the screen or have them stay at the edges of the screen like
On März 30, 2015, 6:02 vorm., Martin Gräßlin wrote:
Can we be sure that the change reguarding AnimationData in the
ScriptedEffects doesn't break the existing effects?
See scriptedeffect.cpp lines 251, 280.
The AnimationData pointer was hardcoded to nullptr, metaFromData thus NOOP.
There
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review78192
---
Can we be sure that the change reguarding AnimationData in
On March 30, 2015, 8:02 a.m., Martin Gräßlin wrote:
effects/CMakeLists.txt, line 133
https://git.reviewboard.kde.org/r/122679/diff/2/?file=357029#file357029line133
the name looks a little bit mhhh ;-)
Thomas Lübking wrote:
When thinking about a name that does not sound like
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review78200
---
effects/badbadwindows/package/contents/code/main.js (line 5)
On März 30, 2015, 7:55 vorm., Martin Gräßlin wrote:
effects/badbadwindows/package/contents/code/main.js, line 5
https://git.reviewboard.kde.org/r/122679/diff/2/?file=357032#file357032line5
isn't it yours?
Yes, had seen that (and fixed it, but didn't finish the eye On Screen patch
On März 30, 2015, 6:02 vorm., Martin Gräßlin wrote:
effects/CMakeLists.txt, line 133
https://git.reviewboard.kde.org/r/122679/diff/2/?file=357029#file357029line133
the name looks a little bit mhhh ;-)
Thomas Lübking wrote:
When thinking about a name that does not sound like
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review78245
---
Was adding the usability group more meant as a heads-up to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/
---
(Updated März 30, 2015, 9:06 nachm.)
Review request for kwin, Plasma,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review78252
---
Really nice, I love the badbadwindows effect!
Is it intended
On März 30, 2015, 7:12 nachm., Thomas Pfeiffer wrote:
Was adding the usability group more meant as a heads-up to inform us that
things are happening on this front, or are you expecting an actual
usability review?
In the latter case, we'd need some kind of visualization or at least
On March 22, 2015, 8:28 p.m., Kai Uwe Broulik wrote:
Sorry for being late to the party:
UX issues I have with that implementation:
- No transition, the windows just disappear (would be cool to have them
slide out of the screen or have them stay at the edges of the screen like
OSX
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/
---
(Updated März 28, 2015, 11:24 nachm.)
Review request for kwin, Plasma,
On March 22, 2015, 8:28 p.m., Kai Uwe Broulik wrote:
Sorry for being late to the party:
UX issues I have with that implementation:
- No transition, the windows just disappear (would be cool to have them
slide out of the screen or have them stay at the edges of the screen like
OSX
On März 20, 2015, 10:47 vorm., Martin Gräßlin wrote:
From my side I would like to see this in 5.3
Unless Marco, Kai or Usabilities have an imminent comment, I'd also propose to
push it tomorrow evening and run into functionality bug reports (why does it,
why does it not, ...) to get
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review77926
---
Sorry for being late to the party:
UX issues I have with
On März 22, 2015, 8:28 nachm., Kai Uwe Broulik wrote:
Sorry for being late to the party:
UX issues I have with that implementation:
- No transition, the windows just disappear (would be cool to have them
slide out of the screen or have them stay at the edges of the screen like
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review77816
---
Ship it!
From my side I would like to see this in 5.3
-
On Feb. 23, 2015, 8:25 vorm., Martin Gräßlin wrote:
effects/presentwindows/presentwindows.cpp, line 1418
https://git.reviewboard.kde.org/r/122679/diff/1/?file=350838#file350838line1418
Maybe: whenever a fullscreen effect is used disable showingDesktoP?
Thomas Lübking wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review76600
---
I like the idea, it would at least make the show desktop
On Feb. 25, 2015, 2:37 p.m., Marco Martin wrote:
I like the idea, it would at least make the show desktop function actually
usable.
this would/could replace the dashboard as well?
this would/could replace the dashboard as well?
Yes this should replace dashboard. It is kind of the same
On Feb. 25, 2015, 1:37 nachm., Marco Martin wrote:
I like the idea, it would at least make the show desktop function actually
usable.
this would/could replace the dashboard as well?
Martin Gräßlin wrote:
this would/could replace the dashboard as well?
Yes this should
On Feb. 23, 2015, 9:25 a.m., Martin Gräßlin wrote:
effects/presentwindows/presentwindows.cpp, line 1418
https://git.reviewboard.kde.org/r/122679/diff/1/?file=350838#file350838line1418
Maybe: whenever a fullscreen effect is used disable showingDesktoP?
Thomas Lübking wrote:
On Feb. 25, 2015, 1:37 nachm., Marco Martin wrote:
I like the idea, it would at least make the show desktop function actually
usable.
this would/could replace the dashboard as well?
Martin Gräßlin wrote:
this would/could replace the dashboard as well?
Yes this should
On Feb. 23, 2015, 8:25 vorm., Martin Gräßlin wrote:
effects/presentwindows/presentwindows.cpp, line 1418
https://git.reviewboard.kde.org/r/122679/diff/1/?file=350838#file350838line1418
Maybe: whenever a fullscreen effect is used disable showingDesktoP?
That would eg. also affect
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review76450
---
I like the approach and the red/green ratio :-)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review76428
---
layers.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/
---
Review request for kwin, Plasma, Martin Gräßlin, and Marco Martin.
Bugs:
35 matches
Mail list logo
