Re: Review Request 124589: Add Disk Quota Plasmoid

> On Oct. 23, 2015, 10:15 p.m., David Edmundson wrote: > > Bump? We have a "no huge merges freeze" on the 5th of November for 5.5 > > Dominik Haumann wrote: > Thanks for the bump, I will have some time next weekend, will go over the > reviews again and then push this if all is good. (Due

Re: Review Request 124589: Add Disk Quota Plasmoid

> On Oct. 23, 2015, 10:15 p.m., David Edmundson wrote: > > Bump? We have a "no huge merges freeze" on the 5th of November for 5.5 > > Dominik Haumann wrote: > Thanks for the bump, I will have some time next weekend, will go over the > reviews again and then push this if all is good. (Due

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/ --- (Updated Nov. 4, 2015, 1:51 p.m.) Status -- This change has been

Re: Review Request 124589: Add Disk Quota Plasmoid

> On Oct. 23, 2015, 10:15 p.m., David Edmundson wrote: > > Bump? We have a "no huge merges freeze" on the 5th of November for 5.5 > > Dominik Haumann wrote: > Thanks for the bump, I will have some time next weekend, will go over the > reviews again and then push this if all is good. (Due

Re: Review Request 124589: Add Disk Quota Plasmoid

> On Oct. 23, 2015, 10:15 p.m., David Edmundson wrote: > > Bump? We have a "no huge merges freeze" on the 5th of November for 5.5 Thanks for the bump, I will have some time next weekend, will go over the reviews again and then push this if all is good. (Due to moving, I have no internet right

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/#review84600 --- Bump? We have a "no huge merges freeze" on the 5th of

Re: Review Request 124589: Add Disk Quota Plasmoid

> On Aug. 6, 2015, 2:12 p.m., Lamarque Souza wrote: > > applets/diskquota/plugin/DiskQuota.cpp, line 158 > > > > > > You should search for quota and filelight programs during startup only. > > You can send a

Re: Review Request 124589: Add Disk Quota Plasmoid

On Aug. 6, 2015, 2:12 p.m., Lamarque Souza wrote: applets/diskquota/plugin/DiskQuota.cpp, line 158 https://git.reviewboard.kde.org/r/124589/diff/5/?file=389660#file389660line158 You should search for quota and filelight programs during startup only. You can send a notification if

Re: Review Request 124589: Add Disk Quota Plasmoid

On Aug. 6, 2015, 2:12 p.m., Lamarque Souza wrote: applets/diskquota/plugin/DiskQuota.cpp, line 158 https://git.reviewboard.kde.org/r/124589/diff/5/?file=389660#file389660line158 You should search for quota and filelight programs during startup only. You can send a notification if

Re: Review Request 124589: Add Disk Quota Plasmoid

On Aug. 6, 2015, 2:12 nachm., Lamarque Souza wrote: applets/diskquota/plugin/DiskQuota.cpp, line 158 https://git.reviewboard.kde.org/r/124589/diff/5/?file=389660#file389660line158 You should search for quota and filelight programs during startup only. You can send a notification

Re: Review Request 124589: Add Disk Quota Plasmoid

On Aug. 6, 2015, 2:12 p.m., Lamarque Souza wrote: applets/diskquota/plugin/DiskQuota.cpp, line 158 https://git.reviewboard.kde.org/r/124589/diff/5/?file=389660#file389660line158 You should search for quota and filelight programs during startup only. You can send a notification if

Re: Review Request 124589: Add Disk Quota Plasmoid

On Aug. 6, 2015, 2:12 p.m., Lamarque Souza wrote: applets/diskquota/plugin/DiskQuota.cpp, line 158 https://git.reviewboard.kde.org/r/124589/diff/5/?file=389660#file389660line158 You should search for quota and filelight programs during startup only. You can send a notification if

Re: Review Request 124589: Add Disk Quota Plasmoid

On Aug. 6, 2015, 2:12 p.m., Lamarque Souza wrote: applets/diskquota/plugin/DiskQuota.cpp, line 158 https://git.reviewboard.kde.org/r/124589/diff/5/?file=389660#file389660line158 You should search for quota and filelight programs during startup only. You can send a notification if

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/#review83498 --- applets/diskquota/plugin/DiskQuota.cpp (line 158)

Re: Review Request 124589: Add Disk Quota Plasmoid

On Aug. 2, 2015, 4:44 p.m., David Edmundson wrote: applets/diskquota/plugin/DiskQuota.cpp, line 289 https://git.reviewboard.kde.org/r/124589/diff/4/?file=389396#file389396line289 We need to be careful here Qt tries to be clever about who owns the model when loaded via

Re: Review Request 124589: Add Disk Quota Plasmoid

On Aug. 2, 2015, 4:44 p.m., David Edmundson wrote: applets/diskquota/plugin/DiskQuota.cpp, line 161 https://git.reviewboard.kde.org/r/124589/diff/4/?file=389396#file389396line161 do this in the constructor, only connect if it exists, and if it doesn't make sure to set the

Re: Review Request 124589: Add Disk Quota Plasmoid

On Aug. 2, 2015, 4:44 nachm., David Edmundson wrote: applets/diskquota/plugin/DiskQuota.cpp, line 161 https://git.reviewboard.kde.org/r/124589/diff/4/?file=389396#file389396line161 do this in the constructor, only connect if it exists, and if it doesn't make sure to set the

Re: Review Request 124589: Add Disk Quota Plasmoid

On Aug. 2, 2015, 4:44 p.m., David Edmundson wrote: applets/diskquota/plugin/DiskQuota.cpp, line 161 https://git.reviewboard.kde.org/r/124589/diff/4/?file=389396#file389396line161 do this in the constructor, only connect if it exists, and if it doesn't make sure to set the

Re: Review Request 124589: Add Disk Quota Plasmoid

On Aug. 2, 2015, 4:44 p.m., David Edmundson wrote: applets/diskquota/plugin/DiskQuota.cpp, line 161 https://git.reviewboard.kde.org/r/124589/diff/4/?file=389396#file389396line161 do this in the constructor, only connect if it exists, and if it doesn't make sure to set the

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/ --- (Updated Aug. 3, 2015, 5:34 p.m.) Review request for Plasma, Kai Uwe

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/ --- (Updated Aug. 2, 2015, 2:06 p.m.) Review request for Plasma, Kai Uwe

Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/ --- Review request for Plasma, Kai Uwe Broulik and Sebastian Kügler.

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/#review83345 --- Awesome! From a visual perspective two things, the line width

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/#review83335 --- +1 LGTM - Kai Uwe Broulik On Aug. 2, 2015, 2:06 nachm.,

Re: Review Request 124589: Add Disk Quota Plasmoid

On Aug. 2, 2015, 6:54 nachm., Jens Reuterberg wrote: Awesome! From a visual perspective two things, the line width of the icon when in systray is kinda off it seems in the screenshots (the line is thinner in the other icons, 1px I think) and the icon itself is too big taking over a

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/#review8 --- applets/diskquota/plugin/DiskQuota.cpp (line 161)

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/#review83320 --- applets/diskquota/plugin/DiskQuota.cpp (line 170)

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/ --- (Updated Aug. 2, 2015, 12:17 p.m.) Review request for Plasma, Kai Uwe

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/#review83321 --- Nice! :) Just being pedantic here, I've seen it work nicely

Re: Review Request 124589: Add Disk Quota Plasmoid

On Aug. 2, 2015, 12:38 p.m., Kai Uwe Broulik wrote: applets/diskquota/plugin/DiskQuota.h, lines 111-113 https://git.reviewboard.kde.org/r/124589/diff/2/?file=389327#file389327line111 You could initialize these directly in the header file. bool m_quotaInstalled = true

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/ --- (Updated Aug. 2, 2015, 1:59 p.m.) Review request for Plasma, Kai Uwe