Re: Review Request 125058: Cleanup and Add directories to index list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125058/ --- (Updated Sept. 8, 2015, 10:03 p.m.) Status -- This change has been

Re: Review Request 125058: Cleanup and Add directories to index list

> On Sept. 6, 2015, 5:22 a.m., Thomas Pfeiffer wrote: > > Have you thought of the corner cases? > > These come to my mind: > > - Is it possible to add the same folder to both lists? If so: Which one > > wins? > > - It ist possible to add a folder to index within an excluded folder? If > > so:

Re: Review Request 125058: Cleanup and Add directories to index list

> On Sept. 6, 2015, 2:22 a.m., Thomas Pfeiffer wrote: > > Have you thought of the corner cases? > > These come to my mind: > > - Is it possible to add the same folder to both lists? If so: Which one > > wins? > > - It ist possible to add a folder to index within an excluded folder? If > > so:

Re: Review Request 125058: Cleanup and Add directories to index list

> On Sept. 6, 2015, 2:22 a.m., Thomas Pfeiffer wrote: > > Have you thought of the corner cases? > > These come to my mind: > > - Is it possible to add the same folder to both lists? If so: Which one > > wins? > > - It ist possible to add a folder to index within an excluded folder? If > > so:

Review Request 125058: Cleanup and Add directories to index list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125058/ --- Review request for Baloo, Plasma, Pinak Ahuja, and Vishesh Handa.

Re: Review Request 125058: Cleanup and Add directories to index list

> On Sept. 5, 2015, 12:12 p.m., Vishesh Handa wrote: > > Can you please attach some images of how the KCM now looks? > > Ovidiu-Florin BOGDAN wrote: > Should I make a new review request with each patch? Or a single one with > 3 diffs? A new review request per patch, please. - Vishesh

Re: Review Request 125058: Cleanup and Add directories to index list

> On Sept. 5, 2015, 12:12 p.m., Vishesh Handa wrote: > > kcms/baloo/configwidget.ui, line 43 > > > > > > Moving the checkBox from the top to bottom? Why? Also, if we want this > > it goes in a seperate patch. >

Re: Review Request 125058: Cleanup and Add directories to index list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125058/ --- (Updated Sept. 5, 2015, 10:53 p.m.) Review request for Baloo, Plasma,

Re: Review Request 125058: Cleanup and Add directories to index list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125058/ --- (Updated Sept. 5, 2015, 10:53 p.m.) Review request for Baloo, Plasma,

Re: Review Request 125058: Cleanup and Add directories to index list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125058/ --- (Updated Sept. 5, 2015, 11:11 p.m.) Review request for Baloo, Plasma,

Re: Review Request 125058: Cleanup and Add directories to index list

> On Sept. 5, 2015, 3:12 p.m., Vishesh Handa wrote: > > kcms/baloo/folderselectionwidget.cpp, line 306 > > > > > > Coding style. The { should not be on the next line. Please fix all > > instances of this. This

Re: Review Request 125058: Cleanup and Add directories to index list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125058/#review84879 --- Please add the usability group to review UI changes. - Luca

Re: Review Request 125058: Cleanup and Add directories to index list

> On Sept. 5, 2015, 8:49 p.m., Vishesh Handa wrote: > > kcms/baloo/folderselectionwidget.cpp, line 373 > > > > > > `QStringLiteral` > > Ovidiu-Florin BOGDAN wrote: > I didn't change that part. > >

Re: Review Request 125058: Cleanup and Add directories to index list

> On Sept. 5, 2015, 12:12 p.m., Vishesh Handa wrote: > > kcms/baloo/configwidget.ui, line 43 > > > > > > Moving the checkBox from the top to bottom? Why? Also, if we want this > > it goes in a seperate patch. >

Re: Review Request 125058: Cleanup and Add directories to index list

> On Sept. 5, 2015, 9:49 p.m., Vishesh Handa wrote: > > kcms/baloo/folderselectionwidget.cpp, line 373 > > > > > > `QStringLiteral` I didn't change that part. Why QStringLiteral instead of QLatin1String? -

Re: Review Request 125058: Cleanup and Add directories to index list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125058/#review84876 --- kcms/baloo/folderselectionwidget.cpp (line 273)

Re: Review Request 125058: Cleanup and Add directories to index list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125058/#review84861 --- Can you please attach some images of how the KCM now looks?

Re: Review Request 125058: Cleanup and Add directories to index list

> On Sept. 5, 2015, 3:12 p.m., Vishesh Handa wrote: > > kcms/baloo/configwidget.ui, line 43 > > > > > > Moving the checkBox from the top to bottom? Why? Also, if we want this > > it goes in a seperate patch. I

Re: Review Request 125058: Cleanup and Add directories to index list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125058/#review84886 --- Have you thought of the corner cases? These come to my mind:

Re: Review Request 125058: Cleanup and Add directories to index list

> On Sept. 5, 2015, 3:12 p.m., Vishesh Handa wrote: > > Can you please attach some images of how the KCM now looks? Should I make a new review request with each patch? Or a single one with 3 diffs? > On Sept. 5, 2015, 3:12 p.m., Vishesh Handa wrote: > > kcms/baloo/CMakeLists.txt, line 20 > >