Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available

2015-11-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125465/ --- (Updated Nov. 18, 2015, 10:03 p.m.) Status -- This change has been

Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available

2015-11-17 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125465/#review88464 --- If there are no objections, I will push this before beta

Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available

2015-11-05 Thread David Rosca
> On Oct. 1, 2015, 6:01 a.m., Martin Gräßlin wrote: > > Did you check KWin's udev helper classes? Instead of re-inventing the wheel > > it might be better to share the code in case it would be useful. It's in > > kwin.git/udev.h and udev.cpp > > David Rosca wrote: > I did now, it doesn't

Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available

2015-11-05 Thread Martin Gräßlin
> On Oct. 1, 2015, 8:01 a.m., Martin Gräßlin wrote: > > Did you check KWin's udev helper classes? Instead of re-inventing the wheel > > it might be better to share the code in case it would be useful. It's in > > kwin.git/udev.h and udev.cpp > > David Rosca wrote: > I did now, it doesn't

Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available

2015-10-01 Thread David Rosca
> On Oct. 1, 2015, 6:01 a.m., Martin Gräßlin wrote: > > Did you check KWin's udev helper classes? Instead of re-inventing the wheel > > it might be better to share the code in case it would be useful. It's in > > kwin.git/udev.h and udev.cpp > > David Rosca wrote: > I did now, it doesn't

Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available

2015-10-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125465/ --- (Updated Oct. 1, 2015, 8:05 a.m.) Review request for Plasma. Changes

Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available

2015-10-01 Thread David Rosca
> On Oct. 1, 2015, 6:01 a.m., Martin Gräßlin wrote: > > Did you check KWin's udev helper classes? Instead of re-inventing the wheel > > it might be better to share the code in case it would be useful. It's in > > kwin.git/udev.h and udev.cpp I did now, it doesn't seem to support device

Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available

2015-09-30 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125465/ --- Review request for Plasma. Bugs: 346336