Re: Review Request 125811: detect gtk engine

2015-11-04 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125811/ --- (Updated Nov. 4, 2015, 10:29 a.m.) Status -- This change has been

Re: Review Request 125811: detect gtk engine

2015-11-03 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125811/#review87948 --- cmake/FindGTKEngine.cmake (line 17)

Re: Review Request 125811: detect gtk engine

2015-11-03 Thread Alex Merry
> On Nov. 3, 2015, 5:38 p.m., Hrvoje Senjan wrote: > > cmake/FindGTKEngine.cmake, line 17 > > > > > > KDE_INSTALL_FULL_LIBDIR rather? Yes, that one, please. Otherwise bad things will happen if anyone specifies

Re: Review Request 125811: detect gtk engine

2015-11-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125811/#review87945 --- Ship it! Ship It! - David Edmundson On Oct. 27, 2015,

Re: Review Request 125811: detect gtk engine

2015-10-27 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125811/ --- (Updated Oct. 27, 2015, 9:22 a.m.) Review request for Plasma and David

Re: Review Request 125811: detect gtk engine

2015-10-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125811/#review87493 --- cmake/FindGTKEngine.cmake (line 17)

Re: Review Request 125811: detect gtk engine

2015-10-27 Thread David Edmundson
> On Oct. 27, 2015, 9:26 a.m., David Edmundson wrote: > > cmake/FindGTKEngine.cmake, line 17 > > > > > > what if I have 2.10.1 installed? > > Jonathan Riddell wrote: > No such bugfix ABI bumper were made and

Re: Review Request 125811: detect gtk engine

2015-10-27 Thread Jonathan Riddell
> On Oct. 27, 2015, 9:26 a.m., David Edmundson wrote: > > cmake/FindGTKEngine.cmake, line 17 > > > > > > what if I have 2.10.1 installed? No such bugfix ABI bumper were made and now GTK 3 is the development

Re: Review Request 125811: detect gtk engine

2015-10-27 Thread Jonathan Riddell
> On Oct. 27, 2015, 9:26 a.m., David Edmundson wrote: > > cmake/FindGTKEngine.cmake, line 17 > > > > > > what if I have 2.10.1 installed? > > Jonathan Riddell wrote: > No such bugfix ABI bumper were made and

Review Request 125811: detect gtk engine

2015-10-26 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125811/ --- Review request for Plasma and David Edmundson. Repository: breeze-gtk

Re: Review Request 125811: detect gtk engine

2015-10-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125811/#review87436 --- CMakeLists.txt (line 14)