Re: Review Request 126018: Use the plural form for "Notification" category

2015-11-18 Thread Martin Klapetek
> On Nov. 10, 2015, 10:57 p.m., Martin Klapetek wrote: > > > should I change also X-KDE-System-Settings-Category=notification to > > > notifications > > > > I don't think so, it would require changing everywhere. Unless there is > > nothing actually using it, in which case, yes. > > Luigi

Re: Review Request 126018: Use the plural form for "Notification" category

2015-11-16 Thread Luigi Toscano
> On Nov. 10, 2015, 10:57 p.m., Martin Klapetek wrote: > > > should I change also X-KDE-System-Settings-Category=notification to > > > notifications > > > > I don't think so, it would require changing everywhere. Unless there is > > nothing actually using it, in which case, yes. Where should

Re: Review Request 126018: Use the plural form for "Notification" category

2015-11-16 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126018/ --- (Updated Nov. 16, 2015, 11:51 p.m.) Status -- This change has been

Review Request 126018: Use the plural form for "Notification" category

2015-11-10 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126018/ --- Review request for Plasma. Repository: systemsettings Description

Re: Review Request 126018: Use the plural form for "Notification" category

2015-11-10 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126018/#review88227 --- Ship it! > should I change also