Re: Review Request 126101: allow loading backends in-process

> On Nov. 20, 2015, 10:14 a.m., Daniel Vrátil wrote: > > src/backendmanager.cpp, line 361 > > > > > > Instead of deleting the AbstractBackend manually here, you could let > > QPluginLoader do it by

Re: Review Request 126101: allow loading backends in-process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126101/ --- (Updated Nov. 24, 2015, 3:04 a.m.) Status -- This change has been

Re: Review Request 126101: allow loading backends in-process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126101/#review88635 --- Ship it! Looks good! Some minor comments left, but no need

Re: Review Request 126101: allow loading backends in-process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126101/ --- (Updated Nov. 20, 2015, 12:16 a.m.) Review request for Plasma, Solid,

Re: Review Request 126101: allow loading backends in-process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126101/#review88510 --- src/backendlauncher/backendloader.cpp (line 122)

Re: Review Request 126101: allow loading backends in-process

> On Nov. 17, 2015, 9:55 p.m., Daniel Vrátil wrote: > > Thanks a lot for the patch! I like the general approach and I just have two > > objections regarding the implementation: > > > > 1) I don't like the split of the ConfigOperations for In- and > > Out-Of-Process cases. Please just

Review Request 126101: allow loading backends in-process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126101/ --- Review request for Plasma, Solid, Aleix Pol Gonzalez, Daniel Vrátil, and

Re: Review Request 126101: allow loading backends in-process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126101/ --- (Updated Nov. 18, 2015, 2:36 a.m.) Review request for Plasma, Solid,

Re: Review Request 126101: allow loading backends in-process

> On Nov. 17, 2015, 9:55 p.m., Daniel Vrátil wrote: > > src/backendmanager_p.h, line 130 > > > > > > Why is this even a QHash? We don't want to run multiple backends at > > once, or do we? Wouldn't just holding

Re: Review Request 126101: allow loading backends in-process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126101/#review88502 --- Thanks a lot for the patch! I like the general approach and I