Re: Review Request 126104: Make networkmanager-qt an optional dependency
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126104/#review88581 --- Ship it! Ship It! - Marco Martin On Nov. 18, 2015, 3:55 p.m., Alex Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126104/ > --- > > (Updated Nov. 18, 2015, 3:55 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > I can't compile networkmanager-qt on my current system because the version > of NetworkManager seems to be too old. > > Also not every system has NetworkManager (FreeBSD?) so it should be > optional. > > > Diffs > - > > CMakeLists.txt d21a2b7a7774ac712f905f1db1ee478dca10b45c > dataengines/CMakeLists.txt 014da10aac5629be202bd5ad96012f817bf846ef > > Diff: https://git.reviewboard.kde.org/r/126104/diff/ > > > Testing > --- > > compiles > > > Thanks, > > Alex Richardson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126104: Make networkmanager-qt an optional dependency
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126104/ --- (Updated Nov. 19, 2015, 4:10 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit de5ed6c4cdded1f2ba2ce43022be1d1a9b475bf0 by Alex Richardson to branch master. Repository: plasma-workspace Description --- I can't compile networkmanager-qt on my current system because the version of NetworkManager seems to be too old. Also not every system has NetworkManager (FreeBSD?) so it should be optional. Diffs - CMakeLists.txt d21a2b7a7774ac712f905f1db1ee478dca10b45c dataengines/CMakeLists.txt 014da10aac5629be202bd5ad96012f817bf846ef Diff: https://git.reviewboard.kde.org/r/126104/diff/ Testing --- compiles Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 126104: Make networkmanager-qt an optional dependency
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126104/ --- Review request for Plasma. Repository: plasma-workspace Description --- I can't compile networkmanager-qt on my current system because the version of NetworkManager seems to be too old. Also not every system has NetworkManager (FreeBSD?) so it should be optional. Diffs - CMakeLists.txt d21a2b7a7774ac712f905f1db1ee478dca10b45c dataengines/CMakeLists.txt 014da10aac5629be202bd5ad96012f817bf846ef Diff: https://git.reviewboard.kde.org/r/126104/diff/ Testing --- compiles Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
