Re: Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

2015-11-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126106/ --- (Updated Nov. 19, 2015, 8:29 a.m.) Status -- This change has been

Re: Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

2015-11-18 Thread Martin Gräßlin
> On Nov. 19, 2015, 8:22 a.m., Thomas Lübking wrote: > > Is the full path required because of security concerns or because > > startplasmacompositor is broken (lacks proper environment setup)? security concerns. Problem is that an env scripct (which are sourced for reasons by the login

Re: Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

2015-11-18 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126106/#review88569 --- Ship it! Ship It! - Thomas Lübking On Nov. 19, 2015, 6:44

Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

2015-11-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126106/ --- Review request for kwin, Plasma, David Edmundson, and Matthias Klumpp.

Re: Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

2015-11-18 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126106/#review88563 --- Is it posssible to put it in seperate file? Because

Re: Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

2015-11-18 Thread Martin Gräßlin
> On Nov. 19, 2015, 7:53 a.m., Bhushan Shah wrote: > > Is it posssible to put it in seperate file? Because CMakeConfig is named as > > DBusInterface and no-one would expect it to have path to kwin_wayland. well I used what we have. I'm open with introducing a new file or renaming after Plasma

Re: Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

2015-11-18 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126106/#review88567 --- Is the full path required because of security concerns or