Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2017-02-08 Thread Marco Martin
> On Feb. 8, 2017, 2:42 p.m., Marco Martin wrote: > > is this still valid? please move it to phabricator if still valid - Marco --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2017-02-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126115/ --- (Updated Feb. 8, 2017, 3:32 p.m.) Status -- This change has been

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2017-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126115/#review102469 --- is this still valid? - Marco Martin On Nov. 19, 2015,

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Matthias Klumpp
> On Nov. 19, 2015, 5:31 nachm., Matthias Klumpp wrote: > > Okay, I talked to some GNOME people (thanks!) to find out how they handle > > this issue, and the short answer is: Not at all > > Reason for that is that it is really hard to fully secure the compositor if > > we allow apps to

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Martin Gräßlin
> On Nov. 19, 2015, 6:31 p.m., Matthias Klumpp wrote: > > Okay, I talked to some GNOME people (thanks!) to find out how they handle > > this issue, and the short answer is: Not at all > > Reason for that is that it is really hard to fully secure the compositor if > > we allow apps to

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Martin Gräßlin
> On Nov. 19, 2015, 3:08 p.m., Matthias Klumpp wrote: > > Did you consider running the whole script with `env -i`, or (likely the > > better idea) run KWin with `env -i`? > > That should sanitize the environment (unset all env vars, except for > > shell-defaults). You could then set exactly

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Martin Gräßlin
> On Nov. 19, 2015, 1:26 p.m., Sebastian Kügler wrote: > > Possibly naive question: How would I use it with my custom-build setup, > > where I need vars like QT_PLUGIN_PATH, etc. set to be able to start the > > binaries at all? I don't have a solution for it yet and yes it also affects my

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126115/#review88591 --- Possibly naive question: How would I use it with my

Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126115/ --- Review request for Plasma, David Edmundson and Matthias Klumpp.

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Alex Richardson
> On Nov. 19, 2015, 2:08 p.m., Matthias Klumpp wrote: > > Did you consider running the whole script with `env -i`, or (likely the > > better idea) run KWin with `env -i`? > > That should sanitize the environment (unset all env vars, except for > > shell-defaults). You could then set exactly

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Matthias Klumpp
> On Nov. 19, 2015, 2:08 nachm., Matthias Klumpp wrote: > > Did you consider running the whole script with `env -i`, or (likely the > > better idea) run KWin with `env -i`? > > That should sanitize the environment (unset all env vars, except for > > shell-defaults). You could then set exactly

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Xuetian Weng
> On Nov. 19, 2015, 2:08 p.m., Matthias Klumpp wrote: > > Did you consider running the whole script with `env -i`, or (likely the > > better idea) run KWin with `env -i`? > > That should sanitize the environment (unset all env vars, except for > > shell-defaults). You could then set exactly

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Martin Gräßlin
> On Nov. 19, 2015, 3:08 p.m., Matthias Klumpp wrote: > > Did you consider running the whole script with `env -i`, or (likely the > > better idea) run KWin with `env -i`? > > That should sanitize the environment (unset all env vars, except for > > shell-defaults). You could then set exactly

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Matthias Klumpp
> On Nov. 19, 2015, 12:26 nachm., Sebastian Kügler wrote: > > Possibly naive question: How would I use it with my custom-build setup, > > where I need vars like QT_PLUGIN_PATH, etc. set to be able to start the > > binaries at all? > > Martin Gräßlin wrote: > I don't have a solution for it

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Martin Gräßlin
> On Nov. 19, 2015, 3:08 p.m., Matthias Klumpp wrote: > > Did you consider running the whole script with `env -i`, or (likely the > > better idea) run KWin with `env -i`? > > That should sanitize the environment (unset all env vars, except for > > shell-defaults). You could then set exactly

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Matthias Klumpp
> On Nov. 19, 2015, 2:08 nachm., Matthias Klumpp wrote: > > Did you consider running the whole script with `env -i`, or (likely the > > better idea) run KWin with `env -i`? > > That should sanitize the environment (unset all env vars, except for > > shell-defaults). You could then set exactly

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Martin Gräßlin
> On Nov. 19, 2015, 3:08 p.m., Matthias Klumpp wrote: > > Did you consider running the whole script with `env -i`, or (likely the > > better idea) run KWin with `env -i`? > > That should sanitize the environment (unset all env vars, except for > > shell-defaults). You could then set exactly

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Matthias Klumpp
> On Nov. 19, 2015, 2:08 nachm., Matthias Klumpp wrote: > > Did you consider running the whole script with `env -i`, or (likely the > > better idea) run KWin with `env -i`? > > That should sanitize the environment (unset all env vars, except for > > shell-defaults). You could then set exactly

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Alex Richardson
> On Nov. 19, 2015, 2:08 p.m., Matthias Klumpp wrote: > > Did you consider running the whole script with `env -i`, or (likely the > > better idea) run KWin with `env -i`? > > That should sanitize the environment (unset all env vars, except for > > shell-defaults). You could then set exactly

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Martin Gräßlin
> On Nov. 19, 2015, 3:08 p.m., Matthias Klumpp wrote: > > Did you consider running the whole script with `env -i`, or (likely the > > better idea) run KWin with `env -i`? > > That should sanitize the environment (unset all env vars, except for > > shell-defaults). You could then set exactly

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Aleix Pol Gonzalez
> On Nov. 19, 2015, 1:26 p.m., Sebastian Kügler wrote: > > Possibly naive question: How would I use it with my custom-build setup, > > where I need vars like QT_PLUGIN_PATH, etc. set to be able to start the > > binaries at all? > > Martin Gräßlin wrote: > I don't have a solution for it

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Matthias Klumpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126115/#review88597 --- Did you consider running the whole script with `env -i`, or

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Martin Gräßlin
> On Nov. 19, 2015, 3:08 p.m., Matthias Klumpp wrote: > > Did you consider running the whole script with `env -i`, or (likely the > > better idea) run KWin with `env -i`? > > That should sanitize the environment (unset all env vars, except for > > shell-defaults). You could then set exactly

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Matthias Klumpp
> On Nov. 19, 2015, 12:26 nachm., Sebastian Kügler wrote: > > Possibly naive question: How would I use it with my custom-build setup, > > where I need vars like QT_PLUGIN_PATH, etc. set to be able to start the > > binaries at all? > > Martin Gräßlin wrote: > I don't have a solution for it

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Matthias Klumpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126115/#review88620 --- Okay, I talked to some GNOME people (thanks!) to find out how

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

2015-11-19 Thread Xuetian Weng
> On Nov. 19, 2015, 2:08 p.m., Matthias Klumpp wrote: > > Did you consider running the whole script with `env -i`, or (likely the > > better idea) run KWin with `env -i`? > > That should sanitize the environment (unset all env vars, except for > > shell-defaults). You could then set exactly