Re: Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

2015-12-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126570/ --- (Updated Dec. 30, 2015, 5:05 p.m.) Status -- This change has been

Re: Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

2015-12-30 Thread Martin Klapetek
> On Dec. 30, 2015, 12:49 p.m., David Edmundson wrote: > > Ship It! This requires frameworks 5.18 (because of the KNotifyConfig changes), so it should bump the required frameworks version, otherwise build failures will happen. - Martin

Re: Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

2015-12-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126570/#review90333 --- Ship it! Ship It! - David Edmundson On Dec. 29, 2015,

Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

2015-12-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126570/ --- Review request for Plasma, KDE Usability and Martin Klapetek.

Re: Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

2015-12-29 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126570/#review90315 --- Great idea! No objections from me. - Thomas Pfeiffer On