Re: Review Request 126576: Don't emit signals in another object from panel.

2015-12-30 Thread David Edmundson
On Dec. 30, 2015, 12:52 p.m., David Edmundson wrote: > > The rest LGTM. Thanks. You're right it's unrelated. Removed for now. - David --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 126576: Don't emit signals in another object from panel.

2015-12-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126576/ --- (Updated Dec. 30, 2015, 4:10 p.m.) Status -- This change has been

Review Request 126576: Don't emit signals in another object from panel.

2015-12-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126576/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 126576: Don't emit signals in another object from panel.

2015-12-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126576/#review90338 --- shell/panelview.cpp

Re: Review Request 126576: Don't emit signals in another object from panel.

2015-12-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126576/#review90343 --- Ship it! looks good, i'm also not 100% convinced by the