Re: Review Request 126946: ShowDesktop is not synchronized

2016-02-06 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126946/ --- (Updated Фев. 6, 2016, 4:57 след обяд) Review request for Plasma, David

Re: Review Request 126946: ShowDesktop is not synchronized

2016-02-02 Thread Martin Gräßlin
> On Feb. 2, 2016, 1:54 a.m., Sebastian Kügler wrote: > > Ship It! > > Sebastian Kügler wrote: > For bonus points, you could check if there's any X11 usage in the applet > otherwise, and if not, remove the m_isX11 and HAVE_X11 conditionals. This is > nicely abstracted in KWindowSystem

Review Request 126946: ShowDesktop is not synchronized

2016-02-01 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126946/ --- Review request for Plasma, David Edmundson, Martin Gräßlin, and Marco

Re: Review Request 126946: ShowDesktop is not synchronized

2016-02-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126946/#review91909 --- Ship it! Ship It! - Sebastian Kügler On Feb. 1, 2016,

Re: Review Request 126946: ShowDesktop is not synchronized

2016-02-01 Thread Sebastian Kügler
> On Feb. 2, 2016, 12:54 a.m., Sebastian Kügler wrote: > > Ship It! For bonus points, you could check if there's any X11 usage in the applet otherwise, and if not, remove the m_isX11 and HAVE_X11 conditionals. This is nicely abstracted in KWindowSystem now, the code there is a bit dated in