Re: Review Request 128021: [libtaskmanager] Prevent from dereferencing dangling pointer

2016-05-28 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128021/ --- (Updated May 28, 2016, 6:36 p.m.) Status -- This change has been

Re: Review Request 128021: [libtaskmanager] Prevent from dereferencing dangling pointer

2016-05-28 Thread Eike Hein
> On May 28, 2016, 12:36 p.m., Eike Hein wrote: > > Ship It! Since it won't /hurt/ and this code is on the way out anyway, why not .. - Eike --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 128021: [libtaskmanager] Prevent from dereferencing dangling pointer

2016-05-28 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128021/#review95944 --- Ship it! Ship It! - Eike Hein On May 28, 2016, 7:23

Re: Review Request 128021: [libtaskmanager] Prevent from dereferencing dangling pointer

2016-05-28 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128021/#review95942 --- Eike, did you agree it? - Anthony Fieroni On Май 28,

Re: Review Request 128021: [libtaskmanager] Prevent from dereferencing dangling pointer

2016-05-28 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128021/ --- (Updated Май 28, 2016, 10:23 преди обяд) Review request for Plasma and

Re: Review Request 128021: [libtaskmanager] Prevent from dereferencing dangling pointer

2016-05-26 Thread Anthony Fieroni
> On Май 26, 2016, 4:30 след обяд, David Edmundson wrote: > > Do you have a backtrace? Mostly so I can see if we can close any bug > > reports. > > > > A TaskManager.Backend objects is owned by the taskItem - so the lifespan of > > the TaskItem will *always* outlive the Backend - so we

Re: Review Request 128021: [libtaskmanager] Prevent from dereferencing dangling pointer

2016-05-26 Thread Anthony Fieroni
> On Май 26, 2016, 4:30 след обяд, David Edmundson wrote: > > Do you have a backtrace? Mostly so I can see if we can close any bug > > reports. > > > > A TaskManager.Backend objects is owned by the taskItem - so the lifespan of > > the TaskItem will *always* outlive the Backend - so we

Re: Review Request 128021: [libtaskmanager] Prevent from dereferencing dangling pointer

2016-05-26 Thread David Edmundson
> On May 26, 2016, 1:30 p.m., David Edmundson wrote: > > Do you have a backtrace? Mostly so I can see if we can close any bug > > reports. > > > > A TaskManager.Backend objects is owned by the taskItem - so the lifespan of > > the TaskItem will *always* outlive the Backend - so we shouldn't

Re: Review Request 128021: [libtaskmanager] Prevent from dereferencing dangling pointer

2016-05-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128021/#review95831 --- Do you have a backtrace? Mostly so I can see if we can close

Re: Review Request 128021: [libtaskmanager] Prevent from dereferencing dangling pointer

2016-05-26 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128021/ --- (Updated May 26, 2016, 3:04 p.m.) Review request for Plasma and Eike