Re: Review Request 128030: [libtaskamanger] Dismiss context menu when window is closed

2016-05-28 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128030/ --- (Updated May 28, 2016, 6:48 p.m.) Status -- This change has been

Re: Review Request 128030: [libtaskamanger] Dismiss context menu when window is closed

2016-05-28 Thread Anthony Fieroni
> On Май 28, 2016, 3:17 след обяд, Kai Uwe Broulik wrote: > > Meh. I thought I tested it thoroughly enough when switching from > > QMetaObject::invokeMethod to QTimer::singleShot(0 ... > > > > Isn't it sufficient to just cache the QQuickWindow pointer in a variable > > and pass that into the

Re: Review Request 128030: [libtaskamanger] Dismiss context menu when window is closed

2016-05-28 Thread Eike Hein
> On May 28, 2016, 12:16 p.m., Eike Hein wrote: > > Hmm ok ... note this will likely never ship though, in the applet ported to > > the new libtaskmanager the context menu is in QML and I think we've done > > the last 5.6.x already ... > > Kai Uwe Broulik wrote: > There can still be a

Re: Review Request 128030: [libtaskamanger] Dismiss context menu when window is closed

2016-05-28 Thread Kai Uwe Broulik
> On Mai 28, 2016, 12:16 nachm., Eike Hein wrote: > > Hmm ok ... note this will likely never ship though, in the applet ported to > > the new libtaskmanager the context menu is in QML and I think we've done > > the last 5.6.x already ... There can still be a 5.6.5 and I'd insist on having one

Re: Review Request 128030: [libtaskamanger] Dismiss context menu when window is closed

2016-05-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128030/#review95938 --- Meh. I thought I tested it thoroughly enough when switching

Re: Review Request 128030: [libtaskamanger] Dismiss context menu when window is closed

2016-05-28 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128030/#review95937 --- Ship it! Hmm ok ... note this will likely never ship

Re: Review Request 128030: [libtaskamanger] Dismiss context menu when window is closed

2016-05-28 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128030/ --- (Updated Май 28, 2016, 3:07 след обяд) Review request for Plasma, David

Review Request 128030: [libtaskamanger] Dismiss context menu when window is closed

2016-05-28 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128030/ --- Review request for Plasma, David Edmundson and Eike Hein. Summary