Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-06-15 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128040/ --- (Updated Юни 15, 2016, 12:49 след обяд) Status -- This change has

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-06-15 Thread Marco Martin
> On May 30, 2016, 11:32 a.m., Aleix Pol Gonzalez wrote: > > Could you look a bit into why is the containment null? > > Anthony Fieroni wrote: > So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i > can't reproduce crash, KScreen is not finish recognazing, which i write

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-31 Thread David Edmundson
> On May 30, 2016, 11:32 a.m., Aleix Pol Gonzalez wrote: > > Could you look a bit into why is the containment null? > > Anthony Fieroni wrote: > So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i > can't reproduce crash, KScreen is not finish recognazing, which i write

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-31 Thread Anthony Fieroni
> On Май 30, 2016, 2:32 след обяд, Aleix Pol Gonzalez wrote: > > Could you look a bit into why is the containment null? > > Anthony Fieroni wrote: > So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i > can't reproduce crash, KScreen is not finish recognazing, which i

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-30 Thread David Edmundson
> On May 30, 2016, 11:32 a.m., Aleix Pol Gonzalez wrote: > > Could you look a bit into why is the containment null? > > Anthony Fieroni wrote: > So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i > can't reproduce crash, KScreen is not finish recognazing, which i write

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-30 Thread Anthony Fieroni
> On Май 30, 2016, 2:32 след обяд, Aleix Pol Gonzalez wrote: > > Could you look a bit into why is the containment null? > > Anthony Fieroni wrote: > So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i > can't reproduce crash, KScreen is not finish recognazing, which i

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-30 Thread Marco Martin
> On May 30, 2016, 11:32 a.m., Aleix Pol Gonzalez wrote: > > Could you look a bit into why is the containment null? > > Anthony Fieroni wrote: > So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i > can't reproduce crash, KScreen is not finish recognazing, which i write

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-30 Thread Aleix Pol Gonzalez
> On May 30, 2016, 1:32 p.m., Aleix Pol Gonzalez wrote: > > Could you look a bit into why is the containment null? > > Anthony Fieroni wrote: > So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i > can't reproduce crash, KScreen is not finish recognazing, which i write >

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-30 Thread Anthony Fieroni
> On Май 30, 2016, 2:32 след обяд, Aleix Pol Gonzalez wrote: > > Could you look a bit into why is the containment null? So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i can't reproduce crash, KScreen is not finish recognazing, which i write above, corona.cpp:211 if

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128040/#review96027 --- Could you look a bit into why is the containment null? -

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-29 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128040/ --- (Updated Май 30, 2016, 7:33 преди обяд) Review request for Plasma, Aleix

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128040/#review96012 --- +1, it's fair to add a failsafe for release. It's about the

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-29 Thread Anthony Fieroni
> On Май 29, 2016, 6:30 след обяд, Kai Uwe Broulik wrote: > > shell/shellcorona.cpp, line 907 > > > > > > I think we need to figure out *why* containment is null, this assert is > > probably there for a reason.

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-29 Thread Kai Uwe Broulik
> On Mai 29, 2016, 3:30 nachm., Kai Uwe Broulik wrote: > > shell/shellcorona.cpp, line 907 > > > > > > I think we need to figure out *why* containment is null, this assert is > > probably there for a reason. >

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-29 Thread Anthony Fieroni
> On Май 29, 2016, 6:30 след обяд, Kai Uwe Broulik wrote: > > shell/shellcorona.cpp, line 907 > > > > > > I think we need to figure out *why* containment is null, this assert is > > probably there for a reason.

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128040/#review95983 --- -1 shell/shellcorona.cpp (line 907)

Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-28 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128040/ --- Review request for Plasma, Aleix Pol Gonzalez and David Edmundson. Bugs: