Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

2016-08-25 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128754/#review98646 --- Looks good to me. +1 - Anthony Fieroni On Авг. 25, 2016,

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

2016-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128754/ --- (Updated Aug. 25, 2016, 4:49 p.m.) Status -- This change has been

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

2016-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128754/ --- (Updated Aug. 25, 2016, 4:49 p.m.) Status -- This change has been

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

2016-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128754/ --- (Updated Aug. 25, 2016, 3:11 p.m.) Review request for KDE Frameworks and

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

2016-08-25 Thread David Edmundson
> On Aug. 25, 2016, 2:11 p.m., Anthony Fieroni wrote: > > src/plasma/private/applet_p.cpp, line 241 > > > > > > I think always emitting is error prone. You can emitting twice even 3 > > times. > > Same

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

2016-08-25 Thread David Edmundson
> On Aug. 25, 2016, 2:11 p.m., Anthony Fieroni wrote: > > src/plasma/private/applet_p.cpp, line 241 > > > > > > I think always emitting is error prone. You can emitting twice even 3 > > times. > > Same

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

2016-08-25 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128754/#review98639 --- src/plasma/private/applet_p.cpp (line 241)

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

2016-08-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128754/#review98633 --- Ship it! Ship It! - Marco Martin On Aug. 25, 2016,

Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

2016-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128754/ --- Review request for KDE Frameworks and Plasma. Repository: