Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128912/ --- (Updated Nov. 12, 2016, 2:13 p.m.) Status -- This change has been

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128912/#review100793 --- Ship it! Then let's go for it. We have 3 weeks until the

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128912/ --- (Updated Nov. 11, 2016, 3:39 nachm.) Review request for Documentation,

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

> On Nov. 11, 2016, 1:51 nachm., Luigi Toscano wrote: > > If I understand it correctly, the review include two separate change > > (import + fixes), is it correct? Then it's fine by me (pending confirmation > > for the shipit), the changes are fine and we can refine it later (better > > than

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128912/#review100778 --- If I understand it correctly, the review include two

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128912/ --- (Updated Nov. 11, 2016, 9:31 vorm.) Review request for Documentation,

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

> On Sept. 15, 2016, 9:28 a.m., Luigi Toscano wrote: > > Can they be made co-installable with the ones with kde-runtime, as both > > modules can be available at the same time? This is the problem of the > > missing support for kcontrol5 > > > > It was already done some time ago and I had to

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128912/#review100078 --- Ship it! Ship It! - Marco Martin On Sept. 15, 2016,

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

> On Sept. 15, 2016, 7:28 vorm., Luigi Toscano wrote: > > Can they be made co-installable with the ones with kde-runtime, as both > > modules can be available at the same time? This is the problem of the > > missing support for kcontrol5 > > > > It was already done some time ago and I had to

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

> On Sept. 15, 2016, 11:11 vorm., Marco Martin wrote: > > doc/kcontrol/cache/index.docbook, line 19 > > > > > > shouldn't it be updated as well? see my description the docbooks are imported as they were splitted

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128912/#review99205 --- doc/kcontrol/cache/index.docbook (line 19)

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128912/ --- (Updated Sept. 15, 2016, 9:09 vorm.) Review request for Documentation,