Re: Review Request 128948: Update shortcuts kcm docbook

2016-09-21 Thread Burkhard Lück 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128948/
---

(Updated Sept. 21, 2016, 10:11 a.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation and Plasma.


Changes
---

Submitted with commit 6c3de2f1ffaf681533e4c624c11581702ce601ff by Burkhard Lück 
to branch master.


Repository: plasma-desktop


Description
---

adapt to changes in 5.8


Diffs
-

  doc/kcontrol/keys/index.docbook 27eab50 

Diff: https://git.reviewboard.kde.org/r/128948/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

Re: Review Request 128948: Update shortcuts kcm docbook

2016-09-21 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128948/#review99346
---


Ship it!




Ship It!

- Marco Martin


On Sept. 20, 2016, 5:26 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128948/
> ---
> 
> (Updated Sept. 20, 2016, 5:26 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> adapt to changes in 5.8
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/keys/index.docbook 27eab50 
> 
> Diff: https://git.reviewboard.kde.org/r/128948/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128948: Update shortcuts kcm docbook

2016-09-20 Thread Burkhard Lück 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128948/
---

(Updated Sept. 20, 2016, 5:26 nachm.)


Review request for Documentation and Plasma.


Changes
---

Resort paras in section key-bindings-global


Repository: plasma-desktop


Description
---

adapt to changes in 5.8


Diffs (updated)
-

  doc/kcontrol/keys/index.docbook 27eab50 

Diff: https://git.reviewboard.kde.org/r/128948/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

Re: Review Request 128948: Update shortcuts kcm docbook

2016-09-20 Thread Burkhard Lück 


> On Sept. 19, 2016, 9:21 nachm., Marco Martin wrote:
> > doc/kcontrol/keys/index.docbook, line 137
> > 
> >
> > that part of loading/saving custom config schemes, even if isn't really 
> > something that should be in evidence anymore is still supported (buried 
> > under a menu in the bottom right corner)
> > i'm fine dropping this stuff from the docs tough

In this section a lot is obsolete, there are no schemes "Current scheme" or 
"KDE default" anymore and no "Save changes" button.
And the predefined scheme files you can load here are at least 5 years old and 
have only entities for klipper, krunner, kwin + kxkb
There for i deleted this section, which was commented already in plasma 5


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128948/#review99283
---


On Sept. 19, 2016, 7:35 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128948/
> ---
> 
> (Updated Sept. 19, 2016, 7:35 nachm.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> adapt to changes in 5.8
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/keys/index.docbook 27eab50 
> 
> Diff: https://git.reviewboard.kde.org/r/128948/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128948: Update shortcuts kcm docbook

2016-09-19 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128948/#review99283
---




doc/kcontrol/keys/index.docbook 


that part of loading/saving custom config schemes, even if isn't really 
something that should be in evidence anymore is still supported (buried under a 
menu in the bottom right corner)
i'm fine dropping this stuff from the docs tough


- Marco Martin


On Sept. 19, 2016, 7:35 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128948/
> ---
> 
> (Updated Sept. 19, 2016, 7:35 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> adapt to changes in 5.8
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/keys/index.docbook 27eab50 
> 
> Diff: https://git.reviewboard.kde.org/r/128948/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Review Request 128948: Update shortcuts kcm docbook

2016-09-19 Thread Burkhard Lück 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128948/
---

Review request for Documentation and Plasma.


Repository: plasma-desktop


Description
---

adapt to changes in 5.8


Diffs
-

  doc/kcontrol/keys/index.docbook 27eab50 

Diff: https://git.reviewboard.kde.org/r/128948/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück