Re: Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128997/ --- (Updated Sept. 23, 2016, 1:05 a.m.) Status -- This change has been

Re: Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-22 Thread David Edmundson
> On Sept. 21, 2016, 11:42 p.m., David Edmundson wrote: > > appmenu/appmenu.cpp, line 90 > > > > > > what's with this change? > > Aleix Pol Gonzalez wrote: > The warning was saying that it's a delete of

Re: Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128997/#review99422 --- Ship it! - David Edmundson On Sept. 21, 2016, 11:36

Re: Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-22 Thread Aleix Pol Gonzalez
> On Sept. 22, 2016, 1:42 a.m., David Edmundson wrote: > > appmenu/appmenu.cpp, line 90 > > > > > > what's with this change? > > Aleix Pol Gonzalez wrote: > The warning was saying that it's a delete of

Re: Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-22 Thread Marco Martin
> On Sept. 21, 2016, 11:42 p.m., David Edmundson wrote: > > appmenu/appmenu.cpp, line 90 > > > > > > what's with this change? > > Aleix Pol Gonzalez wrote: > The warning was saying that it's a delete of

Re: Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-21 Thread Anthony Fieroni
> On Септ. 22, 2016, 2:42 преди обяд, David Edmundson wrote: > > appmenu/appmenu.cpp, line 90 > > > > > > what's with this change? > > Aleix Pol Gonzalez wrote: > The warning was saying that it's a delete of

Re: Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-21 Thread Aleix Pol Gonzalez
> On Sept. 22, 2016, 1:42 a.m., David Edmundson wrote: > > appmenu/appmenu.cpp, line 90 > > > > > > what's with this change? The warning was saying that it's a delete of something fwd-declared. A bit more

Re: Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128997/#review99402 --- appmenu/appmenu.cpp (line 90)

Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128997/ --- Review request for Plasma. Repository: plasma-workspace Description