Re: Review Request 129872: [lookandfeel] Support changing window decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/ --- (Updated Ян. 28, 2017, 12:18 след обяд) Review request for Plasma, Kai

Re: Review Request 129872: [lookandfeel] Support changing window decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/ --- (Updated Ян. 28, 2017, 12:02 след обяд) Review request for Plasma, Kai

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Ян. 28, 2017, 10:47 преди обяд, Martin Gräßlin wrote: > > kcms/lookandfeel/kcm.cpp, line 362 > > > > > > I don't understand why the group is changed here? Was if wrong before? > > How was it wrong? It

Re: Review Request 129872: [lookandfeel] Support changing window decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/#review102292 --- I would have a much better time understanding your change

Re: Review Request 129872: [lookandfeel] Support changing window decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/ --- (Updated Ян. 28, 2017, 9:35 преди обяд) Review request for Plasma, Kai

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Jan. 27, 2017, 4:55 p.m., Martin Gräßlin wrote: > > kcms/lookandfeel/kcm.h, line 152 > > > > > > why move this line? I will fix it this mistake. > On Jan. 27, 2017, 4:55 p.m., Martin Gräßlin wrote: > >

Re: Review Request 129872: [lookandfeel] Support changing window decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/#review102285 --- I'm sorry, but this looks rather badly rebased. You deleted

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Jan. 25, 2017, 11:30 a.m., Martin Gräßlin wrote: > > I don't understand. We already have support for this in 5.9?!? > > Anthony Fieroni wrote: > I made in same approach like other roles and i commit defaults (in blocks) > > Martin Gräßlin wrote: > But Marco already implemented

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Jan. 25, 2017, 9:30 a.m., Martin Gräßlin wrote: > > I don't understand. We already have support for this in 5.9?!? > > Anthony Fieroni wrote: > I made in same approach like other roles and i commit defaults (in blocks) > > Martin Gräßlin wrote: > But Marco already implemented

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Jan. 25, 2017, 11:30 a.m., Martin Gräßlin wrote: > > I don't understand. We already have support for this in 5.9?!? > > Anthony Fieroni wrote: > I made in same approach like other roles and i commit defaults (in blocks) > > Martin Gräßlin wrote: > But Marco already implemented

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Jan. 25, 2017, 10:30 a.m., Martin Gräßlin wrote: > > I don't understand. We already have support for this in 5.9?!? > > Anthony Fieroni wrote: > I made in same approach like other roles and i commit defaults (in blocks) > > Martin Gräßlin wrote: > But Marco already implemented

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Ян. 25, 2017, 11:30 преди обяд, Martin Gräßlin wrote: > > I don't understand. We already have support for this in 5.9?!? > > Anthony Fieroni wrote: > I made in same approach like other roles and i commit defaults (in blocks) > > Martin Gräßlin wrote: > But Marco already

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Jan. 25, 2017, 10:30 a.m., Martin Gräßlin wrote: > > I don't understand. We already have support for this in 5.9?!? > > Anthony Fieroni wrote: > I made in same approach like other roles and i commit defaults (in blocks) But Marco already implemented that, didn't he? That's why I don't

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Ян. 25, 2017, 11:30 преди обяд, Martin Gräßlin wrote: > > I don't understand. We already have support for this in 5.9?!? I made in same approach like other roles and i commit defaults (in blocks) - Anthony --- This is an

Re: Review Request 129872: [lookandfeel] Support changing window decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/#review102237 --- I don't understand. We already have support for this in

Re: Review Request 129872: [lookandfeel] Support changing window decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/ --- (Updated Ян. 24, 2017, 10 след обяд) Review request for Plasma, Kai Uwe

Re: Review Request 129872: [lookandfeel] Support changing window decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/ --- (Updated Ян. 24, 2017, 9:40 след обяд) Review request for Plasma, Kai

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Jan. 22, 2017, 4:19 p.m., Martin Gräßlin wrote: > > Marco quite recently implemented this: > > > > https://cgit.kde.org/plasma-desktop.git/commit/kcms/lookandfeel?id=81be6962b1e43ea4da7caa038fa87d84a3129937 > > Anthony Fieroni wrote: > Maybe it should be backported to 5.8? > > Martin

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Ян. 22, 2017, 6:19 след обяд, Martin Gräßlin wrote: > > Marco quite recently implemented this: > > > > https://cgit.kde.org/plasma-desktop.git/commit/kcms/lookandfeel?id=81be6962b1e43ea4da7caa038fa87d84a3129937 > > Anthony Fieroni wrote: > Maybe it should be backported to 5.8? > >

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Jan. 22, 2017, 5:19 nachm., Martin Gräßlin wrote: > > Marco quite recently implemented this: > > > > https://cgit.kde.org/plasma-desktop.git/commit/kcms/lookandfeel?id=81be6962b1e43ea4da7caa038fa87d84a3129937 > > Anthony Fieroni wrote: > Maybe it should be backported to 5.8? No,

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Ян. 22, 2017, 6:19 след обяд, Martin Gräßlin wrote: > > Marco quite recently implemented this: > > > > https://cgit.kde.org/plasma-desktop.git/commit/kcms/lookandfeel?id=81be6962b1e43ea4da7caa038fa87d84a3129937 Maybe it should be backported to 5.8? - Anthony

Re: Review Request 129872: [lookandfeel] Support changing window decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/#review102179 --- Marco quite recently implemented this:

Review Request 129872: [lookandfeel] Support changing window decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/ --- Review request for Plasma, Kai Uwe Broulik, Hugo Pereira Da Costa, and