D27554: reviews: expose the reviewed package version on the delegate

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:d58668698f5f: reviews: expose the reviewed package version on the delegate (authored by apol). REPOSIT

D27554: reviews: expose the reviewed package version on the delegate

apol added a comment. In D27554#615412 , @ngraham wrote: > Nice! How about putting the version next to the stars, up on the header row? Having 2 text fields growing one against each other is often a source of problems. Could work though.

D27554: reviews: expose the reviewed package version on the delegate

ngraham added a reviewer: VDG. ngraham added a comment. Nice! How about putting the version next to the stars, up on the header row? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D27554 To: apol, #plasma, #vdg Cc: ngraham, plasma-devel, Orage,

D27554: reviews: expose the reviewed package version on the delegate

apol added a comment. F8119550: Screenshot_20200221_210428.png #vdg REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D27554 To: apol, #plasma Cc: plasma-devel, Orage,

D27554: reviews: expose the reviewed package version on the delegate

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Helps show which version was reviewed to see if the critiques might have been figured out. BUG:

D26566: Fix layout for the reviews sheet

This revision was automatically updated to reflect the committed changes. Closed by commit R134:98898d6ac407: Fix layout for the reviews sheet (authored by mart). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26566?vs=73213=73379 REVISION

D26566: Fix layout for the reviews sheet

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice, thanks! REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D26566 To: mart, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel,

D26566: Fix layout for the reviews sheet

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY - the main contentitem of a sheet should have *always* an explicit implicitWidth - never use

D25889: Polish the reviews UI and presentation

This revision was automatically updated to reflect the committed changes. Closed by commit R134:f41f25e895a9: Polish the reviews UI and presentation (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25889?vs=72758=72759

D25889: Polish the reviews UI and presentation

ngraham updated this revision to Diff 72758. ngraham marked an inline comment as done. ngraham added a comment. Address review comment REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25889?vs=72336=72758 BRANCH polish-review-reviewing

D25889: Polish the reviews UI and presentation

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ReviewDelegate.qml:188 > +checkable: true > +checked: { > +switch(usefulChoice) { `checked:

D25889: Polish the reviews UI and presentation

ngraham added a comment. I'll do the change to show the top positive and top negative reviews on the app page in a separate patch once this lands. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D25889 To: ngraham, #vdg, apol

D25886: Add support for sub-comments to the Reviews backend

This revision was automatically updated to reflect the committed changes. Closed by commit R134:a4b6d2d5c25e: Add support for sub-comments to the Reviews backend (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25886?vs

D25886: Add support for sub-comments to the Reviews backend

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice! REPOSITORY R134 Discover Software Store BRANCH add-support-for-subcomments (branched from master) REVISION DETAIL https://phabricator.kde.org/D25886 To: leinir,

D25886: Add support for sub-comments to the Reviews backend

leinir created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Using a similar style to the comments delegate in KNewStuffQuick, this adds the functionality for having subcomments in the Reviews

D13678: Overhaul presentation of link buttons in the Reviews section

This revision was automatically updated to reflect the committed changes. Closed by commit R134:5ee0a9c8c4cb: Overhaul presentation of link buttons in the Reviews section (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D13678: Overhaul presentation of link buttons in the Reviews section

ngraham updated this revision to Diff 36517. ngraham added a comment. Fix logic error REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13678?vs=36516=36517 BRANCH overhaul-review-section-prsentation (branched from master) REVISION DETAIL

D13678: Overhaul presentation of link buttons in the Reviews section

ngraham created this revision. ngraham added reviewers: Discover Software Store, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Move the link buttons in the Reviews section

D10527: Improve "show more reviews" string and logic

This revision was automatically updated to reflect the committed changes. Closed by commit R134:47d77057ded5: Improve show more reviews string and logic (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10527?vs=27209=27268

D10527: Improve "show more reviews" string and logic

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH better-more-reviews-string (branched from master) REVISION DETAIL https://phabricator.kde.org/D10527 To: ngraham, #discover_software_store, apol Cc: plasma-devel

D10527: Improve "show more reviews" string and logic

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10527 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10527: Improve "show more reviews" string and logic

for the "show more reviews" button. Also fix the bug where the "show more reviews" text would be absent if `rating` was null, which triggered logic that set the number of reviews to be 0. This didn't seem to be adding anything, so I removed it and everything still seems to w

D10237: Bring back embedded top3 reviews on the ApplicationPage

ngraham added a comment. [We will iterate over this incrementally since it's on master] REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10237 To: apol, ngraham, #discover_software_store Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10237: Bring back embedded top3 reviews on the ApplicationPage

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:acf66dd18540: Bring back embedded top3 reviews on the ApplicationPage (authored by apol). CHANGED PRIOR

D10237: Bring back embedded top3 reviews on the ApplicationPage

ngraham added a comment. Getting there! - Change the text "Show reviews" to "Show more reviews" - Maybe change the "Reviews" header to "Top Reviews". Judgment call, not necessarily required - The increased padding between the reviews is good

D10237: Bring back embedded top3 reviews on the ApplicationPage

apol updated this revision to Diff 26856. apol added a comment. Addressed Nate's comments REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10237?vs=26338=26856 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10237 AFFECTED

D10237: Bring back embedded top3 reviews on the ApplicationPage

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10237 To: apol, ngraham, #discover_software_store Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10237: Bring back embedded top3 reviews on the ApplicationPage

ngraham added a reviewer: Discover Software Store. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10237 To: apol, ngraham, #discover_software_store Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10237: Bring back embedded top3 reviews on the ApplicationPage

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. F5687564: What it looks like.png <https://phabricator.kde.org/F5687564> Nice! There are a few polish changes I'd like to see: - Add a header label saying "

D10237: Bring back embedded top3 reviews on the ApplicationPage

apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REPOSITORY R134 Discover Software Store BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10237

Reviews

Sorry for flooding the mailing list. I've spent the morning cleaning out some of Plasma's review requests. One was nearly 4 years old. The following reviews are for 4.x but seem to be non-invasive bug fixes that I /think/ we should backport. I'd like a second opinion from people more familiar

Re: Reviews

On Tue, Jul 29, 2014 at 12:07 PM, David Edmundson da...@davidedmundson.co.uk wrote: There are a /lot/ of Plasma Media Centre reviews open (about half are PMC), I'm not sure what the state of those is, are they awaiting reviews from the non-media centre devs, or just no longer relevant

Re: Reviews

On Tuesday 29 July 2014, David Edmundson wrote: Sorry for flooding the mailing list. I've spent the morning cleaning out some of Plasma's review requests. One was nearly 4 years old. good stuff. on the list of reviews you posted, i commented on them, separing those that i think could

Re: Reviews

Hello, On Tue, Jul 29, 2014 at 3:37 PM, David Edmundson da...@davidedmundson.co.uk wrote: There are a /lot/ of Plasma Media Centre reviews open (about half are PMC), I'm not sure what the state of those is, are they awaiting reviews from the non-media centre devs, or just no longer relevant

Re: Reviews

reviews open (about half are PMC), I'm not sure what the state of those is, are they awaiting reviews from the non-media centre devs, or just no longer relevant. If someone from PMC pings me I can help go through and discard outdated things. Following PMC reviews needs to be discarded

Re: Reviews

On Tue, Jul 29, 2014 at 5:15 PM, Bhushan Shah bhus...@gmail.com wrote: Following PMC reviews needs to be discarded, Some more, https://git.reviewboard.kde.org/r/114055/ - code is already in repo Non PMC, https://git.reviewboard.kde.org/r/117681/ - no review so far https

Re: Reviews

, Jul 29, 2014 at 5:15 PM, Bhushan Shah bhus...@gmail.com wrote: Following PMC reviews needs to be discarded, Some more, https://git.reviewboard.kde.org/r/114055/ - code is already in repo Non PMC, https://git.reviewboard.kde.org/r/117681/ - no review so far https://git.reviewboard.kde.org/r

Improvements and Enhancements for Plasma Media Center Proposal Report reviews

Hi, I have submitted the proposal to work upon the project - Improvements and Enhancements on Plasma Media Center on melange. I kindly request all the mentors to review it and please let me know your suggestions for the same and if there are some changes/additions that need to be done in it.