Re: plasma-systemmonitor in kdereview
On Thursday, 1 October 2020 14:11:16 CET Harald Sitter wrote: > > Cool stuff. > > L10n is currently a bit incomplete. > Notably > - the pages files lack any localization at all and I'm also not sure how > those could be best localized. As an update to this, this should be fixed for 5.21. The pages are now treated as desktop files and include the translations once things have been extracted. Since that was as far as I know the last major issue raised during review and we did the release yesterday it has now been moved to Plasma proper. Thank you everyone who reviewed. - Arjen > > HS
Re: plasma-systemmonitor in kdereview
On Friday, 2 October 2020 17:10:36 CEST Carl Schwan wrote: > > Plasma System Monitor looks quite good, but it doesn't look like it is > navigable with the keyboard only. I know that some of the issues are caused > by Kirigami and Qml but it looks like many custom components can't get any > focus with tab and need the mouse to work. > As an update to this, I did a first pass to improve keyboard navigation, now in "view" mode things should work correctly, with everything that should get focus receiving focus, including the applications table on the overview page. As said before, the edit mode is a different beast and we're not yet entirely sure how to handle keyboard for that. - Arjen
Re: plasma-systemmonitor in kdereview
On Monday, 19 October 2020 00:28:38 CEST Albert Astals Cid wrote: > How serious are these cmake warnings? http://paste.debian.net/1167754/ I've seen those before; apparently the result is that there's no autogenerated appdata for the sensor faces. Not sure how important that is to be honest. At least the package itself installs properly. > I'd personally would suggest to remove these default values from KillDialog.qml Done in [1] > I guess i'm running a too old version of some dependency? > > "file:///home/tsdgeos/devel/kde/install/share/ksysguard/sensorfaces/org.kde > .ksysguard.processtable/contents/ui/FullRepresentation.qml:127:18:TypeProces > sTableViewunavailable" > "file:///home/tsdgeos/devel/kde/install/share/ksysguard/sensorfaces/org.kde > .ksysguard.processtable/contents/ui/ProcessTableView.qml:97:9:Cannotassignto > non-existentproperty\"flatList\"" Would make sense to mark that in the > cmakelists you think? or is it just supposed to be used with plasma master > in sync? Actually, the intention was to be able to build against Plasma 5.20. The tree view support bits were only added in master though and we apparently forgot to check that it still works with 5.20. I've fixed that also in [1] [1]: https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/56
Re: plasma-systemmonitor in kdereview
On 2020 tobula d. 19id 00:28:38 CEST Albert Astals Cid wrote: > El dijous, 1 d’octubre de 2020, a les 11:36:12 CEST, Arjen Hiemstra va escriure: > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It > > can be found at https://invent.kde.org/plasma/plasma-systemmonitor . > > How serious are these cmake warnings? http://paste.debian.net/1167754/ If this one error is to believed (and is faithfully cut-and-pasted): Error: description missing, will result in broken appdata field as is mandatory at /home/tsdgeos/devel/kde/plasma-systemmonitor/src/faces/applicationstable/ metadata.desktop Call Stack (most recent call first): src/faces/CMakeLists.txt:1 (kpackage_install_package) Then we have a typo problem somewhere else as well, since "sumary" is an unlikely element name. [ade] signature.asc Description: This is a digitally signed message part.
Re: plasma-systemmonitor in kdereview
El dijous, 1 d’octubre de 2020, a les 14:36:05 CEST, Arjen Hiemstra va escriure:
> On Thursday, 1 October 2020 14:11:16 CEST Harald Sitter wrote:
> > On 01.10.20 11:36, Arjen Hiemstra wrote:
> > > Hello,
> > >
> > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It
> > > can be found at https://invent.kde.org/plasma/plasma-systemmonitor .
> > >
> > > plasma-systemmonitor is a new system monitor UI built with Kirigami. It
> > > makes use of the ksystemstats daemon and the faces system for system
> > > monitor plasmoids that were both introduced in Plasma 5.19.
> > >
> > > Our current plan is to do a "preview release" alongside Plasma 5.20, then
> > > have it be an official part of Plasma with 5.21.
> >
> > Cool stuff.
> >
> > L10n is currently a bit incomplete.
> > Notably
> > - the pages files lack any localization at all and I'm also not sure how
> > those could be best localized.
>
> Yeah that is a good point. If we can somehow extract the strings from these
> files I think we can make it work. But that may need some custom scripting.
I think that shows a bit of a bad design decision. You shouldn't have default
user visible strings in data files if they are also user editable
If you do, you have several chained problems:
* You need to extract those strings somehow
* You need to feed all the "title" strings coming from .page files through
i18n() to get the translation before showing it to the user
* Once you do that, what happens if i create a page and call it "Disk"? i do
*not* want to get the translation for that, it's something i manually created i
want to get exactly what i wrote
* This means that now for each title string in your .page files you need to
store whether this is a default string and thus should be passed through i18n
or if it is a user-entered string and should not be passed through i18n
Random suggestion after spending 2 minutes thinking on it, for the default
pages instead of having
title=Disk
you have
default_page_title=overview_page_disk
and then on the C++ side you have a big group of
if (default_page_title == "overview_page_disk") return i18nc("Label on
Overview Page", "Disk");
and leave title only for user created pages.
Cheers,
Albert
Re: plasma-systemmonitor in kdereview
El dijous, 1 d’octubre de 2020, a les 11:36:12 CEST, Arjen Hiemstra va escriure: > Hello, > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It can > be found at https://invent.kde.org/plasma/plasma-systemmonitor . > > plasma-systemmonitor is a new system monitor UI built with Kirigami. It makes > use of the ksystemstats daemon and the faces system for system monitor > plasmoids that were both introduced in Plasma 5.19. > > Our current plan is to do a "preview release" alongside Plasma 5.20, then > have > it be an official part of Plasma with 5.21. How serious are these cmake warnings? http://paste.debian.net/1167754/ I'd personally would suggest to remove these default values from KillDialog.qml property string killButtonText: "Exterminate" property string killButtonIcon: "killbots" property string questionText: "Ex-ter-mi-nate" they are not used anywhere and just cause confusion. I guess i'm running a too old version of some dependency? "file:///home/tsdgeos/devel/kde/install/share/ksysguard/sensorfaces/org.kde.ksysguard.processtable/contents/ui/FullRepresentation.qml:127:18: Type ProcessTableView unavailable" "file:///home/tsdgeos/devel/kde/install/share/ksysguard/sensorfaces/org.kde.ksysguard.processtable/contents/ui/ProcessTableView.qml:97:9: Cannot assign to non-existent property \"flatList\"" Would make sense to mark that in the cmakelists you think? or is it just supposed to be used with plasma master in sync? Cheers, Albert > > Cheers, > Arjen > > >
Re: plasma-systemmonitor in kdereview
On Friday, 2 October 2020 17:10:36 CEST Carl Schwan wrote: > Le jeudi, octobre 1, 2020 11:36 AM, Arjen Hiemstra a écrit : > > Hello, > > > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It > > can be found at https://invent.kde.org/plasma/plasma-systemmonitor . > > > > plasma-systemmonitor is a new system monitor UI built with Kirigami. It > > makes use of the ksystemstats daemon and the faces system for system > > monitor plasmoids that were both introduced in Plasma 5.19. > > > > Our current plan is to do a "preview release" alongside Plasma 5.20, then > > have it be an official part of Plasma with 5.21. > > Plasma System Monitor looks quite good, but it doesn't look like it is > navigable with the keyboard only. I know that some of the issues are caused > by Kirigami and Qml but it looks like many custom components can't get any > focus with tab and need the mouse to work. That's a good point, I think for a first pass I'd ensure that normal "viewing" works. Making the edit mode work with keyboard is going to be another thing entirely since that very much relies on drag and drop currently. > > It is also normal for Table component to import private api from > qqc2-desktop-style framework? Normal, no. Required, yes unfortunately. When this was written there was no header control available. And even now if we port to HorizontalHeaderView we'd probably need the private import since the API of HorizontalHeaderView is severely lacking, so we'd need to replace the delegate which means we'd need some way of getting the system-styled header item. > > https://invent.kde.org/plasma/plasma-systemmonitor/-/blob/master/src/table/F > irstCellDelegate.qml#L13 > > Cheers, > Carl > > > Cheers, > > Arjen
Re: plasma-systemmonitor in kdereview
Le jeudi, octobre 1, 2020 11:36 AM, Arjen Hiemstra a écrit : > Hello, > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It can > be found at https://invent.kde.org/plasma/plasma-systemmonitor . > > plasma-systemmonitor is a new system monitor UI built with Kirigami. It makes > use of the ksystemstats daemon and the faces system for system monitor > plasmoids that were both introduced in Plasma 5.19. > > Our current plan is to do a "preview release" alongside Plasma 5.20, then have > it be an official part of Plasma with 5.21. Plasma System Monitor looks quite good, but it doesn't look like it is navigable with the keyboard only. I know that some of the issues are caused by Kirigami and Qml but it looks like many custom components can't get any focus with tab and need the mouse to work. It is also normal for Table component to import private api from qqc2-desktop-style framework? https://invent.kde.org/plasma/plasma-systemmonitor/-/blob/master/src/table/FirstCellDelegate.qml#L13 Cheers, Carl > > Cheers, > Arjen
Re: plasma-systemmonitor in kdereview
On 01.10.20 14:36, Arjen Hiemstra wrote: > On Thursday, 1 October 2020 14:11:16 CEST Harald Sitter wrote: >> On 01.10.20 11:36, Arjen Hiemstra wrote: >>> Hello, >>> >>> I'd hereby like to announce that plasma-systemmonitor is in kdereview. It >>> can be found at https://invent.kde.org/plasma/plasma-systemmonitor . >>> >>> plasma-systemmonitor is a new system monitor UI built with Kirigami. It >>> makes use of the ksystemstats daemon and the faces system for system >>> monitor plasmoids that were both introduced in Plasma 5.19. >>> >>> Our current plan is to do a "preview release" alongside Plasma 5.20, then >>> have it be an official part of Plasma with 5.21. >> >> Cool stuff. >> >> L10n is currently a bit incomplete. >> Notably >> - the pages files lack any localization at all and I'm also not sure how >> those could be best localized. > > Yeah that is a good point. If we can somehow extract the strings from these > files I think we can make it work. But that may need some custom scripting. > >> - the 'configure columns' feature doesn't load the translated strings >> into the checkboxes > > Huh, weird. They are being populated by i18n calls, wonder what's going on > there. I also couldn't spot what's going wrong FWIW. There was a problem with strings getting loaded before the domain was set up or something with qml plugins. Maybe it's that problem? OTOH why would that affect the combobox but not the labels. It's very odd indeed. >> >> On the subject of configure columns I feel like word wrapping would look >> better than eliding there https://i.imgur.com/RbAeUhH.png >> >> Something is astray with memory calculation. See konsole which is >> somehow listed as 2.6gib https://i.imgur.com/MjIpj3O.png but its actual >> children aren't getting nowhere near that number. I'm guessing it's >> because even detached processes (notably vscode here) are in the same >> cgroup? If so we probably can't do much about this? >> > > There's two things going on here I expect: everything started from konsole > will be part of the konsole cgroup unless started through kstart5 or a > similar > tool that explicitly moves things to a new cgroup. I doubt this is solvable > without patching all major shells. > > The other thing is that the "memory" column here is what is called "Total > Memory" in KSysGuard, which is the process' private memory with the shared > memory added divided over the processes that share that memory. This provides > a more accurate number for the actual memory usage of the process, but does > mean that it will most likely seem like it suddenly uses more memory, since > the "memory" in KSysGuard is only the private memory. Makes sense. Maybe we should blacklist konsole or something ^^ I'm almost certain people are going to look at it and go "gosh, konsole is fat" and then turn to their forum of choice and lament how terribly inefficient our software is. >> Sometimes the CPU column shows nan% for new apps. Happens a lot with >> bustle for me. In fact, sometimes I have two entries one of which is >> nan% for all eternity https://i.imgur.com/HLavLsI.png > > The lingering one is odd, but may have something to do with cgroups not > getting cleaned up properly. If you can reproduce and provide the output of > systemd-cgls that would be helpful. │ ├─user@1000.service │ │ ├─app.slice │ │ │ ├─app-org.freedesktop.Bustle-c200626490444a60b898eb65b179d6f7.scope │ │ │ │ ├─216216 bwrap --args 31 bustle │ │ │ │ ├─216224 bwrap --args 31 bustle │ │ │ │ └─216225 bustle │ │ ├─flatpak-org.freedesktop.Bustle-216216.scope │ │ │ ├─216221 bwrap --args 31 xdg-dbus-proxy --args=33 │ │ │ └─216222 xdg-dbus-proxy --args=33 Mind you, both are cleaned up on exit and the second one doesn't always appear to begin with. >> Also the columns in the processes page lack labels. > > Gah. And applications works correctly? Yup. HS
Re: plasma-systemmonitor in kdereview
On Thursday, 1 October 2020 14:11:16 CEST Harald Sitter wrote: > On 01.10.20 11:36, Arjen Hiemstra wrote: > > Hello, > > > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It > > can be found at https://invent.kde.org/plasma/plasma-systemmonitor . > > > > plasma-systemmonitor is a new system monitor UI built with Kirigami. It > > makes use of the ksystemstats daemon and the faces system for system > > monitor plasmoids that were both introduced in Plasma 5.19. > > > > Our current plan is to do a "preview release" alongside Plasma 5.20, then > > have it be an official part of Plasma with 5.21. > > Cool stuff. > > L10n is currently a bit incomplete. > Notably > - the pages files lack any localization at all and I'm also not sure how > those could be best localized. Yeah that is a good point. If we can somehow extract the strings from these files I think we can make it work. But that may need some custom scripting. > - the 'configure columns' feature doesn't load the translated strings > into the checkboxes Huh, weird. They are being populated by i18n calls, wonder what's going on there. > > On the subject of configure columns I feel like word wrapping would look > better than eliding there https://i.imgur.com/RbAeUhH.png > > Something is astray with memory calculation. See konsole which is > somehow listed as 2.6gib https://i.imgur.com/MjIpj3O.png but its actual > children aren't getting nowhere near that number. I'm guessing it's > because even detached processes (notably vscode here) are in the same > cgroup? If so we probably can't do much about this? > There's two things going on here I expect: everything started from konsole will be part of the konsole cgroup unless started through kstart5 or a similar tool that explicitly moves things to a new cgroup. I doubt this is solvable without patching all major shells. The other thing is that the "memory" column here is what is called "Total Memory" in KSysGuard, which is the process' private memory with the shared memory added divided over the processes that share that memory. This provides a more accurate number for the actual memory usage of the process, but does mean that it will most likely seem like it suddenly uses more memory, since the "memory" in KSysGuard is only the private memory. > The table highlights are getting messed up when new apps appear/disappear. > New app appears: https://i.imgur.com/tacWeoI.png mind that suddenly the > ksysguard memory cell is selected as well. More or less the same happens > when a process disappears. The cells seem somewhat random though Memory > is almost always a highlighted one. Ugh, I thought we fixed that. The trouble here is that QML's TableView has a bug where certain bindings aren't properly reevaluated. We have a workaround in place but apparently it doesn't work in all cases. :/ > > Sometimes the CPU column shows nan% for new apps. Happens a lot with > bustle for me. In fact, sometimes I have two entries one of which is > nan% for all eternity https://i.imgur.com/HLavLsI.png The lingering one is odd, but may have something to do with cgroups not getting cleaned up properly. If you can reproduce and provide the output of systemd-cgls that would be helpful. > > Possibly related: when editing the Processes page and discarding all > changes the R/W columns show negative values for a second or two. > https://i.imgur.com/amrfewG.png Yeah I've seen that happen as well, it has something to do with the underlying ProcessCore processes not being updated yet I expect. This probably also causes the NaN above, since the application table currently uses the sum of all values of the processes to display values. > > Also the columns in the processes page lack labels. Gah. And applications works correctly? > > HS
Re: plasma-systemmonitor in kdereview
On 01.10.20 11:36, Arjen Hiemstra wrote: > Hello, > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It can > be found at https://invent.kde.org/plasma/plasma-systemmonitor . > > plasma-systemmonitor is a new system monitor UI built with Kirigami. It makes > use of the ksystemstats daemon and the faces system for system monitor > plasmoids that were both introduced in Plasma 5.19. > > Our current plan is to do a "preview release" alongside Plasma 5.20, then > have > it be an official part of Plasma with 5.21. Cool stuff. L10n is currently a bit incomplete. Notably - the pages files lack any localization at all and I'm also not sure how those could be best localized. - the 'configure columns' feature doesn't load the translated strings into the checkboxes On the subject of configure columns I feel like word wrapping would look better than eliding there https://i.imgur.com/RbAeUhH.png Something is astray with memory calculation. See konsole which is somehow listed as 2.6gib https://i.imgur.com/MjIpj3O.png but its actual children aren't getting nowhere near that number. I'm guessing it's because even detached processes (notably vscode here) are in the same cgroup? If so we probably can't do much about this? The table highlights are getting messed up when new apps appear/disappear. New app appears: https://i.imgur.com/tacWeoI.png mind that suddenly the ksysguard memory cell is selected as well. More or less the same happens when a process disappears. The cells seem somewhat random though Memory is almost always a highlighted one. Sometimes the CPU column shows nan% for new apps. Happens a lot with bustle for me. In fact, sometimes I have two entries one of which is nan% for all eternity https://i.imgur.com/HLavLsI.png Possibly related: when editing the Processes page and discarding all changes the R/W columns show negative values for a second or two. https://i.imgur.com/amrfewG.png Also the columns in the processes page lack labels. HS
plasma-systemmonitor in kdereview
Hello, I'd hereby like to announce that plasma-systemmonitor is in kdereview. It can be found at https://invent.kde.org/plasma/plasma-systemmonitor . plasma-systemmonitor is a new system monitor UI built with Kirigami. It makes use of the ksystemstats daemon and the faces system for system monitor plasmoids that were both introduced in Plasma 5.19. Our current plan is to do a "preview release" alongside Plasma 5.20, then have it be an official part of Plasma with 5.21. Cheers, Arjen
