Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-06-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/#review14525 --- Ship it! I still think that the template is quite bad and a

Re: Review Request: Plasmate: Add tabbox previewer

2012-06-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105139/#review14528 --- The standalone previewer is missing a Messages.sh, isn't it?

Re: Review Request: Fix text colors on TabButton and ToolButton

2012-06-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105163/#review14529 --- This review has been submitted with commit

Re: Review Request: Use the same text color as C++ Plasma::LineEdit

2012-06-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105159/#review14530 --- This review has been submitted with commit

Re: Re: kde plasma workspace structure

2012-06-09 Thread Martin Gräßlin
On Saturday 09 June 2012 04:45:51 Aaron J. Seigo wrote: * losing portability to non-Linux (and even specific Linux OSes) something I would like to discuss in the light of workspace. I think we all agree that we do neither target MS Windows nor OS X. (I know you can run plasma-desktop on

Re: kde plasma workspace structure

2012-06-09 Thread Aaron J. Seigo
On Saturday, June 9, 2012 10:28:05 Martin Gräßlin wrote: On Saturday 09 June 2012 04:45:51 Aaron J. Seigo wrote: * losing portability to non-Linux (and even specific Linux OSes) something I would like to discuss in the light of workspace. I think we all agree that we do neither target MS

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

2012-06-09 Thread Aaron J. Seigo
On June 2, 2012, 3:14 p.m., David Edmundson wrote: publisher/remoteinstaller/remoteinstallerdialog.cpp, line 53 http://git.reviewboard.kde.org/r/105032/diff/3/?file=66057#file66057line53 This looks like it leaks. QScopedPointer perhaps? Giorgos Tsiapaliwkas wrote:

Re: Review Request: Plasmate: when Enable signing plasmoid is enabled, automatically choose a key

2012-06-09 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105074/#review14535 --- Ship it! a couple of small items, but looks good to go in.

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

2012-06-09 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/#review14536 --- publisher/remoteinstaller/remoteinstaller.cpp

Re: Re: kde plasma workspace structure

2012-06-09 Thread Martin Gräßlin
On Saturday 09 June 2012 11:13:16 Aaron J. Seigo wrote: On Saturday, June 9, 2012 10:28:05 Martin Gräßlin wrote: On Saturday 09 June 2012 04:45:51 Aaron J. Seigo wrote: * losing portability to non-Linux (and even specific Linux OSes) something I would like to discuss in the light of

Re: kde plasma workspace structure

2012-06-09 Thread Alex Fiestas
On Sat, Jun 9, 2012 at 11:13 AM, Aaron J. Seigo ase...@kde.org wrote: interesting, I would consider gwenview part of the workspace as I think an image viewer is nowadays one of the most essential applications a user needs. 'how essential is the application' is not the measuring stick we've

Re: kde plasma workspace structure

2012-06-09 Thread Aaron J. Seigo
On Saturday, June 9, 2012 12:37:47 Martin Gräßlin wrote: There might be a misunderstanding. I do not say that we have to require OpenGL compositing, I'm saying that the stack underneath us broke for the non composited case (either XRender or OpenGL). If you want I can search for the bug

Re: kde plasma workspace structure

2012-06-09 Thread Aaron J. Seigo
On Saturday, June 9, 2012 13:11:21 Alex Fiestas wrote: On Sat, Jun 9, 2012 at 11:13 AM, Aaron J. Seigo ase...@kde.org wrote: As notmart said in one of the threads where we discussed the vision, does the user want to execute an application or what he/she wants is to read the pdf? that does not

Review Request: some cppcheck fixes

2012-06-09 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105190/ --- Review request for Plasma. Description --- 1. avoid a memory leak 2.

Re: Review Request: Plasmate: Add tabbox previewer

2012-06-09 Thread Antonis Tsiapaliokas
On June 9, 2012, 7:15 a.m., Martin Gräßlin wrote: previewer/tabbox/tabboxdelegate.qml, lines 2-3 http://git.reviewboard.kde.org/r/105139/diff/5/?file=66461#file66461line2 although if it's copied from KWin, the file is in Plasmate not part of KWin ;-) I have remote the line #2.

Re: Re: kde plasma workspace structure

2012-06-09 Thread Alex Fiestas
On Sat, Jun 9, 2012 at 12:37 PM, Martin Gräßlin mgraess...@kde.org wrote: Also from looking at the KWin source base I have to disagree about the benefits of keeping code portable. It makes the code ugly, adds additional ifdefs. Keeping the source compiled with different compiles is a good

Re: Re: kde plasma workspace structure

2012-06-09 Thread Martin Gräßlin
On Saturday 09 June 2012 13:18:04 Aaron J. Seigo wrote: On Saturday, June 9, 2012 12:37:47 Martin Gräßlin wrote: There might be a misunderstanding. I do not say that we have to require OpenGL compositing, I'm saying that the stack underneath us broke for the non composited case (either

Re: Workspace Next Sprint Organization

2012-06-09 Thread Nuno Pinheiro
Hi there! Just got back home from 2 weeks on the move, and really wont be able to attend the meeting for the days I planed But I would really like to participate in on-line meetings and discussions we can extend over on academy. Sorry but its just to much travel for one month...

QML and paths to images

2012-06-09 Thread Dmitry
Hello! I'm working on implementation of system tray in QML. Is it possible to get absolute path to icon/image/movie in QML? I need to put into QML code AnimatedImage item, but it requires a full path to a movie (animation). I have only name of movie instead of its full path. Thank you!

Re: Workspace Next Sprint Organization

2012-06-09 Thread Alex Fiestas
Too bad :/ We will have plenty webcams and micro's to do online stuff, if the gods of the internetz allow us we should have no problem on doing all kinds of online activities. ___ Plasma-devel mailing list Plasma-devel@kde.org

Review Request: improve/add keyboard navigation in kickoff-qml (mystery included)

2012-06-09 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105196/ --- Review request for Plasma and Martin Gräßlin. Description --- since

Re: Review Request: some cppcheck fixes

2012-06-09 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105190/#review14549 --- Ship it! great catches.. thanks! :) - Aaron J. Seigo On

Re: kde plasma workspace structure

2012-06-09 Thread Aaron J. Seigo
On Saturday, June 9, 2012 14:13:49 Martin Gräßlin wrote: On Saturday 09 June 2012 13:18:04 Aaron J. Seigo wrote: On Saturday, June 9, 2012 12:37:47 Martin Gräßlin wrote: There might be a misunderstanding. I do not say that we have to require OpenGL compositing, I'm saying that the stack

Re: kde plasma workspace structure

2012-06-09 Thread Aaron J. Seigo
On Saturday, June 9, 2012 14:05:15 Alex Fiestas wrote: PowerDevil - Solid::Control::Power btw, thanks to this design, i expect next week we'll drop in an Android power management backend (into a branch of course .. :) why? we got a new revision of the vivaldi hardware last month that has

Re: QML and paths to images

2012-06-09 Thread Dmitry
09.06.2012 18:39, Aaron J. Seigo пишет: On Saturday, June 9, 2012 16:27:38 Dmitry wrote: I'm working on implementation of system tray in QML. Is it possible to get absolute path to icon/image/movie in QML? I need to put into QML code AnimatedImage item, but it requires a full path to a movie

Re: Re: kde plasma workspace structure

2012-06-09 Thread Martin Gräßlin
On Saturday 09 June 2012 16:29:10 Aaron J. Seigo wrote: On Saturday, June 9, 2012 14:13:49 Martin Gräßlin wrote: On Saturday 09 June 2012 13:18:04 Aaron J. Seigo wrote: On Saturday, June 9, 2012 12:37:47 Martin Gräßlin wrote: There might be a misunderstanding. I do not say that we have

Re: QML and paths to images

2012-06-09 Thread Aaron J. Seigo
On Saturday, June 9, 2012 18:56:46 Dmitry wrote: Animations are in /usr/share/icons/theme/size and if I use C++ I'll load them using KIconLoader::loadMovie(). ah .. from icons. hm. question: is the QML implementation you are working on pure QML, or is it a mix of C++ and QML? -- Aaron J.

Re: QML and paths to images

2012-06-09 Thread Dmitry
09.06.2012 19:21, Aaron J. Seigo пишет: On Saturday, June 9, 2012 18:56:46 Dmitry wrote: Animations are in /usr/share/icons/theme/size and if I use C++ I'll load them using KIconLoader::loadMovie(). ah .. from icons. hm. question: is the QML implementation you are working on pure QML, or is

Re: Review Request: some cppcheck fixes

2012-06-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105190/#review14555 --- This review has been submitted with commit

Re: QML and paths to images

2012-06-09 Thread Marco Martin
On Saturday 09 June 2012, Aaron J. Seigo wrote: On Saturday, June 9, 2012 16:27:38 Dmitry wrote: I'm working on implementation of system tray in QML. Is it possible to get absolute path to icon/image/movie in QML? I need to put into QML code AnimatedImage item, but it requires a full path

Re: kde plasma workspace structure

2012-06-09 Thread Marco Martin
On Saturday 09 June 2012, Alex Fiestas wrote: On Sat, Jun 9, 2012 at 12:11 AM, Aaron J. Seigo ase...@kde.org wrote: On Friday, June 8, 2012 22:54:03 Alex Fiestas wrote: we have kde-baseapps, and i agree what you've said previously that wewould benefit from having a defined set of core

Re: kde plasma workspace structure

2012-06-09 Thread Marco Martin
On Saturday 09 June 2012, Aaron J. Seigo wrote: On Saturday, June 9, 2012 13:11:21 Alex Fiestas wrote: On Sat, Jun 9, 2012 at 11:13 AM, Aaron J. Seigo ase...@kde.org wrote: As notmart said in one of the threads where we discussed the vision, does the user want to execute an application or