---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116722/
---
(Updated July 29, 2014, 8:53 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119522/#review63393
---
Ship it!
Ship It!
- David Edmundson
On July 28, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119336/#review63396
---
Is this still useful?
- David Edmundson
On July 17, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119404/#review63394
---
Ship it!
- David Edmundson
On July 22, 2014, 12:09 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/101074/
---
(Updated July 29, 2014, 9:06 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115727/#review63398
---
What's the status of this. Can we at least merge this in 5.x?
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/100743/
---
(Updated July 29, 2014, 9:08 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119336/
---
(Updated July 29, 2014, 9:10 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/102905/
---
(Updated July 29, 2014, 9:11 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/107869/#review63399
---
The coding style in the entire review is off.
File
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/102464/
---
(Updated July 29, 2014, 9:26 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/105924/
---
(Updated July 29, 2014, 9:32 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/107428/
---
(Updated July 29, 2014, 9:35 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/106448/
---
(Updated July 29, 2014, 9:42 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118180/
---
(Updated July 29, 2014, 9:43 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118180/#review63401
---
Reviewboard wasn't showing the patch, not sure why. We can't
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/104603/
---
(Updated July 29, 2014, 9:45 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/101321/
---
(Updated July 29, 2014, 9:47 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110608/
---
(Updated July 29, 2014, 9:55 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110608/#review63402
---
submitted with
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/104015/
---
(Updated July 29, 2014, 9:57 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118180/
---
(Updated 七月 29, 2014, 10:04 a.m.)
Review request for kde-workspace and
On jul 28, 2014, 7:03 p.m., Mark Gaiser wrote:
If there is one hardware combination that works best on linux, it's OpenGL
+ Intel.
I find it hard to believe that GLES is better and in all cases. That must
be a driver/mesa bug that should be investigated and fixed.
If this
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118180/
---
(Updated 七月 29, 2014, 10:05 a.m.)
Review request for kde-workspace and
Sorry for flooding the mailing list.
I've spent the morning cleaning out some of Plasma's review requests.
One was nearly 4 years old.
The following reviews are for 4.x but seem to be non-invasive bug
fixes that I /think/ we should backport. I'd like a second opinion
from people more familiar
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/#review63406
---
applets/kickoff/core/krunnermodel.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/107868/#review63408
---
Jekyll, ping?
- Vishesh Handa
On Dec. 31, 2012, 7:12 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/107881/#review63407
---
Ping.
Jekyll, could you please rename the directory as Aaron
On July 29, 2014, 9:17 a.m., Vishesh Handa wrote:
File Attachment: the patch -
0002-Add-a-real-konquerorsessions-plugin_1.patch
https://git.reviewboard.kde.org/r/107869/#fcomment231
I don't really understand the whole kate comment.
I think the code was originally copied from the
On Tue, Jul 29, 2014 at 12:07 PM, David Edmundson
da...@davidedmundson.co.uk wrote:
There are a /lot/ of Plasma Media Centre reviews open (about half are
PMC), I'm not sure what the state of those is, are they awaiting
reviews from the non-media centre devs, or just no longer relevant. If
There are .tags file made for most of Qt but not for qtquickcontrols.
In order to make it work automatically we'd have to fix QtDoc first.
:(
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109711/#review63410
---
Ship it!
this should be done for both 4.x and the 5.x port
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113697/#review63412
---
Ship it!
may be pushed to 4.x
- Marco Martin
On Nov. 27,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114910/#review63413
---
this would require some testing before pushing to 4.x, too
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/105779/#review63414
---
this would need more testing at this point before eventually
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112789/#review63415
---
this engine was mostly to expose a service to send queries
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114260/#review63416
---
Ship it!
fine to go
- Marco Martin
On Feb. 21, 2014, 6:54
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109124/#review63418
---
This should definitely be ported, since i've seen many people
On Tuesday 29 July 2014, David Edmundson wrote:
Sorry for flooding the mailing list.
I've spent the morning cleaning out some of Plasma's review requests.
One was nearly 4 years old.
good stuff.
on the list of reviews you posted, i commented on them, separing those that i
think could be
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119404/
---
(Updated July 29, 2014, 11:05 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112789/
---
(Updated July 29, 2014, 4:54 p.m.)
Status
--
This change has been
On June 5, 2014, 1:58 a.m., Marco Martin wrote:
what is the stuff that still needs kdelibs4support? it shouldn't depend on
it anymore
Eric Hameleers wrote:
Files in the subdirectories of kcms/kfintinst/ contain includes for stuff
that I can only find in kdelibs4support. Like
Hello,
On Tue, Jul 29, 2014 at 3:37 PM, David Edmundson
da...@davidedmundson.co.uk wrote:
There are a /lot/ of Plasma Media Centre reviews open (about half are
PMC), I'm not sure what the state of those is, are they awaiting
reviews from the non-media centre devs, or just no longer relevant.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117139/#review63426
---
Ping, what is status on this?
- Bhushan Shah
On March 28,
This one needs to be discarded as well,
https://git.reviewboard.kde.org/r/115865/
On Tue, Jul 29, 2014 at 5:15 PM, Bhushan Shah bhus...@gmail.com wrote:
Hello,
On Tue, Jul 29, 2014 at 3:37 PM, David Edmundson
da...@davidedmundson.co.uk wrote:
There are a /lot/ of Plasma Media Centre
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118866/#review63427
---
ping?
- Bhushan Shah
On June 21, 2014, 11:13 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116460/
---
(Updated July 29, 2014, 12:10 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116804/
---
(Updated July 29, 2014, 12:10 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116731/
---
(Updated July 29, 2014, 12:10 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115865/
---
(Updated July 29, 2014, 12:11 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119534/
---
Review request for KDE Frameworks and Plasma.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118866/
---
(Updated July 29, 2014, 12:35 p.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114428/#review63431
---
Ping, whats status on this? can this be submitted?
- Bhushan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116898/#review63432
---
Ping, I think this can be closed.
- Bhushan Shah
On March
On Tue, Jul 29, 2014 at 5:15 PM, Bhushan Shah bhus...@gmail.com wrote:
Following PMC reviews needs to be discarded,
Some more,
https://git.reviewboard.kde.org/r/114055/ - code is already in repo
Non PMC,
https://git.reviewboard.kde.org/r/117681/ - no review so far
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114055/
---
(Updated July 29, 2014, 12:53 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119175/
---
(Updated July 29, 2014, 12:54 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111849/
---
(Updated July 29, 2014, 12:57 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116898/
---
(Updated July 29, 2014, 1:19 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119535/
---
Review request for Plasma.
Repository: kdeclarative
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119534/
---
(Updated July 29, 2014, 1:25 p.m.)
Review request for KDE Frameworks and
Some more,
https://git.reviewboard.kde.org/r/118540/ - Already in codebase
https://git.reviewboard.kde.org/r/105319/ - No activity so far
https://git.reviewboard.kde.org/r/105932/ - No activity and can't be
applied on top of plasma 5
https://git.reviewboard.kde.org/r/106123/ - No activity and 4.8
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118540/
---
(Updated July 29, 2014, 1:29 p.m.)
Status
--
This change has been
On July 28, 2014, 6:25 p.m., Eike Hein wrote:
Can you recompile plasma-desktop with OpenGL ES and test if the drag pixmap
for Folder icons works?
I wrote the code in a way that ought to work on both desktop GL and ES, but
it's worth testing.
Aleix Pol Gonzalez wrote:
I have
Either way this patch no longer applies.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119524/#review63437
---
Ship it!
I'm all for this, as it means we reduce the set of
On July 29, 2014, 2:01 p.m., Sebastian Kügler wrote:
I'm all for this, as it means we reduce the set of features we use from the
underlying stack. We're even focusing on the features that will get more
testing (since it's mobile, and that's the hype). I consider it an
advantage if we
On July 29, 2014, 2:01 p.m., Sebastian Kügler wrote:
I'm all for this, as it means we reduce the set of features we use from the
underlying stack. We're even focusing on the features that will get more
testing (since it's mobile, and that's the hype). I consider it an
advantage if we
On July 29, 2014, 2:01 p.m., Sebastian Kügler wrote:
I'm all for this, as it means we reduce the set of features we use from the
underlying stack. We're even focusing on the features that will get more
testing (since it's mobile, and that's the hype). I consider it an
advantage if we
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118180/
---
(Updated 七月 29, 2014, 2:15 p.m.)
Review request for kde-workspace and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119535/
---
(Updated July 29, 2014, 2:31 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119535/#review63441
---
Can we consider including this in KCoreAddons?
I know
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119535/#review63443
---
Looks damn good, especially the documentation and example.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118180/
---
(Updated 七月 29, 2014, 3:19 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118180/
---
(Updated July 29, 2014, 3:24 p.m.)
Review request for kde-workspace and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118180/#review63445
---
weird issue when using reviewboard with the chrome. that why
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119524/
---
(Updated July 29, 2014, 4:15 p.m.)
Status
--
This change has been
See http://build.kde.org/job/plasma-workspace_master_qt5/678/changes
Changes:
[aleixpol] Force OpenGLES when running on Qt 5.4
--
[...truncated 1265 lines...]
Generating moc_fakebacktracegenerator.cpp
[ 22%] Built target backtraceparsertest_automoc
[ 22%]
On July 29, 2014, 2:33 p.m., Aleix Pol Gonzalez wrote:
Can we consider including this in KCoreAddons?
I know KCoreAddons should only depend on QtCore, but then we can make it an
optional dependency. If Qt5::Qml is there, then build the Qml plugin too.
KCoreAddons can depend from
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119535/#review63453
---
src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp
See http://build.kde.org/job/plasma-workspace_master_qt5/679/changes
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
On July 29, 2014, 2:33 p.m., Aleix Pol Gonzalez wrote:
Can we consider including this in KCoreAddons?
I know KCoreAddons should only depend on QtCore, but then we can make it an
optional dependency. If Qt5::Qml is there, then build the Qml plugin too.
Marco Martin wrote:
On July 29, 2014, 4:34 p.m., Bhushan Shah wrote:
src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 44
https://git.reviewboard.kde.org/r/119535/diff/1/?file=294241#file294241line44
Maybe consider creating it a singleton type?
Why? In fact, I think it's usually harder to deal
On July 29, 2014, 2:33 p.m., Aleix Pol Gonzalez wrote:
Can we consider including this in KCoreAddons?
I know KCoreAddons should only depend on QtCore, but then we can make it an
optional dependency. If Qt5::Qml is there, then build the Qml plugin too.
Marco Martin wrote:
On July 29, 2014, 10:04 p.m., Bhushan Shah wrote:
src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 44
https://git.reviewboard.kde.org/r/119535/diff/1/?file=294241#file294241line44
Maybe consider creating it a singleton type?
Aleix Pol Gonzalez wrote:
Why? In fact, I
On Tuesday 29 July 2014, Aleix Pol wrote:
khintsettings should do something along the lines:
* with some heuristics access the lookandfeel package (it's only a folder
after all, wouldn't be very difficult) and open a config file with
default icons/widget style etc
* read the default if
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119535/#review63459
---
src/qmlcontrols/kcoreaddons/kuserproxy.h
On Июль 29, 2014, 2:31 п.п., Marco Martin wrote:
this would require some testing before pushing to 4.x, too delicate to just
commit
Well, I've been living with this patch for half a year already, since January 8
:) I used it with a number of KDE 4.x versions from 4.11.3 to 4.13.1 (coming
On July 29, 2014, 10:31 a.m., Marco Martin wrote:
this would require some testing before pushing to 4.x, too delicate to just
commit
Dmitry Ivanov wrote:
Well, I've been living with this patch for half a year already, since
January 8 :) I used it with a number of KDE 4.x versions
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114910/#review63466
---
Ship it!
Ship It!
- Marco Martin
On Jan. 8, 2014, 4:25
On July 29, 2014, 4:53 p.m., Bhushan Shah wrote:
src/qmlcontrols/kcoreaddons/kuserproxy.h, line 96
https://git.reviewboard.kde.org/r/119535/diff/1/?file=294242#file294242line96
why? nameChanged is not related here..
It's not visible API (the signal visible to QML has the name of
On July 29, 2014, 4:34 p.m., Bhushan Shah wrote:
src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 44
https://git.reviewboard.kde.org/r/119535/diff/1/?file=294241#file294241line44
Maybe consider creating it a singleton type?
Aleix Pol Gonzalez wrote:
Why? In fact, I
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119535/
---
(Updated July 29, 2014, 6:04 p.m.)
Review request for KDE Frameworks and
On jul. 29, 2014, 5:12 p.m., Marco Martin wrote:
Ship It!
Marco, Dmitry doesn't have an account, can you please push this to 4.11?
- Albert
---
This is an automatically generated e-mail. To reply, visit:
On Monday 28 July 2014 15:46:56 Aleix Pol wrote:
From the wiki: [1]
Do we need special powers to change these?
Aleix
[1] And add this option in the configuraiotn of your CI build:
http://quickgit.kde.org/?p=websites%2Fbuild-kde-org. [DEFAULT]
configureExtraArgs=-DBUILD_COVERAGE=ON
Yes,
95 matches
Mail list logo
