Re: Moving repositories in the module structure

2014-10-04 Thread Ben Cooksley
On Fri, Oct 3, 2014 at 11:33 AM, Víctor Blázquez victor.blazq...@kde.org wrote: I'm sorry for doing the move that fast, I should have realized it was sent only to plasma-devel No worries - in virtually all cases it is fine to process requests when we receive them. Víctor Blázquez Thanks,

Re: Moving repositories in the module structure

2014-10-04 Thread Ben Cooksley
On Fri, Oct 3, 2014 at 2:28 PM, Aleix Pol aleix...@kde.org wrote: On Fri, Oct 3, 2014 at 1:52 AM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 3 d'octubre de 2014, a les 00:04:42, Aleix Pol va escriure: On Thu, Oct 2, 2014 at 11:34 PM, Ben Cooksley bcooks...@kde.org wrote: Hi all,

Review Request 120489: Hide PrograssBar inner item when value is 0

2014-10-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120489/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 120489: Hide PrograssBar inner item when value is 0

2014-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120489/#review67930 --- Your branch name in the review request doesn't make much

Re: Review Request 120489: Hide PrograssBar inner item when value is 0

2014-10-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120489/ --- (Updated Okt. 4, 2014, 8:27 nachm.) Review request for Plasma. Changes

Review Request 120491: Add indeterminate ProgressBar to test

2014-10-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120491/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 120489: Hide PrograssBar inner item when value is 0

2014-10-04 Thread Kai Uwe Broulik
On Okt. 4, 2014, 8:20 nachm., David Edmundson wrote: Your branch name in the review request doesn't make much sense, we're in frameworks here. There's a test file tests/components/progressbar.qml can you run that and check things still all look OK. (btw, if you *want* you can

Re: Review Request 120489: Hide PrograssBar inner item when value is 0

2014-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120489/#review67932 --- Ship it! Ship It! - David Edmundson On Oct. 4, 2014, 8:27

Re: Review Request 120491: Add indeterminate ProgressBar to test

2014-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120491/#review67933 --- Ship it! Ship It! - David Edmundson On Oct. 4, 2014, 8:29

Re: Review Request 120491: Add indeterminate ProgressBar to test

2014-10-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120491/ --- (Updated Oct. 4, 2014, 8:41 p.m.) Status -- This change has been

Re: Review Request 120489: Hide PrograssBar inner item when value is 0

2014-10-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120489/ --- (Updated Oct. 4, 2014, 8:42 p.m.) Status -- This change has been

Dark themes

2014-10-04 Thread Andrew Lake
Hello all, I just realized that in pushing the Breeze Dark color scheme to the Plasma/5.1 branch of the breeze repo, it likely violates the string freeze (the name of the color scheme). So when I pushed the new Breeze Dark icon theme I only pushed it to master since the icon theme name and

Re: Dark themes

2014-10-04 Thread Eike Hein
On 05.10.2014 00:29, Andrew Lake wrote: C. Further violate the string freeze by pushing the Breeze Dark icon theme to the Plasma/5.1 branch to provide a remedy for the icon visibility issues with dark application color schemes and with the I don't think violating string freeze is critical

Re: Dark themes

2014-10-04 Thread Andrew Lake
On Sat, Oct 4, 2014 at 3:35 PM, Eike Hein wrote: On 05.10.2014 00:29, Andrew Lake wrote: C. Further violate the string freeze by pushing the Breeze Dark icon theme to the Plasma/5.1 branch to provide a remedy for the icon visibility issues with dark application color schemes and with the

Re: Dark themes

2014-10-04 Thread David Edmundson
Thanks much Eike. I'll make the request for an exception if there are no objections to option C from others here. No objections from me. We may as well ask translators anyway. If they say no then we'll at least know what our options are. David ___

Re: Dark themes

2014-10-04 Thread Eike Hein
On 05.10.2014 00:49, Andrew Lake wrote: Thanks much Eike. I'll make the request for an exception if there are no objections to option C from others here. And thanks for the theme work, btw - big fan of the Dark versions :) Much respect, Andrew Cheers, Eike