Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect when close window in group item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128038/ --- (Updated Юни 3, 2016, 7:41 след обяд) Review request for Plasma and Eike

[Differential] [Updated, 832 lines] D1670: New login screen

davidedmundson updated this revision to Diff 4198. davidedmundson added a comment. changes REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1670?vs=4008=4198 BRANCH login REVISION DETAIL https://phabricator.kde.org/D1670 AFFECTED

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

https://bugs.kde.org/show_bug.cgi?id=340063 S changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

https://bugs.kde.org/show_bug.cgi?id=340063 --- Comment #11 from S --- Thanks for the reply. Does something need to be done to enable this? -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel

[Differential] [Commented On] D1724: Import Task Manager widgets ports to the new library.

lbeltrame added a comment. Tested with multiscreen, and found a bug already. ;) Not sure if it's in libtm or in the applets: but if you move a window to another screen, the corresponding task will not get updated until I minimize the task. IOW: - 2 task managers, one in screen 1,

[Differential] [Commented On] D1724: Import Task Manager widgets ports to the new library.

lbeltrame added a comment. Second multiscreen issue found: right clicking to get the menu from a task gets the task in the wrong screen. Screenshot attached. F142172: Screenshot_20160603_190335.png It's also wrong for tasks in the same screen:

[Breeze] [Bug 363811] window titlebar too large

https://bugs.kde.org/show_bug.cgi?id=363811 Hugo Pereira Da Costa changed: What|Removed |Added CC|

[Differential] [Commented On] D1724: Import Task Manager widgets ports to the new library.

lbeltrame added a comment. Tested it on a single screen system. No issues with context menus. Notice: I don't see jump lists with the new task manager, should I see them? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1724 EMAIL PREFERENCES

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

https://bugs.kde.org/show_bug.cgi?id=340063 --- Comment #10 from Kai Uwe Broulik --- It fades 8 seconds before actually turning off, so you can still prevent the screen from turning off by wiggling the mouse. -- You are receiving this mail because: You are the assignee

[Differential] [Updated, 9,409 lines] D1722: Import next-gen libtaskmanager.

hein updated this revision to Diff 4180. hein added a comment. Wipe app data caches on KSycoca changes and emit data changes. This means e.g. launcher and window buttons will get new icons when the icon is changed via kmenuedit. This is probably the first time ever this has worked in

[Differential] [Commented On] D1748: [KCM Keyboard] Delay initializing mouse

drosca added a comment. In https://phabricator.kde.org/D1748#32567, @graesslin wrote: > Why is udev used here at all? On X11 we should use XInput, on Wayland hopefully nothing, because KWin takes care of it. It is used only when xcb-xinput is not available (Debian/Ubuntu, ...).

[Differential] [Requested Changes To] D1722: Import next-gen libtaskmanager.

graesslin requested changes to this revision. graesslin added a reviewer: graesslin. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > waylandtasksmodel.cpp:115-119 > +KService::Ptr service = KService::serviceByStorageId(window->appId()); > + >

[Differential] [Request, 28 lines] D1758: Integrated FakeInput touch events into InputRedirection.

bdhruve created this revision. bdhruve added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KWin counterpart for touch event support in Fakeinput interface. REPOSITORY rKWIN KWin BRANCH

[Differential] [Accepted] D1737: [Desktop Containment] Remove debug elements

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1737 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Closed] D1752: [Panel Configuration] Disallow pressing Escape whilst manipulating panel

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPad1313fe277f: [Panel Configuration] Disallow pressing Escape whilst manipulating panel (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Request, 74 lines] D1757: [Panel] Reduce duplicate enabled borders calculation

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead of calculating them

[Differential] [Commented On] D1757: [Panel] Reduce duplicate enabled borders calculation

broulik added inline comments. INLINE COMMENTS > Panel.qml:29 > + > +//onPrefixChanged: adjustBorders(); > onRepaintNeeded: adjustPrefix(); Dunno if we still need this, ie. if we need a way to signal this back to cpp > Panel.qml:32 > > -visible: false //adjust borders is run

[Differential] [Accepted] D1722: Import next-gen libtaskmanager.

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. I think this is good to go. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1722 EMAIL PREFERENCES

Re: Review Request 128069: Added keyboard shortcuts to Sticky Notes

> On Iunie 3, 2016, 3:19 p.m., David Edmundson wrote: > > Do you have commit access? I do. I received commit access some time ago to help with the localization effort. - Viorel-Cătălin --- This is an automatically generated e-mail. To

Re: Review Request 128069: Added keyboard shortcuts to Sticky Notes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128069/#review96167 --- Ship it! Ship It! - David Edmundson On June 1, 2016,

Re: Review Request 128069: Added keyboard shortcuts to Sticky Notes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128069/#review96168 --- Do you have commit access? - David Edmundson On June 1,

Re: Review Request 128069: Added keyboard shortcuts to Sticky Notes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128069/ --- (Updated Iunie 3, 2016, 4:08 p.m.) Status -- This change has been

[Differential] [Updated] D1735: Notify about low peripheral batteries (mouse, keyboard)

broulik updated the summary for this revision. REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D1735 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: colomar, lueck, graesslin,

[Differential] [Updated] D1721: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite.

lbeltrame added a comment. Doesn't build here: /home/abuild/rpmbuild/BUILD/plasma-workspace-5.6.90git~20160602T115930~https://phabricator.kde.org/rPLASMAWORKSPACE0d0c4f4a2247e8213deb232d2d80f12480dc05aa/libtaskmanager/taskgroupingproxymodel.cpp:40:19: error: field 'blacklistedAppIds'

[Differential] [Updated] D1722: Import next-gen libtaskmanager.

lbeltrame added a comment. Doesn't build here (posted to https://phabricator.kde.org/D1722 by mistake):

[Differential] [Requested Changes To] D1722: Import next-gen libtaskmanager.

lbeltrame requested changes to this revision. lbeltrame added a reviewer: lbeltrame. lbeltrame added a comment. This revision now requires changes to proceed. --- libtaskmanager/taskgroupingproxymodel.cpp.orig 2016-06-03 14:45:46.798676712 +0200 +++

[Differential] [Updated] D1722: Import next-gen libtaskmanager.

hein marked 11 inline comments as done. hein added inline comments. INLINE COMMENTS > graesslin wrote in waylandtasksmodel.cpp:115-119 > at the point of adding a window you can be quite sure that the appId is not > yet pushed. Maybe we should introduce a dedicated event in the protocol to >

[Differential] [Request, 214 lines] D1753: [client] Detect errors in ConnectionThread

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY So far ConnectionThread dispatched events without checking for (protocol) errors. But Wayland errors

[Differential] [Request, 36 lines] D1755: [server] Trigger error if a transient request tries to parent to itself

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If the surface passed in the transient request is to the surface of the shell surface, KWin aborts.

[Differential] [Updated] D1755: [server] Trigger error if a transient request tries to parent to itself

graesslin added a dependency: D1753: [client] Detect errors in ConnectionThread. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1755 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma Cc: plasma-devel, sebas

[Differential] [Updated] D1753: [client] Detect errors in ConnectionThread

graesslin added a dependent revision: D1755: [server] Trigger error if a transient request tries to parent to itself. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1753 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 12 lines] D1752: [Panel Configuration] Disallow pressing Escape whilst manipulating panel

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When dragging the panel

[Differential] [Updated, 9,400 lines] D1722: Import next-gen libtaskmanager.

hein updated this revision to Diff 4182. hein marked 11 inline comments as done. hein added a comment. Addressed Martin's comments. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1722?vs=4180=4182 BRANCH importlibtmng REVISION

[Differential] [Accepted] D1752: [Panel Configuration] Disallow pressing Escape whilst manipulating panel

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1752 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated, 4,664 lines] D1723: Rename Task Manager applets out of the way of rewrites.

hein updated this revision to Diff 4185. hein added a comment. Rebased against master to enable OBS packaging. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1723?vs=4084=4185 BRANCH master REVISION DETAIL

[Differential] [Request, 106 lines] D1756: [PanelView] Expose enabled borders as property and also forward it to PanelShadows

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I noticed that panels

[Breeze] [Bug 363602] Symlinked SVG files fails to load under Windows

https://bugs.kde.org/show_bug.cgi?id=363602 Dan Jensen changed: What|Removed |Added CC||ad...@leinir.dk --- Comment #5

[Differential] [Commented On] D1748: [KCM Keyboard] Delay initializing mouse

graesslin added a comment. In https://phabricator.kde.org/D1748#32573, @drosca wrote: > In https://phabricator.kde.org/D1748#32567, @graesslin wrote: > > > Why is udev used here at all? On X11 we should use XInput, on Wayland hopefully nothing, because KWin takes care of it. > >

[Differential] [Accepted] D1760: Don't setup PlasmaWindowManagement integration for lock screen windows

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH no-plasma-window-lock-screen REVISION DETAIL https://phabricator.kde.org/D1760 EMAIL PREFERENCES

[Differential] [Closed] D1758: Integrated FakeInput touch events into InputRedirection.

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN6cae5f7ab925: Integrated FakeInput touch events into InputRedirection. (authored by bdhruve). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1758?vs=4190=4194

[Differential] [Closed] D1759: Restrict when to expose a ShellClient to PlasmaWindowManagement

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN5d396add1238: Restrict when to expose a ShellClient to PlasmaWindowManagement (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1760: Don't setup PlasmaWindowManagement integration for lock screen windows

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN76de85b44953: Don't setup PlasmaWindowManagement integration for lock screen windows (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

Review Request 128089: [Quick Chat] Add context menu for copying text and links

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128089/ --- Review request for Plasma and KDE Usability. Repository:

[Differential] [Request, 65 lines] D1760: Don't setup PlasmaWindowManagement integration for lock screen windows

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We don't want external processes to know anything about the lock screen windows. Especially we don't

[Differential] [Updated] D1759: Restrict when to expose a ShellClient to PlasmaWindowManagement

graesslin added a dependent revision: D1760: Don't setup PlasmaWindowManagement integration for lock screen windows. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1759 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin,

[Differential] [Updated] D1760: Don't setup PlasmaWindowManagement integration for lock screen windows

graesslin added a dependency: D1759: Restrict when to expose a ShellClient to PlasmaWindowManagement. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1760 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma Cc:

[Differential] [Accepted] D1758: Integrated FakeInput touch events into InputRedirection.

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH fakeinput-touch REVISION DETAIL https://phabricator.kde.org/D1758 EMAIL PREFERENCES