[Differential] [Request, 2 lines] D2842: Add kinfocenter to the computer tab of Kickoff

2016-09-22 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 368080 REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL

Re: Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128997/ --- (Updated Sept. 23, 2016, 1:05 a.m.) Status -- This change has been

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 363 - Still Failing!

2016-09-22 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/363/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 23 Sep 2016 01:17:55 + Build duration: 3 min 34 sec CHANGE SET No changes

[Differential] [Updated, 8 lines] D2843: Fix method that calls itself recursively

2016-09-22 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 6889. davidedmundson added a comment. fix phab getting excited REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2843?vs=6888=6889 BRANCH master REVISION DETAIL

[Differential] [Closed] D2836: Enable high DPI support in KCMShell

2016-09-22 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rKDECLITOOLS91dd63abce3e: Enable high DPI support in KCMShell (authored by davidedmundson). REPOSITORY rKDECLITOOLS KDE CLI Utilities CHANGES SINCE LAST UPDATE

[Differential] [Request, 1 line] D2841: Don't load system apps model twice

2016-09-22 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The system apps model is set from QML via ComputerModel::setSystemApplications This is

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 361 - Still Unstable!

2016-09-22 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/361/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 23 Sep 2016 00:44:42 + Build duration: 9 min 34 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 362 - Failure!

2016-09-22 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/362/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 23 Sep 2016 01:08:32 + Build duration: 2 min 36 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 364 - Fixed!

2016-09-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/364/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 23 Sep 2016 01:24:24 + Build duration: 8 min 46 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 364 - Fixed!

2016-09-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/364/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 23 Sep 2016 01:24:24 + Build duration: 8 min 46 sec CHANGE SET No changes JUNIT RESULTS

[Differential] [Request, 17 lines] D2843: Fix method that calls itself recursively

2016-09-22 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Read the code. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL

[Differential] [Accepted] D2836: Enable high DPI support in KCMShell

2016-09-22 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKDECLITOOLS KDE CLI Utilities BRANCH master REVISION DETAIL https://phabricator.kde.org/D2836 EMAIL PREFERENCES

[Differential] [Accepted] D2838: Fix memory leak + cleanup in projecthandlertest

2016-09-22 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMASDK Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org/D2838 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Closed] D2838: Fix memory leak + cleanup in projecthandlertest

2016-09-22 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMASDKb78aceee04f4: Fix memory leak + cleanup in projecthandlertest (authored by davidedmundson). REPOSITORY rPLASMASDK Plasma SDK CHANGES SINCE LAST UPDATE

Discover requires Qt 5.7?

2016-09-22 Thread Daniel Vrátil
Hi, Discover 5.7.95 requires Qt 5.7 due to usage of qAsConst() [0], although CMakeLists.txt claims Qt 5.2 is required (which seems to be too low anyway). Can you please either replace qAsConst() with const_cast or bump the Qt dependency? Thanks, Dan [0]

[Differential] [Accepted] D2832: [plasma-pa] Set NotificationAreaCategory to Hardware

2016-09-22 Thread drosca (David Rosca)
drosca accepted this revision. drosca added a reviewer: drosca. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D2832 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, drosca Cc:

[Differential] [Request, 87 lines] D2833: Quicklaunch: Add support for jumplist actions

2016-09-22 Thread drosca (David Rosca)
drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D2833 AFFECTED FILES

Re: Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-22 Thread Marco Martin
> On Sept. 21, 2016, 11:42 p.m., David Edmundson wrote: > > appmenu/appmenu.cpp, line 90 > > > > > > what's with this change? > > Aleix Pol Gonzalez wrote: > The warning was saying that it's a delete of

[Differential] [Accepted] D2829: Add description for volume applet

2016-09-22 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D2829 EMAIL PREFERENCES

Looking to contribute - Porting appmenu to QMenuModel

2016-09-22 Thread Matija Čupić
Heya everyone, I'm looking to contribute to KDE. I'm not new to programming (just new to Qt, KDE), and not asking for handholding, but if someone could strap me up with info on how to start, how would I test my additions/fixes, and what's the procedure for submitting updates, that would be

Review Request 128999: Add removeMenuItem to PlasmaComponents.ContextMenu

2016-09-22 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128999/ --- Review request for Plasma. Repository: plasma-framework Description

[Differential] [Commented On] D2820: Updating the wallpaper cache only when the configuration file settles

2016-09-22 Thread Ivan Čukić
ivan added a comment. The timer is here so that we don't react if a couple of changes happen one after another, and go over the config to extract the wallpapers (just like having delayed config syncs in the fist place). While config (when shared) reloading is fast, going through the

Re: Discover requires Qt 5.7?

2016-09-22 Thread Marco Martin
On Thursday 22 September 2016 10:58:42 Harald Sitter wrote: > Dropping qasconst won't help. Discover wants kirigami master which > uses qtquickcontrols2 templates which IIRC was only introduced in Qt > 5.7, so discover needs 5.7 through kirigami I think. no, kirigami master doesn't use

Re: Looking to contribute - Porting appmenu to QMenuModel

2016-09-22 Thread Marco Martin
On Thursday 22 September 2016 11:59:59 Matija Čupić wrote: > Heya everyone, > > I'm looking to contribute to KDE. I'm not new to programming (just new to > Qt, KDE), and not asking for handholding, but if someone could strap me up > with info on how to start, how would I test my additions/fixes,

[Differential] [Updated, 10 lines] D2830: ApplicationWindow.bannerPressed signal

2016-09-22 Thread apol (Aleix Pol Gonzalez)
apol updated this revision to Diff 6868. apol added a comment. bannerClicked REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2830?vs=6864=6868 BRANCH arcpatch-D2830 REVISION DETAIL https://phabricator.kde.org/D2830 AFFECTED FILES

Re: Discover requires Qt 5.7?

2016-09-22 Thread Harald Sitter
Dropping qasconst won't help. Discover wants kirigami master which uses qtquickcontrols2 templates which IIRC was only introduced in Qt 5.7, so discover needs 5.7 through kirigami I think. On Thu, Sep 22, 2016 at 10:20 AM, Daniel Vrátil wrote: > Hi, > > Discover 5.7.95 requires

[Differential] [Commented On] D2830: ApplicationWindow.bannerPressed signal

2016-09-22 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > GlobalDrawer.qml:189 > + */ > +signal bannerPressed() > + bannerClicked() REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2830 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Request, 1 line] D2832: [plasma-pa] Set NotificationAreaCategory to Hardware

2016-09-22 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Volume controls is a hardware setting and it's also what KMix does. TEST PLAN Unchecking

Re: Discover requires Qt 5.7?

2016-09-22 Thread Aleix Pol
On Thu, Sep 22, 2016 at 10:20 AM, Daniel Vrátil wrote: > Hi, > > Discover 5.7.95 requires Qt 5.7 due to usage of qAsConst() [0], although > CMakeLists.txt claims Qt 5.2 is required (which seems to be too low anyway). > > Can you please either replace qAsConst() with const_cast or

Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128949/#review99427 --- Ship it! Do you have commit access? - David Edmundson

[Differential] [Accepted] D2831: Introduce an action to display what we're showing in the menu

2016-09-22 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKIRIGAMI Kirigami BRANCH arcpatch-D2831 REVISION DETAIL https://phabricator.kde.org/D2831 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart

[Differential] [Closed] D2830: ApplicationWindow.bannerPressed signal

2016-09-22 Thread apol (Aleix Pol Gonzalez)
This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI4ec2ddb5eadd: ApplicationWindow.bannerPressed signal (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2830?vs=6868=6872#toc REPOSITORY rKIRIGAMI Kirigami CHANGES

[Differential] [Request, 26 lines] D2834: Prefer wallpapers with same aspect ratio as screen

2016-09-22 Thread antlarr (Antonio Larrosa Jimenez)
antlarr created this revision. antlarr added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The default wallpaper method is to scale the wallpaper, and the previous algorithm in plasma choosed the

Re: Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-22 Thread Aleix Pol Gonzalez
> On Sept. 22, 2016, 1:42 a.m., David Edmundson wrote: > > appmenu/appmenu.cpp, line 90 > > > > > > what's with this change? > > Aleix Pol Gonzalez wrote: > The warning was saying that it's a delete of

Re: Discover requires Qt 5.7?

2016-09-22 Thread Jonathan Riddell
On Thu, Sep 22, 2016 at 01:02:45PM +0200, Aleix Pol wrote: > On Thu, Sep 22, 2016 at 10:20 AM, Daniel Vrátil wrote: > > Hi, > > > > Discover 5.7.95 requires Qt 5.7 due to usage of qAsConst() [0], although > > CMakeLists.txt claims Qt 5.2 is required (which seems to be too low

[Differential] [Closed] D2831: Introduce an action to display what we're showing in the menu

2016-09-22 Thread apol (Aleix Pol Gonzalez)
This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI3838bf052a47: Introduce an action to display what we're showing in the menu (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE

Re: Discover requires Qt 5.7?

2016-09-22 Thread Marco Martin
On Thursday 22 September 2016 14:42:04 Matthias Klumpp wrote: > One addition: If Kirigami is missing on the system, Discover will > build but simply crash on startup - so, we should make the application > handle this case better (= not crash) or simply depend on Kirigami at > build-time, so people

Re: Review Request 128999: Add removeMenuItem to PlasmaComponents.ContextMenu

2016-09-22 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128999/#review99412 --- src/declarativeimports/plasmacomponents/qmenu.cpp (line

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

2016-09-22 Thread John Salatas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128402/ --- (Updated Sept. 22, 2016, 12:36 p.m.) Status -- This change has been

[Differential] [Updated] D2830: ApplicationWindow.bannerPressed signal

2016-09-22 Thread apol (Aleix Pol Gonzalez)
apol marked an inline comment as done. apol added a comment. fixed REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2830 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel, apol

[Differential] [Updated, 12 lines] D2831: Introduce an action to display what we're showing in the menu

2016-09-22 Thread apol (Aleix Pol Gonzalez)
apol updated this revision to Diff 6870. apol added a comment. property name REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2831?vs=6865=6870 BRANCH arcpatch-D2831 REVISION DETAIL https://phabricator.kde.org/D2831 AFFECTED FILES

[Differential] [Accepted] D2830: ApplicationWindow.bannerPressed signal

2016-09-22 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKIRIGAMI Kirigami BRANCH arcpatch-D2830 REVISION DETAIL https://phabricator.kde.org/D2830 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart

Re: Discover requires Qt 5.7?

2016-09-22 Thread Matthias Klumpp
2016-09-22 13:15 GMT+02:00 Jonathan Riddell : > On Thu, Sep 22, 2016 at 01:02:45PM +0200, Aleix Pol wrote: >> On Thu, Sep 22, 2016 at 10:20 AM, Daniel Vrátil wrote: >> > Hi, >> > >> > Discover 5.7.95 requires Qt 5.7 due to usage of qAsConst() [0], although >> >

Re: Discover requires Qt 5.7?

2016-09-22 Thread Matthias Klumpp
2016-09-22 14:36 GMT+02:00 Matthias Klumpp : > 2016-09-22 13:15 GMT+02:00 Jonathan Riddell : >> On Thu, Sep 22, 2016 at 01:02:45PM +0200, Aleix Pol wrote: >>> On Thu, Sep 22, 2016 at 10:20 AM, Daniel Vrátil wrote: >>> > Hi, >>> > >>> >

Re: Looking to contribute - Porting appmenu to QMenuModel

2016-09-22 Thread David Edmundson
On Thu, Sep 22, 2016 at 10:59 AM, Matija Čupić wrote: > Heya everyone, > > I'm looking to contribute to KDE. I'm not new to programming (just new to > Qt, KDE), and not asking for handholding, but if someone could strap me up > with info on how to start, how would I test my

[Differential] [Commented On] D2835: add a temporary timer

2016-09-22 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. have you seen Aleix's timing stuff in p-f? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2835 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc:

Re: Looking to contribute - Porting appmenu to QMenuModel

2016-09-22 Thread Matija Čupić
At the moment, I don't, but it won't be a problem at all. There's loads of info in the wiki. I don't have the time to set it up right now, I'll do it later. I guess I could port the client to QMenuModel without much trouble, the QPT part is totally unknown to me though. On Thu, Sep 22, 2016 at

[Differential] [Updated] D2835: add a temporary timer

2016-09-22 Thread mart (Marco Martin)
mart added a reviewer: Plasma. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2835 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,

Re: Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128997/#review99422 --- Ship it! - David Edmundson On Sept. 21, 2016, 11:36

[Differential] [Request, 7 lines] D2835: add a temporary timer

2016-09-22 Thread mart (Marco Martin)
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY purely for testing purposes (and testing the cache), add some debug output that prints how many milliseconds elapsed since the corona was

Re: Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-22 Thread David Edmundson
> On Sept. 21, 2016, 11:42 p.m., David Edmundson wrote: > > appmenu/appmenu.cpp, line 90 > > > > > > what's with this change? > > Aleix Pol Gonzalez wrote: > The warning was saying that it's a delete of

[Differential] [Commented On] D2835: add a temporary timer

2016-09-22 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D2835#52790, @davidedmundson wrote: > have you seen Aleix's timing stuff in p-f? i don't think it's really useful anymore, as in plasma-framework just tracks how long it takes to build the corona/containments/applets, which is

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.

2016-09-22 Thread Joshua Noack
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126524/ --- (Updated Sept. 22, 2016, 3:56 p.m.) Status -- This change has been

Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback

2016-09-22 Thread Pascal VITOUX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128949/ --- (Updated Sept. 22, 2016, 7:24 p.m.) Status -- This change has been

Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback

2016-09-22 Thread Pascal VITOUX
> On sep. 22, 2016, 8:53 après-midi, David Edmundson wrote: > > Do you have commit access? No I don't. - Pascal --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128949/#review99427

Re: Review Request 119575: Fix krunner contacts pllugin

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119575/#review99442 --- Closing as this review request is more than 2 years old. If

Re: Review Request 119575: Fix krunner contacts pllugin

2016-09-22 Thread Marc Deop
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119575/ --- (Updated Sept. 22, 2016, 8:31 p.m.) Status -- This change has been

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2016-09-22 Thread Heena Mahour
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114428/ --- (Updated Sept. 22, 2016, 8:32 p.m.) Status -- This change has been

Re: Review Request 119990: Fix libraries and includes to follow the KF5 naming scheme

2016-09-22 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119990/ --- (Updated Sept. 22, 2016, 8:31 p.m.) Status -- This change has been

Re: Review Request 111770: Implemented search feature in Local Browsing.

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111770/#review99443 --- Closing as this review request is more than 2 years old. If

Re: Review Request 103101: Add a groupingstrategy to automatically group tasks that are grouped using kwin's windowtabbing

2016-09-22 Thread Anton Kreuzkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/103101/ --- (Updated Sept. 22, 2016, 8:34 p.m.) Status -- This change has been

Re: Review Request 102727: quicklaunch: Add a confirmation dialog before the delete

2016-09-22 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102727/ --- (Updated Sept. 22, 2016, 8:34 p.m.) Status -- This change has been

Re: Review Request 105932: Fix for Bug 165792 - Allow multirow panels

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105932/#review99454 --- Closing as this review request is more than 2 years old. If

Re: Review Request 103101: Add a groupingstrategy to automatically group tasks that are grouped using kwin's windowtabbing

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/103101/#review99453 --- Closing as this review request is more than 2 years old. If

Re: Review Request 108308: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/108308/#review99455 --- Closing as this review request is more than 2 years old. If

Re: Review Request 105677: Plasmapkg: Add KWin/Decoration support to Plasmapkg

2016-09-22 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105677/ --- (Updated Sept. 22, 2016, 8:35 p.m.) Status -- This change has been

Re: Review Request 110504: Group tasks by activity

2016-09-22 Thread José Millán Soto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110504/ --- (Updated Sept. 22, 2016, 8:35 p.m.) Status -- This change has been

Re: Review Request 105677: Plasmapkg: Add KWin/Decoration support to Plasmapkg

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105677/#review99456 --- Closing as this review request is more than 2 years old. If

Re: Review Request 117444: Bug 313734 - konsole profiles widget loses cursor highlight

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117444/#review99464 --- Closing as this review request is more than 2 years old. If

Re: Review Request 117444: Bug 313734 - konsole profiles widget loses cursor highlight

2016-09-22 Thread Jeffrey Enns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117444/ --- (Updated Sept. 22, 2016, 8:39 p.m.) Status -- This change has been

Re: Review Request 117736: Plasmaboard: don't use m_keyboardSize for plasmoid size

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117736/#review84690 --- Closing as this review request is more than 2 years old. If

Re: Review Request 118865: [startkde from plasma next] create ~/.kde directory if it doesn't exist

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118865/#review99470 --- Closing as this review request is more than 2 years old. If

Re: Review Request 105932: Fix for Bug 165792 - Allow multirow panels

2016-09-22 Thread Tobias Franz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105932/ --- (Updated Sept. 22, 2016, 8:35 p.m.) Status -- This change has been

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

2016-09-22 Thread Yichao Zhou
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115431/ --- (Updated Sept. 22, 2016, 8:40 p.m.) Status -- This change has been

Re: Review Request 108308: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

2016-09-22 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/108308/ --- (Updated Sept. 22, 2016, 8:35 p.m.) Status -- This change has been

Re: Review Request 117750: populate the konsole and enable it by default in plasmoidviewer

2016-09-22 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117750/ --- (Updated Sept. 22, 2016, 8:40 p.m.) Status -- This change has been

Re: Review Request 120248: Override the implicitSizes in the ruler completley

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120248/ --- (Updated Sept. 22, 2016, 8:36 p.m.) Status -- This change has been

Re: Review Request 112208: KMix qml applet

2016-09-22 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/ --- (Updated Sept. 22, 2016, 8:41 p.m.) Status -- This change has been

Re: Review Request 117494: Proposed Patch for Bug 198661 - Add option to disable scroll on taskbar

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117494/#review99473 --- Closing as this review request is more than 2 years old. If

Re: Review Request 120306: Exclude X11 when building for Wayland

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120306/#review99474 --- Closing as this review request is more than 2 years old. If

Re: Review Request 120306: Exclude X11 when building for Wayland

2016-09-22 Thread Pier Luigi Fiorini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120306/ --- (Updated Sept. 22, 2016, 8:43 p.m.) Status -- This change has been

Re: Review Request 112812: Use type description sort order in devicenotifier when non-removable devices are displayed

2016-09-22 Thread Benedikt Gollatz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112812/ --- (Updated Sept. 22, 2016, 8:35 p.m.) Status -- This change has been

Re: Review Request 117139: Make menu strings conform to KDE's usability guidelines. Capitalize menu words.

2016-09-22 Thread Nikolaos Chatzidakis
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117139/ --- (Updated Sept. 22, 2016, 8:43 p.m.) Status -- This change has been

Re: Review Request 126640: [WindowThumbnail] Discard pixmap on map events.

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126640/#review99440 --- Ship it! So sorry we missed this for so long. I'm not

Re: Review Request 119990: Fix libraries and includes to follow the KF5 naming scheme

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119990/#review99441 --- Closing as this review request is more than 2 years old. If

Re: Review Request 107869: Add a real konquerorsessions plugin for krunner

2016-09-22 Thread Jekyll Wu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107869/ --- (Updated Sept. 22, 2016, 8:33 p.m.) Status -- This change has been

Re: Review Request 107869: Add a real konquerorsessions plugin for krunner

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107869/#review99447 --- Closing as this review request is more than 2 years old. If

Re: Review Request 109124: qml port currentappcontrol

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109124/#review99446 --- Closing as this review request is more than 2 years old. If

Re: Review Request 117139: Make menu strings conform to KDE's usability guidelines. Capitalize menu words.

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117139/#review99445 --- Closing as this review request is more than 2 years old. If

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114428/#review99444 --- Closing as this review request is more than 2 years old. If

Re: Review Request 109124: qml port currentappcontrol

2016-09-22 Thread Gregor Tätzner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109124/ --- (Updated Sept. 22, 2016, 8:32 p.m.) Status -- This change has been

Re: Review Request 107868: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does

2016-09-22 Thread Jekyll Wu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107868/ --- (Updated Sept. 22, 2016, 8:33 p.m.) Status -- This change has been

Re: Review Request 107868: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107868/#review99448 --- Closing as this review request is more than 2 years old. If

Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2016-09-22 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114424/ --- (Updated Sept. 22, 2016, 8:34 p.m.) Status -- This change has been

Re: Review Request 102291: Trigger installation of missing components when installing a package

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102291/#review99450 --- Closing as this review request is more than 2 years old. If

Re: Review Request 102727: quicklaunch: Add a confirmation dialog before the delete

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102727/#review99452 --- Closing as this review request is more than 2 years old. If

Re: Review Request 102350: Implement automatic scanning of source code for required data engines

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102350/#review99451 --- Closing as this review request is more than 2 years old. If

Re: Review Request 102350: Implement automatic scanning of source code for required data engines

2016-09-22 Thread Kevin Kofler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102350/ --- (Updated Sept. 22, 2016, 8:34 p.m.) Status -- This change has been

Re: Review Request 102291: Trigger installation of missing components when installing a package

2016-09-22 Thread Kevin Kofler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102291/ --- (Updated Sept. 22, 2016, 8:34 p.m.) Status -- This change has been

Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114424/#review99449 --- Closing as this review request is more than 2 years old. If

  1   2   >