davidedmundson added a comment.
There /shoud/ be a blur applied that's not being shown in the original
screenshot.
Can I see the output of:
qdbus org.kde.KWin /KWin supportInformation
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2913
dfaure created this revision.
dfaure added reviewers: broulik, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Many actions were coming from this code anyway, all that was missing
was:
- Copy To / Move To
jsalatas added a comment.
There is no blur effect (I'm running it in a Virtual Machine with no 3D
acceleration).
Here is the output of the qdbus org.kde.KWin /KWin supportInformation command
# qdbus org.kde.KWin /KWin supportInformation
KWin Support Information:
The
davidedmundson added a comment.
Also, I just looked over your first patch.
That event filter was weird, but there wasn't any reason to move away from a
formLayout.
you could have set a setFieldGrowthPolicy on the form layout to
ExpandingFieldsGrow
Then set the spinboxes to
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2853
EMAIL PREFERENCES
jsalatas created this revision.
jsalatas added reviewers: Plasma, Plasma: Design.
jsalatas added a subscriber: apol.
jsalatas set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber:
marten added a comment.
Thanks for the hint David... I thought that I'd tried the approach of setting
the fieldGrowthPolicy and the sizePolicy of the fields, and the problem with
that was that the spinboxes were then extended to the full width of the form -
not looking good, as well as
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129086/
---
Review request for KDE Frameworks and Plasma.
Repository:
https://bugs.kde.org/show_bug.cgi?id=341762
--- Comment #11 from bl...@vivaldi.net ---
Maybe it was fixed with Qt5.7. I have Qt5.6.1.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.kde.org/show_bug.cgi?id=341762
Rik Mills changed:
What|Removed |Added
CC||rik.mill...@gmail.com
---
broulik added a comment.
I just updated and now my login screen is broken (sddm 0.13):
file:///usr/share/sddm/themes/breeze/Main.qml:87 Cannot assign to
non-existent property "showUserList"
INLINE COMMENTS
> Main.qml:87
> userListCurrentIndex: userModel.lastIndex >= 0 ?
Hi,I just updated my neon unstable install and my login screen is broken now:file:///usr/share/sddm/themes/breeze/Main.qml:87 Cannot assign to non-existent property "showUserList"As far as I can see this was caused by [1] because Login {} does not have a property showUserList.Since this is in 5.8
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
we can start launching ksmserver in the meantime
TEST PLAN
Logged in
REPOSITORY
Release on Tuesday, that is. Also, I have SDDM 0.13 and not 0.14 :)
broulik added a comment.
I think the problem is
import "components"
so it uses the Login from components which does not have that because it
looks up imports first before looking in the current directory. Importing
"components" under a namespace fixes it for me.
REPOSITORY
broulik created this revision.
broulik added reviewers: Plasma, jriddell.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
QML imports
davidedmundson added a comment.
This is in Plasma/5.8, so if it is a problem we need to do some emergency
panicking, but as far as I can see it's fine?
INLINE COMMENTS
> broulik wrote in Main.qml:87
> This property does not exist in Login breaking the login screen!
It does?
davidedmundson added a comment.
there is no Login in components.
only:
ActionButton.qml artwork Battery.qml Clock.qml KeyboardLayoutButton.qml
SessionManagementScreen.qml UserDelegate.qml UserList.qml
I think you might be trying to install onto 5.7 without clearing the old
broulik added a comment.
Ok, now I feel stupid. But I was in adrenaline panicky release blocker mode.
I reinstalled all the things from scratch and it works. Meh :( I wanted to be
the hero of the day! :D
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
broulik abandoned this revision.
broulik added a comment.
Local screwup :(
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2911
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, jriddell
Cc:
Nevermind. It was a local mixture of 5.7 and 5.8 stuff.
I was so excited to get a cookie from fixing our release \o/ :(
21 matches
Mail list logo