[Differential] [Changed Subscribers] D3049: Support passing generic QIcon through PlasmaWindow interface

apol added inline comments. INLINE COMMENTS > plasmawindowmanagement_interface.cpp:386 > +{ > +m_icon = icon; > +setThemedIconName(m_icon.name()); maybe worth adding a `if (m_icon == icon) return;` REPOSITORY rKWAYLAND KWayland BRANCH plasma-window-icon REVISION DETAIL

Review Request 129187: Fix dangling pointer in KPackageJob

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129187/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage

Re: Review Request 129187: Fix dangling pointer in KPackageJob

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129187/ --- (Updated Oct. 14, 2016, 9:43 p.m.) Review request for KDE Frameworks and

[Powerdevil] [Bug 370667] powerdevil crashes on battery low

https://bugs.kde.org/show_bug.cgi?id=370667 Kai Uwe Broulik changed: What|Removed |Added Resolution|--- |FIXED Latest

[Powerdevil] [Bug 370667] powerdevil crashes on battery low

https://bugs.kde.org/show_bug.cgi?id=370667 --- Comment #5 from Kai Uwe Broulik --- You can compile knotifications framework yourself or wait for the next KDE Frameworks release in a month. -- You are receiving this mail because: You are the assignee for the bug.

[Differential] [Updated, 231 lines] D3049: Support passing generic QIcon through PlasmaWindow interface

graesslin updated this revision to Diff 7384. graesslin added a comment. - Pass icon as argument to the runnable - use pipe2 - close pipefd in error handling branch REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3049?vs=7376=7384 BRANCH

[Differential] [Request, 3 lines] D3054: Remove uneeded timeout monitor

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's in case klauncher fails to return from autostart, however autostart is now handled by

[Powerdevil] [Bug 370667] powerdevil crashes on battery low

https://bugs.kde.org/show_bug.cgi?id=370667 --- Comment #4 from Nikola Dodik --- Thanks for looking into it. Is there some way to pull this patch, or should I wait for the next release? -- You are receiving this mail because: You are the assignee for the bug.

[Differential] [Request, 49 lines] D3053: fix "Default" color scheme

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY for every color scheme entry, use an actual KColorscheme instance that loads the kconfiggroup representing the

[Differential] [Closed] D3053: fix "Default" color scheme

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP8f20f4eb4865: fix "Default" color scheme (authored by mart). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3053?vs=7386=7389 REVISION

[Differential] [Commented On] D3049: Support passing generic QIcon through PlasmaWindow interface

graesslin added inline comments. INLINE COMMENTS > roberts wrote in plasmawindowmanagement_interface.cpp:406 > Is there anything protecting this from being unsynchronised parallel access > to m_icon (and p)? > > Simplest solution might be passing the icon by value into the lambda. I assumed

[Differential] [Updated] D3049: Support passing generic QIcon through PlasmaWindow interface

graesslin marked 3 inline comments as done. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D3049 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, hein Cc: roberts, plasma-devel, lesliezhai,

[Differential] [Request, 40 lines] D3062: Hide "automatic login" button in UserAccounts since is does absolutely nothing

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY automaticLogin only sets a flag in AccountsService, which is only supported by GDM. Hide

[Differential] [Commented On] D3062: Hide "automatic login" button in UserAccounts since is does absolutely nothing

davidedmundson added a comment. On further investigation, the AccountsService automaticlogin thing will /never/ work. It writes into etc/gdm/custom.conf and if that doesn't exist, it will just retun an error. So it's not a case of just making SDDM do this, and this isn't a temporary

Re: Review Request 129187: Fix dangling pointer in KPackageJob

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129187/#review100014 --- src/kpackage/package.cpp (line 66)

[Differential] [Request, 19 lines] D3056: Fix glBlitFramebuffer for per-output rendering

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY This is similar to

[Differential] [Request, 40 lines] D3058: Pass the current output geometry to ScreenPaintData

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY On Wayland per output rendering is performed and paintScreen is

[Differential] [Commented On] D3055: Small polishing changes to the lockscreen lookandfeel package

davidedmundson added inline comments. INLINE COMMENTS > LockScreenUi.qml:134 > +// Set focus to password field or the switch user screen > dependent on what the current item is > +currentItem.focusItem.focus = true > } you don't need to

[Differential] [Updated] D3058: Pass the current output geometry to ScreenPaintData

graesslin added a dependent revision: D3059: [effects] Make screenshot effect work with multiple output rendering. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3058 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin,

[Differential] [Updated] D3056: Fix glBlitFramebuffer for per-output rendering

graesslin added a dependent revision: D3059: [effects] Make screenshot effect work with multiple output rendering. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3056 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin,

[Differential] [Accepted] D3054: Remove uneeded timeout monitor

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3054 EMAIL PREFERENCES

[Differential] [Updated] D3057: Fix drawing QtQuickControls ComboBox popups

drosca updated the test plan for this revision. drosca added reviewers: broulik, hpereiradacosta. REPOSITORY rOXYGEN Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D3057 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, broulik,

[Differential] [Request, 228 lines] D3055: Small polishing changes to the lockscreen lookandfeel package

subdiff created this revision. subdiff added a reviewer: davidedmundson. subdiff set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. subdiff added projects: Plasma, VDG. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Several small improvements

[Differential] [Abandoned] D3048: [Colors KCM] Default scheme is now installed as a file

ochurlaud abandoned this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3048 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, #plasma, broulik, mart Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Request, 127 lines] D3057: Fix drawing QtQuickControls ComboBox popups

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Implement drawing QStyleOptionFrame QFrame::StyledPanel shape. Adaptation of the same commit from Breeze,

[Differential] [Commented On] D3059: [effects] Make screenshot effect work with multiple output rendering

graesslin added a comment. F363241: kwin_screenshot_n11930.png - Plasma/Wayland multi screen screenshot. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3059 EMAIL PREFERENCES

[Differential] [Updated] D3059: [effects] Make screenshot effect work with multiple output rendering

graesslin added dependencies: D3058: Pass the current output geometry to ScreenPaintData, D3056: Fix glBlitFramebuffer for per-output rendering. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3059 EMAIL PREFERENCES

[Differential] [Updated] D3057: Fix drawing QtQuickControls ComboBox popups

hpereiradacosta added a comment. Well, that works, of course, but in principle, copying the helper functions from breeze should not be necessary. Oxygen should have everything instrumented already, and using the 'correct' oxygen mixing of colors, frame radius, etc, as opposed to breeze'

[Differential] [Request, 98 lines] D3059: [effects] Make screenshot effect work with multiple output rendering

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY Adjusts the screenshot effect to mutliple output rendering. In that

Re: Review Request 127308: Fix name of desktop file to have icon working on Wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127308/ --- (Updated Oct. 14, 2016, 4:23 p.m.) Status -- This change has been

[Differential] [Commented On] D3062: Hide "automatic login" button in UserAccounts since is does absolutely nothing

subdiff added a comment. I would just delete it, because as you say having the same settings in two places is messy. But if there is a nice way of informing the user about the different place of the setting, we should do that. REPOSITORY rUSERMANAGER User Manager REVISION DETAIL

[Differential] [Changed Subscribers] D3062: Hide "automatic login" button in UserAccounts since is does absolutely nothing

subdiff added inline comments. INLINE COMMENTS > accountinfo.cpp:66 > +m_info->automaticLogin->setVisible(false); > +m_info->automaticLoginLabel->setVisible(false); > + Maybe only hide the checkbox and add a small description for users, that they can find the option in the sddm kcm for

[Powerdevil] [Bug 370667] powerdevil crashes on battery low

https://bugs.kde.org/show_bug.cgi?id=370667 Kai Uwe Broulik changed: What|Removed |Added CC|

[Differential] [Request, 3 lines] D3051: [applets/notification] Add nullptr check

graesslin created this revision. graesslin added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Hit a crash there, this change prevents it: Thread 1 "plasmashell" received signal SIGSEGV,

[Powerdevil] [Bug 370667] powerdevil crashes on battery low

https://bugs.kde.org/show_bug.cgi?id=370667 --- Comment #2 from Nikola Dodik --- I think I am using the plasmoid? I honestly don't know. I'm using whatever there is in the bottom right corner of my screen. How can I find this out for you? -- You are receiving

[Differential] [Updated] D3051: [applets/notification] Add nullptr check

broulik added a comment. While in principle the patch is fine, the only way this can be null is when NotificationPopup.qml (which is a Plasma Dialog) failed to load, so I think we're masking a deeper problem here. var popup = notificationPopupComponent.createObject();

[Differential] [Commented On] D2957: [SDDM Theme] Offer switching to the user's session if there is one

davidedmundson added a comment. In https://phabricator.kde.org/D2957#56665, @subdiff wrote: > Is this Differential abandoned? I think the proposed behavioural change is greatly needed! If I'm too lazy to add this to SDDM before 5.9 we can push this. (and you can treat this

[Differential] [Updated, 233 lines] D3055: Small polishing changes to the lockscreen lookandfeel package

subdiff removed rPLASMAWORKSPACE Plasma Workspace as the repository for this revision. subdiff updated this revision to Diff 7399. subdiff marked an inline comment as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3055?vs=7391=7399 REVISION DETAIL

[Differential] [Updated] D3055: Small polishing changes to the lockscreen lookandfeel package

subdiff set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3055 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, davidedmundson

[Differential] [Commented On] D2957: [SDDM Theme] Offer switching to the user's session if there is one

subdiff added a comment. Is this Differential abandoned? I think the proposed behavioural change is greatly needed! I'm doing some small work on the lock screen at the moment and while testing I created sometimes accidentally a second user session in sddm, which always (!) locked up my

[Differential] [Commented On] D3055: Small polishing changes to the lockscreen lookandfeel package

subdiff added inline comments. INLINE COMMENTS > davidedmundson wrote in LockScreenUi.qml:134 > you don't need to do this. (and if you do need to do this, something else is > wrong) > > They're within separate focus scopes, both "focusitems" should always have > focus, then you switch

[Differential] [Accepted] D3049: Support passing generic QIcon through PlasmaWindow interface

roberts accepted this revision. roberts added a reviewer: roberts. roberts added a comment. This revision is now accepted and ready to land. Looks good to me now. REPOSITORY rKWAYLAND KWayland BRANCH plasma-window-icon REVISION DETAIL https://phabricator.kde.org/D3049 EMAIL