Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

2016-10-17 Thread Burkhard Lück
> On Sept. 15, 2016, 7:28 vorm., Luigi Toscano wrote: > > Can they be made co-installable with the ones with kde-runtime, as both > > modules can be available at the same time? This is the problem of the > > missing support for kcontrol5 > > > > It was already done some time ago and I had to

[Differential] [Commented On] D3062: Hide "automatic login" button in UserAccounts since is does absolutely nothing

2016-10-17 Thread mart (Marco Martin)
mart added a comment. shouldn't be completely removed then? REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D3062 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: mart, subdiff,

Re: Review Request 129203: Fixes for building plasma-framework

2016-10-17 Thread Alberto Curro
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129203/ --- (Updated Oct. 17, 2016, 7:35 a.m.) Review request for Plasma. Changes

Re: Review Request 129203: Fixes for building plasma-framework

2016-10-17 Thread Alberto Curro
> On Oct. 17, 2016, 4:51 a.m., Anthony Fieroni wrote: > > CMakeLists.txt, line 47 > > > > > > You can't increase minimum deps only for this framework. It's done > > automatically for all and when it's needed.

[Differential] [Request, 370 lines] D3080: Panel auto hide support for Wayland panels

2016-10-17 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland, bshah. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY This change implements auto-hide support for Wayland panels.

Re: System Settings KCM cleanup (KIO)

2016-10-17 Thread Sebastian Kügler
On zaterdag 15 oktober 2016 13:32:35 CEST kainz.a wrote: > there are some KCM's the default user didn't need, some of them are also > broken. It need some time to realize that the KCM's are from KIO. > > connectivity -> Samba Shares (didn't work) Then it should be fixed... > some kcm's are

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

2016-10-17 Thread Martin Gräßlin
> On Oct. 17, 2016, 10:26 a.m., David Edmundson wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 151 > > > > > > Because AppletInterface::activated is a signal, applets could connect > > to

[Differential] [Accepted] D3055: Small polishing changes to the lockscreen lookandfeel package

2016-10-17 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3055 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff,

Re: Review Request 129203: Fixes for building plasma-framework

2016-10-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129203/#review100069 --- src/declarativeimports/core/windowthumbnail.cpp (line 231)

[Differential] [Commented On] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

2016-10-17 Thread subdiff (Roman Gilg)
subdiff added a comment. In https://phabricator.kde.org/D3079#57067, @davidedmundson wrote: > This breaks the normal keyboard shortcut working at all. > > You either need to connect to both or > > if we put in the addition emit I suggest in

[Differential] [Updated] D3080: Panel auto hide support for Wayland panels

2016-10-17 Thread Martin Gräßlin
graesslin added a dependency: D3007: Add auto-hiding panel support to PlasmaShellSurface interface. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3080 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin,

[Differential] [Updated] D3007: Add auto-hiding panel support to PlasmaShellSurface interface

2016-10-17 Thread Martin Gräßlin
graesslin added a dependent revision: D3080: Panel auto hide support for Wayland panels. REPOSITORY rKWAYLAND KWayland BRANCH panel-auto-hide REVISION DETAIL https://phabricator.kde.org/D3007 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D3071: Port away from KDELibs4Support

2016-10-17 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rUSERMANAGER User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D3071 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

2016-10-17 Thread Roman Gilg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129204/ --- (Updated Okt. 17, 2016, 9:02 vorm.) Review request for Plasma and Martin

[Differential] [Closed] D3056: Fix glBlitFramebuffer for per-output rendering

2016-10-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN4e9a1eeb5036: Fix glBlitFramebuffer for per-output rendering (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3056?vs=7392=7446 REVISION

[Differential] [Closed] D3059: [effects] Make screenshot effect work with multiple output rendering

2016-10-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINeadfcb3d4f12: [effects] Make screenshot effect work with multiple output rendering (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3058: Pass the current output geometry to ScreenPaintData

2016-10-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN359224a5dcf9: Pass the current output geometry to ScreenPaintData (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3058?vs=7395=7449 REVISION

[Differential] [Closed] D3047: Support custom color scheme for Wayland windows

2016-10-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINf41b610608a4: Support custom color scheme for Wayland windows (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3047?vs=7370=7445 REVISION

[Differential] [Closed] D3023: Set icon to wayland if desktop file is not found

2016-10-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN8201def97fcc: Set icon to wayland if desktop file is not found (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3023?vs=7308=7444 REVISION

[Differential] [Closed] D3050: Use new PlasmaWindowInterface::setIcon

2016-10-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN05d21b6b25ce: Use new PlasmaWindowInterface::setIcon (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3050?vs=7377=7447 REVISION DETAIL

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

2016-10-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129204/#review100067 --- src/scriptengines/qml/plasmoid/appletinterface.cpp (line

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

2016-10-17 Thread David Edmundson
> On Oct. 17, 2016, 8:26 a.m., David Edmundson wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 151 > > > > > > Because AppletInterface::activated is a signal, applets could connect > > to to

[Differential] [Commented On] D3009: Fix logout translation message

2016-10-17 Thread guoyunhe (Yunhe Guo)
guoyunhe added a comment. In https://phabricator.kde.org/D3009#57056, @davidedmundson wrote: > Do you have commit access? No, I do not have. REVISION DETAIL https://phabricator.kde.org/D3009 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

2016-10-17 Thread Kai Uwe Broulik
> On Okt. 17, 2016, 8:26 vorm., David Edmundson wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 151 > > > > > > Because AppletInterface::activated is a signal, applets could connect > > to

[Differential] [Commented On] D3009: Fix logout translation message

2016-10-17 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. Do you have commit access? REVISION DETAIL https://phabricator.kde.org/D3009 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: guoyunhe, #plasma_workspaces, mart Cc: davidedmundson, mart, plasma-devel, lesliezhai,

[Differential] [Accepted] D3078: Add new DBus method for applet de-/activation and in order to fix non-closing launchers on Meta (and also on Active Screenedges)

2016-10-17 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3078 EMAIL PREFERENCES

[Differential] [Commented On] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

2016-10-17 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. This breaks the normal keyboard shortcut working at all. You either need to connect to both or if we put in the addition emit I suggest in https://git.reviewboard.kde.org/r/129204/ and then you don't need this change. REPOSITORY rPLASMADESKTOP

Re: Breakout: * multiscreen behaviour: how should Plasma exactly behave in different scenarios?

2016-10-17 Thread Martin Klapetek
On Mon, Oct 17, 2016 at 12:59 PM, Jonathan Riddell wrote: > biggest pain point from bugzilla is mostly still > multiscreen. I'm not sure we have a solid plan of what /should/ happen > in each situation. > panel gets added to screen 1 and 2, you disconnect screen > 2.

[Differential] [Commented On] D3085: RFC: Use DBusMenu if available

2016-10-17 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > broulik wrote in kdeplatformtheme.cpp:59 > That's what Qt does and I don't think Qt is equipped to re-create a platform > menu at runtime; at least that's what I was told when I raised the very same > concern in the upstream Qt codereview that

[Differential] [Changed Subscribers] D3089: WIP: Restore global menu support

2016-10-17 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > CMakeLists.txt:276-278 > +option(KWIN_BUILD_KAPPMENU "Enable building of KWin with application menu > support" ON) > +# cmake_dependent_option(KWIN_BUILD_KAPPMENU "Build without appmenu support" > ON "KWIN_BUILD_DECORATIONS" FALSE) > + I'm

[Differential] [Accepted] D3084: [shell] Support autohide panel on wayland

2016-10-17 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH panel-autohide REVISION DETAIL https://phabricator.kde.org/D3084 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Closed] D3007: Add auto-hiding panel support to PlasmaShellSurface interface

2016-10-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDe772a3e9fa81: Add auto-hiding panel support to PlasmaShellSurface interface (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3035: Add request to have focus in a PlasmaShellSurface of Role Panel

2016-10-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDee3f47a597f7: Add request to have focus in a PlasmaShellSurface of Role Panel (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3035?vs=7344=7482#toc REPOSITORY

[Differential] [Updated] D3035: Add request to have focus in a PlasmaShellSurface of Role Panel

2016-10-17 Thread Martin Gräßlin
graesslin marked 3 inline comments as done. REPOSITORY rKWAYLAND KWayland BRANCH panel-takes-focus REVISION DETAIL https://phabricator.kde.org/D3035 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, sebas Cc: sebas,

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

2016-10-17 Thread Roman Gilg
> On Okt. 17, 2016, 12:22 nachm., Marco Martin wrote: > > src/scriptengines/qml/plasmoid/appletinterface.h, line 408 > > > > > > it would be nice a bool paramenter here with the new value of expanded Dropped

Re:

2016-10-17 Thread Marco Martin
On Monday 17 October 2016, Jonathan Riddell wrote: > what Qt version will 5.9 require? 5.6 still or 5.7? would like 5.7 to allow preliminary use of QtQuickControls2, if there aren't significant drawbacks -- Marco Martin

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

2016-10-17 Thread Roman Gilg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129204/ --- (Updated Okt. 17, 2016, 8:40 nachm.) Review request for Plasma and

[Differential] [Closed] D2996: [kwinrules] Hide all autogroup related widgets

2016-10-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINdb95b96854e5: [kwinrules] Hide all autogroup related widgets (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2996?vs=7240=7435 REVISION

[Differential] [Closed] D2943: Support LEDs in Xkb and libinput

2016-10-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN4c7752c965ab: Support LEDs in Xkb and libinput (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2943?vs=7112=7434 REVISION DETAIL

[Differential] [Closed] D3015: Fix shortcut triggering with shift+letter

2016-10-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN78a2732a9a42: Fix shortcut triggering with shift+letter (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3015?vs=7293=7436 REVISION DETAIL

Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

2016-10-17 Thread Roman Gilg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129204/ --- Review request for Plasma. Bugs: 367685

Info about data from store.kde.org + kdepim

2016-10-17 Thread laurent Montel
Hi, Before store.kde.org, kdepim ues knewstuff to get data from server. We had for example kmail header theme on old server. But now in new server I can't see them. Do you have an idea why we don't get them now ? Thanks for info. Regards -- Laurent Montel | laurent.mon...@kdab.com |

[Differential] [Closed] D2953: [tabbox] Intercept QWheelEvents on QQuickWindow for scrolling

2016-10-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINe9d20b80e9a7: [tabbox] Intercept QWheelEvents on QQuickWindow for scrolling (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2953?vs=7337=7438

[Differential] [Closed] D3044: Set color scheme X property in the X11Integration

2016-10-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATIONe47245f96ed1: Set color scheme X property in the X11Integration (authored by graesslin). REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES SINCE LAST

[Differential] [Closed] D3046: Pass color scheme hint to Wayland compositor using window property

2016-10-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATIONf8a0f8c0c82e: Pass color scheme hint to Wayland compositor using window property (authored by graesslin). REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma

[Differential] [Request, 25 lines] D3078: Add new DBus method for applet de-/activation and in order to fix non-closing launchers on Meta (and also on Active Screenedges)

2016-10-17 Thread subdiff (Roman Gilg)
subdiff created this revision. subdiff added a subscriber: Plasma. subdiff set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. subdiff added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Add new DBus method for toggling the

[Differential] [Changed Policy] D3064: Port away from KDELibs4Support

2016-10-17 Thread davidk (David Kahles)
davidk changed the visibility from "No One" to "All Users". REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D3064 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidk Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Commented On] D3064: Port away from KDELibs4Support

2016-10-17 Thread davidk (David Kahles)
davidk added a comment. Abandoned, because it includes stuff which should be in it's own RR. REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D3064 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidk Cc:

[Differential] [Updated, 208 lines] D3019: [kstyle] Implement window moving on Wayland

2016-10-17 Thread Martin Gräßlin
graesslin updated this revision to Diff 7443. graesslin added a comment. Moved the hasPointer lambda into an own method for better readability and less nesting. The registry interfacesAnnounced is still a lambda to not need to keep the variable around and the handling of the pointer

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

2016-10-17 Thread Roman Gilg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129204/ --- (Updated Okt. 17, 2016, 8:43 vorm.) Review request for Plasma and Martin

[Differential] [Request, 2 lines] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

2016-10-17 Thread subdiff (Roman Gilg)
subdiff created this revision. subdiff added reviewers: graesslin, broulik. subdiff added a subscriber: Plasma. subdiff set the repository for this revision to rPLASMADESKTOP Plasma Desktop. subdiff added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY

[Differential] [Updated] D3078: Add new DBus method for applet de-/activation and in order to fix non-closing launchers on Meta (and also on Active Screenedges)

2016-10-17 Thread subdiff (Roman Gilg)
subdiff added a reviewer: graesslin. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3078 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, graesslin Cc: plasma-devel, #plasma, lesliezhai, ali-mohamed,

Re: Review Request 129150: Use less deprecated API

2016-10-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129150/ --- (Updated Oct. 17, 2016, 11:48 a.m.) Status -- This change has been

Re: Review Request 129203: Fixes for building plasma-framework

2016-10-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129203/#review100077 --- Ship it! Do you have commit access? - David Edmundson

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

2016-10-17 Thread Luigi Toscano
> On Sept. 15, 2016, 9:28 a.m., Luigi Toscano wrote: > > Can they be made co-installable with the ones with kde-runtime, as both > > modules can be available at the same time? This is the problem of the > > missing support for kcontrol5 > > > > It was already done some time ago and I had to

Re: Review Request 129150: Use less deprecated API

2016-10-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129150/#review100081 --- Ship it! Ship It! - Marco Martin On Oct. 11, 2016,

Re: Plasma Sprint vs FOSDEM

2016-10-17 Thread Sebastian Kügler
On maandag 17 oktober 2016 12:33:32 CEST Kai Uwe Broulik wrote: > I decided on 6 February through 12 February for the Plasma sprint. Although > there was a thread on the ml and nobody objected, there were concerns now > that it might conflict with FOSDEM which is on 4/5 February. > > ‎Is this an

Re: Review Request 129157: Desktop Settings Tweaks

2016-10-17 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129157/ --- (Updated Oct. 17, 2016, 10:42 a.m.) Status -- This change has been

Re: Review Request 129091: Add icons for Kimpanel and Fcitx

2016-10-17 Thread Marco Martin
> On Oct. 17, 2016, 10:38 a.m., Marco Martin wrote: > > should those be themed in the plasma theme? > > shouldn't them just go in the regular breeze icon theme? > > Yunhe Guo wrote: > I have discussed with Breeze icon team. They suggest to move these icons > to plasma theme since they are

Re: Review Request 129091: Add icons for Kimpanel and Fcitx

2016-10-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/#review100083 --- should those be themed in the plasma theme? shouldn't them

Plasma Sprint vs FOSDEM

2016-10-17 Thread Kai Uwe Broulik
Hi all, I decided on 6 February through 12 February for the Plasma sprint. Although there was a thread on the ml and nobody objected, there were concerns now that it might conflict with FOSDEM which is on 4/5 February.  ‎Is this an issue for anyone?  Cheers,  Kai Uwe ‎

Re: Plasma Sprint vs FOSDEM

2016-10-17 Thread Marco Martin
On Monday 17 October 2016, Kai Uwe Broulik wrote: > Hi all, > > I decided on 6 February through 12 February for the Plasma sprint. Although > there was a thread on the ml and nobody objected, there were concerns now > that it might conflict with FOSDEM which is on 4/5 February. > > ‎Is this an

Re: Plasma Sprint vs FOSDEM

2016-10-17 Thread Aleix Pol
On Mon, Oct 17, 2016 at 12:33 PM, Kai Uwe Broulik wrote: > Hi all, > > I decided on 6 February through 12 February for the Plasma sprint. Although > there was a thread on the ml and nobody objected, there were concerns now > that it might conflict with FOSDEM which is

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 45 - Failure!

2016-10-17 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/45/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 17 Oct 2016 12:54:34 + Build duration: 8 min 33 sec CHANGE SET Revision

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

2016-10-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129204/#review100072 --- src/scriptengines/qml/plasmoid/appletinterface.h (line

Re: Review Request 129098: Add keyboard icons for kimpanel

2016-10-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129098/#review100084 --- Ship it! Ship It! - Marco Martin On Oct. 6, 2016,

Re: Review Request 129091: Add icons for Kimpanel and Fcitx

2016-10-17 Thread Yunhe Guo
> On 十月 17, 2016, 10:38 a.m., Marco Martin wrote: > > should those be themed in the plasma theme? > > shouldn't them just go in the regular breeze icon theme? I have discussed with Breeze icon team. They suggest to move these icons to plasma theme since they are mostly used in system

Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6

2016-10-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129065/#review100087 --- Ship it! Ship It! - Marco Martin On Sept. 29, 2016,

Re: System Settings KCM cleanup (KIO)

2016-10-17 Thread Burkhard Lück
Am Samstag, 15. Oktober 2016, 13:32:35 CEST schrieb kainz.a: > Hi, > > there are some KCM's the default user didn't need, some of them are also > broken. It need some time to realize that the KCM's are from KIO. > > connectivity -> Samba Shares (didn't work) > > some kcm's are available but

[Differential] [Request, 20 lines] D3083: Mute volume when decreasing volume to zero

2016-10-17 Thread drosca (David Rosca)
drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When decreasing the volume to minimal value (zero) with global shortcuts, the OSD shows the volume as muted.

[Differential] [Request, 2,180 lines] D3086: RFC: Clean up KAppMenu

2016-10-17 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is part two in a

[Differential] [Updated] D3084: [shell] Support autohide panel on wayland

2016-10-17 Thread Martin Gräßlin
graesslin added a comment. Wayland side looks good to me. INLINE COMMENTS > panelview.cpp:651 > xcb_change_property(c, XCB_PROP_MODE_REPLACE, winId(), atom->atom, > XCB_ATOM_CARDINAL, 32, 1, ); > KWindowEffects::slideWindow(winId(), slideLocation, -1); > } do we also

5.9 Kickoff Meeting Notes

2016-10-17 Thread Jonathan Riddell
Here's some notes from the 5.9 Kickoff meeting https://notes.kde.org/p/PlasmaKickoff5.9 I'll post about the breakout topics in following e-mails Sebas will write a blog of this up today Plasma 5.9 Kickoff Meeting present: Riddell, sebas, d_ed, jens, mgraesslin, bshah, llucas, notmart, alex-l,

Minutes Monday Plasma Meeting

2016-10-17 Thread Sebastian Kügler
Plasma Meeting 17th October, 2016, 12:00, via IRC present: mgraesslin, notmart, romangg, bshah, kbroulik, d_ed, Riddell, Sho, sebas mgraesslin: * send pointer events to all wl_pointer (D3016) Diff 3016 "[server] Send pointer events to all wl_pointer resources of a client" [Closed]

Re: Review Request 129203: Fixes for building plasma-framework

2016-10-17 Thread Alberto Curro
> On Oct. 17, 2016, 8:37 a.m., David Edmundson wrote: > > src/declarativeimports/core/windowthumbnail.cpp, line 231 > > > > > > FWIW: https://git.reviewboard.kde.org/r/129065/ I've changed the code, given a

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

2016-10-17 Thread David Edmundson
> On Oct. 17, 2016, 8:26 a.m., David Edmundson wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 151 > > > > > > Because AppletInterface::activated is a signal, applets could connect > > to to

[Differential] [Commented On] D3085: RFC: Use DBusMenu if available

2016-10-17 Thread Martin Gräßlin
graesslin added a comment. Overall significant less code than I expected - nice :-) INLINE COMMENTS > CMakeLists.txt:46 > > +find_package(Qt5PlatformSupport REQUIRED) > + version 5.7? > FindQt5PlatformSupport.cmake:1 > +#.rst: > +# FindQt5PlatformSupport given that it has my copyright I

[Differential] [Updated] D3084: [shell] Support autohide panel on wayland

2016-10-17 Thread bshah (Bhushan Shah)
bshah marked an inline comment as done. bshah added inline comments. INLINE COMMENTS > graesslin wrote in panelview.cpp:651 > do we also need to request the slide for the panel on WAyland? I don't think so.. because from my testing panel sliding seems to work normally. REPOSITORY

Re: Review Request 129203: Fixes for building plasma-framework

2016-10-17 Thread Alberto Curro
> On Oct. 17, 2016, 10:20 a.m., David Edmundson wrote: > > Do you have commit access? I don't think so, it's my first patch and I'm newbie to the KDE development team :) - Alberto --- This is an automatically generated e-mail. To

Re: Review Request 129203: Fixes for building plasma-framework

2016-10-17 Thread Alberto Curro
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129203/ --- (Updated Oct. 17, 2016, 2:53 p.m.) Review request for Plasma. Changes

[Differential] [Commented On] D3085: RFC: Use DBusMenu if available

2016-10-17 Thread broulik (Kai Uwe Broulik)
broulik added a comment. It's not much code on our side because Qt has the code nowadays. :) INLINE COMMENTS > graesslin wrote in FindQt5PlatformSupport.cmake:1 > given that it has my copyright I assume you copied from kwin - that would be > a reason to move it to ecm. We have two users.

[Differential] [Updated, 7 lines] D3084: [shell] Support autohide panel on wayland

2016-10-17 Thread bshah (Bhushan Shah)
bshah updated this revision to Diff 7459. bshah added a comment. update commit message REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3084?vs=7458=7459 BRANCH panel-autohide REVISION DETAIL https://phabricator.kde.org/D3084

[Differential] [Updated, 7 lines] D3084: [shell] Support autohide panel on wayland

2016-10-17 Thread bshah (Bhushan Shah)
bshah updated this revision to Diff 7460. bshah updated the test plan for this revision. bshah added a comment. edit message for real REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3084?vs=7459=7460 BRANCH panel-autohide REVISION

[Differential] [Accepted] D3080: Panel auto hide support for Wayland panels

2016-10-17 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. Looks good REPOSITORY rKWIN KWin BRANCH panel-autohide-wayland REVISION DETAIL https://phabricator.kde.org/D3080 EMAIL PREFERENCES

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

2016-10-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128912/#review100078 --- Ship it! Ship It! - Marco Martin On Sept. 15, 2016,

Re: Review Request 129157: Desktop Settings Tweaks

2016-10-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129157/#review100079 --- Ship it! Ship It! - Marco Martin On Oct. 12, 2016,

Re: Plasma Sprint vs FOSDEM

2016-10-17 Thread Jonathan Riddell
KDE road trip! David fancy a drive? Jonathan On 17 October 2016 at 11:35, Sebastian Kügler wrote: > On maandag 17 oktober 2016 12:33:32 CEST Kai Uwe Broulik wrote: >> I decided on 6 February through 12 February for the Plasma sprint. Although >> there was a thread on the ml and

Re: Review Request 129103: Generate metadata.json file at build time

2016-10-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129103/#review100089 --- Ship it! Ship It! - Marco Martin On Oct. 4, 2016,

[Differential] [Updated] D3007: Add auto-hiding panel support to PlasmaShellSurface interface

2016-10-17 Thread bshah (Bhushan Shah)
bshah added a dependent revision: D3084: [shell] Support autohide panel on wayland. REPOSITORY rKWAYLAND KWayland BRANCH panel-auto-hide REVISION DETAIL https://phabricator.kde.org/D3007 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin,

[Differential] [Request, 7 lines] D3084: [shell] Support autohide panel on wayland

2016-10-17 Thread bshah (Bhushan Shah)
bshah created this revision. bshah added reviewers: Plasma, graesslin. bshah added a dependency: D3007: Add auto-hiding panel support to PlasmaShellSurface interface. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This

[Differential] [Request, 171 lines] D3085: RFC: Use DBusMenu if available

2016-10-17 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAINTEGRATION Integration for Qt applications in Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 46 - Fixed!

2016-10-17 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/46/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 17 Oct 2016 13:05:39 + Build duration: 6 min 10 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 46 - Fixed!

2016-10-17 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/46/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 17 Oct 2016 13:05:39 + Build duration: 6 min 10 sec CHANGE SET Revision

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

2016-10-17 Thread Roman Gilg
> On Okt. 17, 2016, 10:26 vorm., David Edmundson wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 151 > > > > > > Because AppletInterface::activated is a signal, applets could connect > > to

Review Request 129210: port everything to QCDebug/QCWarning

2016-10-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129210/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 129104: Remove unused member var

2016-10-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129104/ --- (Updated Oct. 17, 2016, 3:45 p.m.) Status -- This change has been

[Differential] [Request, 89 lines] D3088: WIP: Restore application menu button

2016-10-17 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rKDECORATION Window Decoration Library. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rKDECORATION Window

2017 Plasma Release Schedule

2016-10-17 Thread Jonathan Riddell
I've updated our release schedule through to the end of 2017 from discussion at the kickoff meeting today https://community.kde.org/Schedules/Plasma_5 https://calendar.google.com/calendar/embed?src=031gkgqg1hjf8lcmj0em1d2sj8%40group.calendar.google.com=Europe/London The pattern is the one we

Re: Review Request 129210: port everything to QCDebug/QCWarning

2016-10-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129210/#review100103 --- Ship it! Though in future, I wouldn't bother putting a

Re: Review Request 129203: Fixes for building plasma-framework

2016-10-17 Thread Marco Martin
> On Oct. 17, 2016, 10:20 a.m., David Edmundson wrote: > > Do you have commit access? > > Alberto Curro wrote: > I don't think so, it's my first patch and I'm newbie to the KDE > development team :) you a re welcome to get one

  1   2   >