[Differential] [Request, 5 lines] D3146: Manually delete PowerDevil Core on teardown

2016-10-23 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPOWERDEVIL Powerdevil. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The QObject children cleanup routine

[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-23 Thread Thomas Lübking
luebking added inline comments. INLINE COMMENTS > antlarr wrote in x11_platform.cpp:215 > yeah, but then it wouldn't be a synchronous call and it would lose all its > meaning, isn't it? :) No, why? The purpose is to push the freeze timer forward as long as the GUI thread isn't blocked. If the

[Breeze] [Bug 370374] GRUB menu has huge lag due to theme

2016-10-23 Thread Roman via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370374 --- Comment #3 from Roman --- Created attachment 101717 --> https://bugs.kde.org/attachment.cgi?id=101717=edit requested boot and config files Tried out all your steps, problem wasn't solved. After looking at it a bit more, I also

[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-23 Thread antlarr (Antonio Larrosa Jimenez)
antlarr added inline comments. INLINE COMMENTS > luebking wrote in x11_platform.cpp:215 > You should be able to call it as slot (whether QMetaObject::invokeMethod() > works, I've never tried) yeah, but then it wouldn't be a synchronous call and it would lose all its meaning, isn't it? :) >

[Powerdevil] [Bug 362830] Allow lowest brightness when using the brightness down/up buttons

2016-10-23 Thread Pascal d'Hermilly via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=362830 --- Comment #4 from Pascal d'Hermilly --- I'm still having the screen turning off instead of going to lowest brightness in KDE Neon 5.8.2 -- You are receiving this mail because: You are the assignee for the bug.

[Differential] [Accepted] D3146: Manually delete PowerDevil Core on teardown

2016-10-23 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D3146 EMAIL PREFERENCES

[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-23 Thread Thomas Lübking
luebking added inline comments. INLINE COMMENTS > antlarr wrote in x11_platform.cpp:215 > The timer is in another thread, so it can't be stopped/restarted from this > thread. You should be able to call it as slot (whether QMetaObject::invokeMethod() works, I've never tried) > antlarr wrote

[Differential] [Changed Subscribers] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-23 Thread Thomas Lübking
luebking added inline comments. INLINE COMMENTS > composite.h:242 > bool m_composeAtSwapCompletion; > -bool m_firstFrame = true; > +int m_frameCount = 0; > +int m_maxFramesTestedForSafety = 30; m_testedFrames or similar, "Frame Count" is too generic. Alternatively, just use

[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-23 Thread antlarr (Antonio Larrosa Jimenez)
antlarr added inline comments. INLINE COMMENTS > luebking wrote in composite.h:242 > m_testedFrames or similar, "Frame Count" is too generic. > Alternatively, just use some "int m_freezeDectionFrames = 30;" and count > them down (so when < 1, you're done) ok. @graesslin do you prefer a count

[Differential] [Updated] D3141: systemmonitor: Optimise source updates.

2016-10-23 Thread roberts (Lindsay Roberts)
roberts added reviewers: Plasma, apol. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3141 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: roberts, #plasma, apol Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Updated, 61 lines] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-23 Thread antlarr (Antonio Larrosa Jimenez)
antlarr updated this revision to Diff 7613. antlarr added a comment. Restricted Application edited projects, added Plasma; removed KWin. - Remove most overhead caused by the freeze-detection thread CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3132?vs=7599=7613 BRANCH

[Powerdevil] [Bug 371522] New: Hard system freeze at kde startup on battery mode

2016-10-23 Thread Jon Parker via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=371522 Bug ID: 371522 Summary: Hard system freeze at kde startup on battery mode Product: Powerdevil Version: 5.8.0 Platform: Debian testing OS: Linux Status: UNCONFIRMED

moving kdepasswd to plasma-desktop/kcms/useraccount?

2016-10-23 Thread David Faure
I'm working on splitting up kde-baseapps, and I stumbled upon kdepasswd, a tool to change your UNIX password, only used by plasma-desktop/kcms/useraccount. IMHO it doesn't make sense to split it into its own repo, would it be OK for you guys if it moved to the useraccount KCM instead? Not

[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-23 Thread antlarr (Antonio Larrosa Jimenez)
antlarr added a comment. Btw, I tested the last commit on a virtual machine simulating the freeze with a sleep. I'll check tomorrow what's the minimum value for m_maxFramesTestedForSafety that works to detect the real freeze and update its default value. REVISION DETAIL

[Differential] [Request, 20 lines] D3141: systemmonitor: Optimise source updates.

2016-10-23 Thread roberts (Lindsay Roberts)
roberts created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Profiling indicates the highest CPU usage process during idle is the system monitor engine. This attempts to get rid of the most obvious

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2016-10-23 Thread Pascal d'Hermilly via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #2 from Pascal d'Hermilly --- Same on Neon 5.8.2. It's written in QML right? Isn't it just adding this? : style: Text.Outline; styleColor: "black" -- You are receiving this mail because: You are the assignee

Re: moving kdepasswd to plasma-desktop/kcms/useraccount?

2016-10-23 Thread David Edmundson
> plasma-desktop/kcms/useraccount. That effectively doesn't exist anymore. It's disabled in CMakelists, it's only remained because of some weird politics; and because of a mistake over where avatar icons get installed from. Everything Plasma then moved to user-manager (separate repo), which uses

[Differential] [Accepted] D3083: Mute volume when decreasing volume to zero

2016-10-23 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3083 EMAIL PREFERENCES

[Differential] [Accepted] D3134: Bring back usericon region selection

2016-10-23 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rUSERMANAGER User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D3134 EMAIL PREFERENCES

[Differential] [Commented On] D3071: Port away from KDELibs4Support

2016-10-23 Thread apol (Aleix Pol Gonzalez)
apol added a comment. Other than that, LGTM. INLINE COMMENTS > passworddialog.cpp:65 > connect(verifyEdit, SIGNAL(textEdited(QString)), > SLOT(passwordChanged())); > +connect(buttons->button(QDialogButtonBox::Ok), SIGNAL(clicked(bool)), > this, SLOT(accept())); > +

[Differential] [Accepted] D3102: Do not ask for root permissions when it's unnecessary

2016-10-23 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rUSERMANAGER User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D3102 EMAIL PREFERENCES

Re: moving kdepasswd to plasma-desktop/kcms/useraccount?

2016-10-23 Thread Aleix Pol
On Sun, Oct 23, 2016 at 5:46 PM, David Edmundson wrote: >> plasma-desktop/kcms/useraccount. > > That effectively doesn't exist anymore. It's disabled in CMakelists, it's > only remained because of some weird politics; and because of a mistake over > where avatar icons

[Powerdevil] [Bug 371514] Ambiguous "Wireless power saving" in Energy Saving

2016-10-23 Thread Jan Grulich via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=371514 Jan Grulich changed: What|Removed |Added Assignee|lu...@kde.org |plasma-devel@kde.org