broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPOWERDEVIL Powerdevil.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The QObject children cleanup routine
luebking added inline comments.
INLINE COMMENTS
> antlarr wrote in x11_platform.cpp:215
> yeah, but then it wouldn't be a synchronous call and it would lose all its
> meaning, isn't it? :)
No, why? The purpose is to push the freeze timer forward as long as the GUI
thread isn't blocked.
If the
https://bugs.kde.org/show_bug.cgi?id=370374
--- Comment #3 from Roman ---
Created attachment 101717
--> https://bugs.kde.org/attachment.cgi?id=101717=edit
requested boot and config files
Tried out all your steps, problem wasn't solved. After looking at it a bit
more, I also
antlarr added inline comments.
INLINE COMMENTS
> luebking wrote in x11_platform.cpp:215
> You should be able to call it as slot (whether QMetaObject::invokeMethod()
> works, I've never tried)
yeah, but then it wouldn't be a synchronous call and it would lose all its
meaning, isn't it? :)
>
https://bugs.kde.org/show_bug.cgi?id=362830
--- Comment #4 from Pascal d'Hermilly ---
I'm still having the screen turning off instead of going to lowest brightness
in KDE Neon 5.8.2
--
You are receiving this mail because:
You are the assignee for the bug.
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
rPOWERDEVIL Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D3146
EMAIL PREFERENCES
luebking added inline comments.
INLINE COMMENTS
> antlarr wrote in x11_platform.cpp:215
> The timer is in another thread, so it can't be stopped/restarted from this
> thread.
You should be able to call it as slot (whether QMetaObject::invokeMethod()
works, I've never tried)
> antlarr wrote
luebking added inline comments.
INLINE COMMENTS
> composite.h:242
> bool m_composeAtSwapCompletion;
> -bool m_firstFrame = true;
> +int m_frameCount = 0;
> +int m_maxFramesTestedForSafety = 30;
m_testedFrames or similar, "Frame Count" is too generic.
Alternatively, just use
antlarr added inline comments.
INLINE COMMENTS
> luebking wrote in composite.h:242
> m_testedFrames or similar, "Frame Count" is too generic.
> Alternatively, just use some "int m_freezeDectionFrames = 30;" and count
> them down (so when < 1, you're done)
ok. @graesslin do you prefer a count
roberts added reviewers: Plasma, apol.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3141
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: roberts, #plasma, apol
Cc: plasma-devel, lesliezhai, ali-mohamed,
antlarr updated this revision to Diff 7613.
antlarr added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
- Remove most overhead caused by the freeze-detection thread
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3132?vs=7599=7613
BRANCH
https://bugs.kde.org/show_bug.cgi?id=371522
Bug ID: 371522
Summary: Hard system freeze at kde startup on battery mode
Product: Powerdevil
Version: 5.8.0
Platform: Debian testing
OS: Linux
Status: UNCONFIRMED
I'm working on splitting up kde-baseapps, and I stumbled upon kdepasswd, a
tool to change your UNIX password, only used by
plasma-desktop/kcms/useraccount.
IMHO it doesn't make sense to split it into its own repo, would it be OK for
you guys if it moved to the useraccount KCM instead?
Not
antlarr added a comment.
Btw, I tested the last commit on a virtual machine simulating the freeze with
a sleep. I'll check tomorrow what's the minimum value for
m_maxFramesTestedForSafety that works to detect the real freeze and update its
default value.
REVISION DETAIL
roberts created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Profiling indicates the highest CPU usage process during idle is the
system monitor engine. This attempts to get rid of the most obvious
https://bugs.kde.org/show_bug.cgi?id=369676
--- Comment #2 from Pascal d'Hermilly ---
Same on Neon 5.8.2.
It's written in QML right?
Isn't it just adding this? :
style: Text.Outline;
styleColor: "black"
--
You are receiving this mail because:
You are the assignee
> plasma-desktop/kcms/useraccount.
That effectively doesn't exist anymore. It's disabled in CMakelists, it's
only remained because of some weird politics; and because of a mistake over
where avatar icons get installed from.
Everything Plasma then moved to user-manager (separate repo), which uses
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAPA Plasma Audio Volume Applet
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D3083
EMAIL PREFERENCES
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
rUSERMANAGER User Manager
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3134
EMAIL PREFERENCES
apol added a comment.
Other than that, LGTM.
INLINE COMMENTS
> passworddialog.cpp:65
> connect(verifyEdit, SIGNAL(textEdited(QString)),
> SLOT(passwordChanged()));
> +connect(buttons->button(QDialogButtonBox::Ok), SIGNAL(clicked(bool)),
> this, SLOT(accept()));
> +
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
rUSERMANAGER User Manager
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3102
EMAIL PREFERENCES
On Sun, Oct 23, 2016 at 5:46 PM, David Edmundson
wrote:
>> plasma-desktop/kcms/useraccount.
>
> That effectively doesn't exist anymore. It's disabled in CMakelists, it's
> only remained because of some weird politics; and because of a mistake over
> where avatar icons
https://bugs.kde.org/show_bug.cgi?id=371514
Jan Grulich changed:
What|Removed |Added
Assignee|lu...@kde.org |plasma-devel@kde.org
23 matches
Mail list logo